+Moe who recently worked on sign-in/sync related errors (for new MD settings page)
+Mihai/Benoit for new Identity team

Here's a doc I drafted with a list of sync errors & associated strings: https://docs.google.com/a/google.com/document/d/1jEzY44oMWenzJQUIBf1x8dkkqm2PJbYngvQzeXTMkLc/edit?usp=sharing. It says this error is "Not being used anymore," but that's clearly wrong (see attached screenshot).

It seems to me like we should create a new error for this specific case. We should also surface it in the user menu as an error, which we currently don't do (see attached screenshot; no error on user menu. See second screenshot for an example error). Clicking the button in the user menu should just open sync settings in a new tab.

User menu string: Confirm sync settings
User menu button string: Open settings
Settings string: Confirm sync settings to start sync

Let me know if you have any questions.

Deleted: Screen Shot 2016-12-07 at 4.06.06 PM.png 127 KB

	Screen Shot 2016-12-07 at 4.06.06 PM.png 127 KB View Download

Deleted: Screen Shot 2016-12-07 at 4.07.27 PM.png 228 KB

	Screen Shot 2016-12-07 at 4.07.27 PM.png 228 KB View Download

 Issue 725158  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c1d266856c65b2c4238cd7dae00ebcd4cc7cb01

commit 0c1d266856c65b2c4238cd7dae00ebcd4cc7cb01
Author: pnoland <pnoland@chromium.org>
Date: Mon Jun 12 20:49:29 2017

[sync] Display an error when sync settings aren't confirmed

BUG= 672225 
R=skym@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2920853004
Cr-Commit-Position: refs/heads/master@{#478752}

[modify] https://crrev.com/0c1d266856c65b2c4238cd7dae00ebcd4cc7cb01/chrome/app/generated_resources.grd
[modify] https://crrev.com/0c1d266856c65b2c4238cd7dae00ebcd4cc7cb01/chrome/browser/resources/settings/people_page/people_page.js
[modify] https://crrev.com/0c1d266856c65b2c4238cd7dae00ebcd4cc7cb01/chrome/browser/resources/settings/people_page/sync_browser_proxy.js
[modify] https://crrev.com/0c1d266856c65b2c4238cd7dae00ebcd4cc7cb01/chrome/browser/sync/sync_ui_util.cc
[modify] https://crrev.com/0c1d266856c65b2c4238cd7dae00ebcd4cc7cb01/chrome/browser/sync/sync_ui_util.h
[modify] https://crrev.com/0c1d266856c65b2c4238cd7dae00ebcd4cc7cb01/chrome/browser/sync/sync_ui_util_unittest.cc
[modify] https://crrev.com/0c1d266856c65b2c4238cd7dae00ebcd4cc7cb01/chrome/browser/ui/avatar_button_error_controller.cc
[modify] https://crrev.com/0c1d266856c65b2c4238cd7dae00ebcd4cc7cb01/chrome/browser/ui/cocoa/profiles/avatar_button_controller_unittest.mm
[modify] https://crrev.com/0c1d266856c65b2c4238cd7dae00ebcd4cc7cb01/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm
[modify] https://crrev.com/0c1d266856c65b2c4238cd7dae00ebcd4cc7cb01/chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm
[modify] https://crrev.com/0c1d266856c65b2c4238cd7dae00ebcd4cc7cb01/chrome/browser/ui/views/profiles/profile_chooser_view.cc
[modify] https://crrev.com/0c1d266856c65b2c4238cd7dae00ebcd4cc7cb01/chrome/browser/ui/views/profiles/profile_chooser_view.h
[modify] https://crrev.com/0c1d266856c65b2c4238cd7dae00ebcd4cc7cb01/chrome/browser/ui/webui/settings/people_handler.cc
[modify] https://crrev.com/0c1d266856c65b2c4238cd7dae00ebcd4cc7cb01/components/browser_sync/profile_sync_service.cc
[modify] https://crrev.com/0c1d266856c65b2c4238cd7dae00ebcd4cc7cb01/components/browser_sync/profile_sync_service.h
[modify] https://crrev.com/0c1d266856c65b2c4238cd7dae00ebcd4cc7cb01/components/browser_sync/profile_sync_service_mock.h

Let's revisit the UMA data when this hits stable

Thanks Patrick! Can you point to the specific histograms you think will be interesting to follow along?

Sync.InitialState, specifically the "Must confirm sync settings" state:
https://uma.googleplex.com/p/chrome/timeline_v2/?sid=f42bf515757e17826b5cfe270a73cc04

So far there's a small but noticeable drop in the number of users in the "Must confirm sync settings" state: https://uma.googleplex.com/p/chrome/timeline_v2/?sid=b5a8e108819bd7dec395067dc07d3d78

Didn't this land in 61?

Woops, you're right. That probably explains why the difference is small; the drop is likely just a difference in user composition. Or just noise. 

Yeah probably just due to beginning-of-milestone effects :) Let's take a look again when 61 rolls out.

Can you take a screenshot of what the new error UI looks like, for my own edification?

Added screenshots of the error ui as attachments

Deleted: avatar_error_1.png 56.0 KB

	avatar_error_1.png 56.0 KB View Download

Deleted: avatar_error_2.png 77.2 KB

	avatar_error_2.png 77.2 KB View Download

Deleted: avatar_error_3.png 69.5 KB

	avatar_error_3.png 69.5 KB View Download

Nice! Looks great. I'll check back in when 61 rolls out

See https://uma.googleplex.com/p/chrome/timeline_v2/?sid=7033be24c40f54935af450a166312441 for comparison of M60 to M61; the proportion of users in this error state is trending down significantly. 

Exciting! Thanks for the link Patrick. I'll monitor this over the next week or two as well as 61 rolls out further.

Did the change you made affect only desktop? If so, we should probably limit this analysis to just desktop OSes, right?

Right, this is a desktop-only UI. Android's sync confirmation(and error notification) works differently. The updated link shows a similar drop: https://uma.googleplex.com/p/chrome/timeline_v2/?sid=3ad65bb1b267e0c30342b9ed2f9aa80e 

Nice! This looks good to me, Patrick. Any other follow-up work here, or should we mark this as fixed?

Issue 611907 has been merged into this issue.