Investigate improved heap ASLR on Windows >= 8.1 |
|||
Issue descriptionbase/allocator/partition_allocator/address_space_randomization.cc says: - // 64-bit Windows has a bizarrely small 8TB user address space. - // Allocates in the 1-5TB region. - // TODO(cevans): I think Win 8.1 has 47-bits like Linux. + // 64-bit Windows has a bizarrely small 8TB user address space. Allocates in + // the 1-5TB region. TODO(palmer): See if Windows >= 8.1 has the full 47 bits, + // and use it if so. See if cevans was right, and improve the randomness if so.
,
Mar 28 2017
Thanks for reminding me. :) https://codereview.chromium.org/2780733002
,
Mar 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d406a54b2a677132a79f9da2c9624bb8c3ab07c8 commit d406a54b2a677132a79f9da2c9624bb8c3ab07c8 Author: palmer <palmer@chromium.org> Date: Tue Mar 28 20:26:19 2017 Use the full 47 bits of address space on Windows >= 8.1. Improves our ASLR on systems that support it. BUG= 672219 Review-Url: https://codereview.chromium.org/2780733002 Cr-Commit-Position: refs/heads/master@{#460204} [modify] https://crrev.com/d406a54b2a677132a79f9da2c9624bb8c3ab07c8/base/allocator/partition_allocator/address_space_randomization.cc
,
Mar 28 2017
,
Apr 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/136d94d61e825232fccd78145cd94f86f5c20aae commit 136d94d61e825232fccd78145cd94f86f5c20aae Author: palmer <palmer@chromium.org> Date: Tue Apr 11 21:28:55 2017 Don't depend on base::win in PartitionAlloc. It seemed like a good idea, but we want to be able to use PA in other projects (like PDFium) without pulling in even more base dependencies. Instead, use the plain Windows API for getting the version. BUG= 672219 , 695274 TBR=haraken Review-Url: https://codereview.chromium.org/2811903003 Cr-Commit-Position: refs/heads/master@{#463776} [modify] https://crrev.com/136d94d61e825232fccd78145cd94f86f5c20aae/base/allocator/partition_allocator/address_space_randomization.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by alex.sm...@warpsharp.info
, Mar 22 2017