New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672217 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 646162
Owner: ----
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocked on:
issue 646162



Sign in to add a comment

Would be nice to have the gpu.fyi console grouped by platform (Win/Mac/Linux/etc)

Project Member Reported by jmad...@chromium.org, Dec 7 2016

Issue description

Look for example at the perf waterfall console:

https://build.chromium.org/p/chromium.perf/console

Here we see separation by OS. 

Looking at GPU.FYI:

https://build.chromium.org/p/chromium.gpu.fyi/console

This is a bit daunting to find the bot you are interested in.

Would be nice if we could add this clustering. Ken do you know where this code lives?
 

Comment 1 by kbr@chromium.org, Dec 7 2016

Components: Infra>Client
Sorry, I don't know this. It must be in the tools/build workspace and probably under master.chromium.perf. Ask the Infra team?

Cc: mar...@chromium.org
Marc-Antoine, do you know how we could add this ui tweak to the GPU.FYI bots?
Cc: hinoka@chromium.org
Milo?
Cc: dtu@chromium.org
Components: Internals>GPU>ANGLE
Status: Available (was: Unconfirmed)
Dave do you know how the chromium.perf waterfall groups bots by category?

https://build.chromium.org/p/chromium.perf/console

Comment 5 by kbr@chromium.org, Dec 21 2016

Not to answer for Dave, but digging in to this a bit, the chromium.android waterfall does this too:

https://build.chromium.org/p/chromium.android/console

The trick seems to be to specify a "category" for each bot.

The GPU waterfalls currently have their own custom setup logic, and I don't think we should hack it to add this (recipe_master_helper.py would have to be hacked to pass it through). Rather, I think we should migrate these waterfalls to the builders.pyl syntax, as in:

tools/build/masters/master.chromium.android/builders.pyl

and then pick up its ability to specify the category.

Oh, OK. Thanks Ken. Do you have a crbug open for that, that I can block this on? Will be happy to add category support once that's done, but it sounds like that might be a longer-term goal.

Comment 7 by kbr@chromium.org, Dec 21 2016

Blockedon: 646162
Yes, found it.

Thanks!

Comment 9 by kbr@chromium.org, Jan 19 2017

Mergedinto: 646162
Status: Duplicate (was: Available)
This was done as part of the work for  Issue 646162 . Duplicating this into the other bug.

Sign in to add a comment