New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672201 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
OOO until Feb 4th
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

MobileStartup.ToolbarFirstDrawTime.* histograms have names that are not in histograms.xml

Project Member Reported by asvitk...@chromium.org, Dec 7 2016

Issue description

MobileStartup.ToolbarFirstDrawTime.* histograms have names that are not in histograms.xml.

For example, while testing, I noticed a MobileStartup.ToolbarFirstDrawTime.ChromeActivity$7 on my local device. Seems the code uses the class name of a class and it's being generated in an inner subclass of ChromeActivity?


 
Cc: yus...@chromium.org
Owner: wnwen@chromium.org
Looks like it might have been caused by this CL which refactored the code: https://codereview.chromium.org/2207933002

Comment 2 by wnwen@chromium.org, Dec 7 2016

Hmm, yes, the call is now wrapped in a deferred task. I can do getClass().getSimpleName() outside the task.
Right, that should fix it. Probably worth evaluating if it's useful to keep the metric given no one noticed since it was broken 4 months ago?

Comment 4 by wnwen@chromium.org, Dec 7 2016

Haha, good point. I'll send a CL to remove it and get the owner of the metric to review it.

Comment 5 by wnwen@chromium.org, Dec 7 2016

@yusufo - are the MobileStartup.* metrics still used/relevant or can they be safely removed?

Comment 6 by wnwen@chromium.org, Dec 14 2016

Cc: mariakho...@chromium.org
+mariakhomenko@ for whether the MobileStartup.ToolbarInflationTime.* MobileStartup.ToolbarFirstDrawTime.* and MobileStartup.ToolbarFirstFocusTime.* metrics are still used/relevant.

Thanks. I can delete them in a CL like this if they are not. https://codereview.chromium.org/2574003002/
I've actually used those metrics recently. It's actually hard to detect that things are broken unless you are restricting your view by milestone. Since we have lots of users on M53-, the metrics look quite reasonable. I would prefer these were fixed rather than removed.

Comment 9 by wnwen@chromium.org, Dec 15 2016

Labels: -Pri-3 Pri-1
Sounds good, I'll fix these and merge these fixes.

Just wanted to make sure they are still useful. Thanks Maria.
Project Member

Comment 10 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f87b825a0e3cd48bf8b5f469bf25b423f903b71

commit 8f87b825a0e3cd48bf8b5f469bf25b423f903b71
Author: wnwen <wnwen@chromium.org>
Date: Thu Dec 15 17:59:37 2016

Android: Fix wrong UMA histogram name

Caused by caller switching to anonymous functions for deferred startup.

BUG= 672201 

Review-Url: https://codereview.chromium.org/2576213005
Cr-Commit-Position: refs/heads/master@{#438871}

[modify] https://crrev.com/8f87b825a0e3cd48bf8b5f469bf25b423f903b71/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Comment 11 by wnwen@chromium.org, Dec 15 2016

Labels: Merge-Request-56
Merge request for #10, very minor fix to UMA.

Comment 12 by dimu@chromium.org, Dec 15 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 15 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b0d7137ef64297684ac26dac1f0e1b7a89562d4

commit 5b0d7137ef64297684ac26dac1f0e1b7a89562d4
Author: Peter Wen <wnwen@google.com>
Date: Thu Dec 15 18:38:02 2016

Android: Fix wrong UMA histogram name

Caused by caller switching to anonymous functions for deferred startup.

BUG= 672201 

Review-Url: https://codereview.chromium.org/2576213005
Cr-Commit-Position: refs/heads/master@{#438871}
(cherry picked from commit 8f87b825a0e3cd48bf8b5f469bf25b423f903b71)

Review-Url: https://codereview.chromium.org/2576283003 .
Cr-Commit-Position: refs/branch-heads/2924@{#512}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/5b0d7137ef64297684ac26dac1f0e1b7a89562d4/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Comment 14 by wnwen@chromium.org, Dec 15 2016

Status: Fixed (was: Assigned)

Sign in to add a comment