New issue
Advanced search Search tips

Issue 672192 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
eroman@chromium.org
mmenke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

net/spdy/spdy_alt_svc_wire_format.cc reinvents the wheel (multiple times)

Project Member Reported by mmenke@chromium.org, Dec 7 2016 
net/spdy/spdy_alt_svc_wire_format.cc has code to parse integer strings, and code to unescape strings.  We already have both in net/.  We should try an reuse the code to do these things, to reduce code and reduce attack/bug surface.

Comment 1 by b...@chromium.org, Dec 7 2016 

In general, I strongly agree with the premise of this issue.

Note that SpdyAltSvcWireFormat is shared with server code, so the amount of library functions we can use is limited.

Maybe C++11's <regex> library, which is currently banned in Chromium, might also be helpful here, once allowed.

Comment 2 by mmenke@chromium.org, Dec 7 2016 

It seems like it can depend on base/.  I guess it's limited to not depending on i18n methods?
►

Sign in to add a comment