New issue
Advanced search Search tips

Issue 672191 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 672152



Sign in to add a comment

[WebAudio:audit] should().beCloseTo() is printing incorrect messages.

Project Member Reported by hongchan@chromium.org, Dec 7 2016

Issue description

Try the following assertion:

should(0).beCloseTo(0, {threshold:0})

The printed message is a generic string with the template tags in it.
 

Comment 1 by rtoy@chromium.org, Dec 7 2016

In addition, if you change the test from < to <= (which is what it should be), the test prints out something like

"is ${expected} within an error of 0"
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0426811873244e80feac8e0de79e1eb0633cb21

commit f0426811873244e80feac8e0de79e1eb0633cb21
Author: hongchan <hongchan@chromium.org>
Date: Thu Dec 08 20:04:11 2016

Fixing audit.js: should().beCloseTo() and task.run('taskName')

This CL fixes two trivial bugs in audit.js:
The  issue 672203 : task.run('taskName')
The  issue 672191 : should().beCloseTo()

BUG= 672203 ,  672191 

Review-Url: https://codereview.chromium.org/2561573006
Cr-Commit-Position: refs/heads/master@{#437312}

[modify] https://crrev.com/f0426811873244e80feac8e0de79e1eb0633cb21/third_party/WebKit/LayoutTests/webaudio/resources/audit.js
[modify] https://crrev.com/f0426811873244e80feac8e0de79e1eb0633cb21/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html

Status: Verified (was: Assigned)

Sign in to add a comment