The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07380defeda24d05120554d63fa211b9a13d2628

commit 07380defeda24d05120554d63fa211b9a13d2628
Author: afakhry <afakhry@chromium.org>
Date: Thu Dec 08 01:37:03 2016

Include full du dump in feedback reports

R=steel@chromium.org
BUG= 672188 
TEST=Start the feedback app on chrome os, the system information should contain an
entry "system_files" containing info about all recursive directories in the system.

Review-Url: https://codereview.chromium.org/2556783006
Cr-Commit-Position: refs/heads/master@{#437118}

[modify] https://crrev.com/07380defeda24d05120554d63fa211b9a13d2628/chrome/browser/chromeos/system_logs/command_line_log_source.cc

Your change meets the bar and is auto-approved for M56 (branch: 2924)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2af22def848bfe321bdbb20cfc4b1b4c27994d11

commit 2af22def848bfe321bdbb20cfc4b1b4c27994d11
Author: Ahmed Fakhry <afakhry@google.com>
Date: Fri Dec 09 18:37:09 2016

[Merge into M56] Include full du dump in feedback reports

TBR=steel@chromium.org
BUG= 672188 
TEST=Start the feedback app on chrome os, the system information should contain an
entry "system_files" containing info about all recursive directories in the system.

Review-Url: https://codereview.chromium.org/2556783006
Cr-Commit-Position: refs/heads/master@{#437118}
(cherry picked from commit 07380defeda24d05120554d63fa211b9a13d2628)

Review-Url: https://codereview.chromium.org/2569453002 .
Cr-Commit-Position: refs/branch-heads/2924@{#432}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/2af22def848bfe321bdbb20cfc4b1b4c27994d11/chrome/browser/chromeos/system_logs/command_line_log_source.cc

Can you turn this off if you no longer need it, or make it only enabled on the device that you need it for? At the very least, can you target it to whatever area of the stateful partition you care about instead of logging all of the read-only files as well?

I just noticed this in a user feedback report. It's very noisy and probably quite slow. Adding Kay per earlier discussion about feedback reduction.

I remember this was added to diagnose a particular bug. we may not need this anymore. +rkc for context.

It is 'probably' still information that would be good to have in feedback reports anyway.

We are currently collecting a lot of information in feedback. And we are adding more every couple months. This is initiated by Chrome Privacy so we trim off information we are not using anymore. The principle is not to collect data that 'may' be useful some day. If this is collected specifically for a bug, and the bug is fixed, we should remove it.

I can understand how disk usage information from the stateful partition could be useful when debugging, but how is usage information from the read-only partition useful?

The bug only caused us to realize the lack of this piece of data. We need to be able to see disk usage on the stateful, without which we are blind to any issues that exist around running out of disk space.

As Dan pointed out, we probably should restrict this to disk usage only on the stateful but we do need this information for stateful.

Filed  issue 712942  to track not including useless information.