New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672176 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Out-of-memory in pdf_codec_jbig2_fuzzer

Project Member Reported by ClusterFuzz, Dec 7 2016

Issue description

Cc: msrchandra@chromium.org
Labels: Test-Predator-Wrong
Owner: kcwu@chromium.org
Status: Assigned (was: Untriaged)
Find it did not find provide any possible suspect.
Assigning to the concern owner from the regressed range -
https://chromium.googlesource.com/chromium/src/+log/b9014646db766be89300d38806c340e4b2772e7a..721ba2cac4a5b76803d9488a831a2bd44867ed81?pretty=fuller

Suspecting the Commit# 
https://chromium.googlesource.com/chromium/src/+/1deca3a90d6421a377d718d09479645af0d9fe53

@kcwu -- Could you please look into the issue, kindly re-assign if this is not related to your change.
Thank You.

Comment 2 by kcwu@chromium.org, Feb 22 2017

Cc: kcwu@chromium.org
Owner: dsinclair@chromium.org
I don't have free time to help. Reassigned.
Status: Started (was: Assigned)
https://pdfium-review.googlesource.com/c/3231/
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 27 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/96169fc007f271412ffa7bf2ebd3cf3fc04f71a5

commit 96169fc007f271412ffa7bf2ebd3cf3fc04f71a5
Author: Dan Sinclair <dsinclair@chromium.org>
Date: Mon Mar 27 18:45:54 2017

Verify available bits in bit stream

The methods to read n bits from the huffman stream are not correctly
checking that the bits are available. This means, we'll end up reading
0 bits due to the checks below and pretend like the read worked.

This Cl adds the check that we are not at the end of the bit buffer
before attempting the bit read.

Bug:  chromium:672176 
Change-Id: I206f2d54da31c344cf649ca024644d1cce762fe7
Reviewed-on: https://pdfium-review.googlesource.com/3231
Reviewed-by: Nicolás Peña <npm@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>

[modify] https://crrev.com/96169fc007f271412ffa7bf2ebd3cf3fc04f71a5/core/fxcodec/jbig2/JBig2_BitStream.cpp

Status: Fixed (was: Started)
Project Member

Comment 6 by ClusterFuzz, Mar 28 2017

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/0eb74769c9efbcb94e57f160882ce3309684b2f9

commit 0eb74769c9efbcb94e57f160882ce3309684b2f9
Author: Dan Sinclair <dsinclair@chromium.org>
Date: Tue Mar 28 16:50:45 2017

Add JBig2_BitStream ReadNBits unittests

Add test for reading past end of buffer and successful read of bits.

Bug:  chromium:672176 
Change-Id: Ibe2d818185cdb2260011d3fc8cad94ebb16984b7
Reviewed-on: https://pdfium-review.googlesource.com/3233
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Commit-Queue: dsinclair <dsinclair@chromium.org>

[modify] https://crrev.com/0eb74769c9efbcb94e57f160882ce3309684b2f9/BUILD.gn
[add] https://crrev.com/0eb74769c9efbcb94e57f160882ce3309684b2f9/core/fxcodec/jbig2/JBig2_BitStream_unittest.cpp

Components: Internals>Plugins>PDF

Sign in to add a comment