[PasswordManager Signin Promo] Add histograms to split clicks on "Sign in" vs. "No thanks" per impression |
|||||||
Issue description(From offline discussion with Sabine today) Right now, we have three histograms: PasswordManager.SigninPromo - gives total splits between dismissed, no thanks, and sign in across all impressions PasswordManager.SigninPromoCountTilClick - gives per-impression click data for no thanks + sign in *combined* PasswordManager.SigninPromoDismissalCount - gives per-impression dismissal data This allows us to get per-impression CTR (PasswordManager.SigninPromoCountTilClick/PasswordManager.SigninPromoDismissalCount), counting clicks for *both* no thanks and sign in. However, we can't breakout the CTR for each button separately per-impression (e.g. to say "CTR for "Sign in" was x_3 on impression 3, whereas CTR for "No thanks" was y_3 on impression 3"). This isn't blocking our rollout (we're going to go back to launch review with just the combined CTR), but it will be useful data to have for the future. We need two new histograms: PasswordManager.SigninPromoSignInCount - per-impression count for clicks on "Sign in" PasswordManager.SigninPromoNoThanksCount - per-impression count for clicks on "No thanks"
,
Dec 9 2016
No, we just want to split out the clicks for "Sign in" and "No thanks" into their own histograms. Right now we have a single histogram for clicks (PasswordManager.SignInPromoCountTilClick). This gives us overall CTR for each impression, but doesn't allow us to break down the CTR between "Sign in" and "No thanks." Does that make sense? Sabine can probably explain it better in person, too :)
,
Dec 14 2016
Hi Vasilii, just a friendly ping. Does the request make sense? Sorry if it's unclear, let me know if you have any more questions!
,
Dec 15 2016
Yes, the request makes sense.
,
Dec 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6fa168c33de7fa32366602594cc4ccd313874650 commit 6fa168c33de7fa32366602594cc4ccd313874650 Author: vasilii <vasilii@chromium.org> Date: Fri Dec 16 09:24:56 2016 Add PasswordManager.SignInPromoCountTil* histograms for the sign-in promo in the password bubble. The two histograms replace PasswordManager.SignInPromoCountTilClick. It used to record the same number for both buttons. BUG= 672163 Review-Url: https://codereview.chromium.org/2578923003 Cr-Commit-Position: refs/heads/master@{#439075} [modify] https://crrev.com/6fa168c33de7fa32366602594cc4ccd313874650/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc [modify] https://crrev.com/6fa168c33de7fa32366602594cc4ccd313874650/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc [modify] https://crrev.com/6fa168c33de7fa32366602594cc4ccd313874650/components/password_manager/core/browser/password_manager_metrics_util.cc [modify] https://crrev.com/6fa168c33de7fa32366602594cc4ccd313874650/components/password_manager/core/browser/password_manager_metrics_util.h [modify] https://crrev.com/6fa168c33de7fa32366602594cc4ccd313874650/tools/metrics/histograms/histograms.xml
,
Dec 16 2016
,
Dec 16 2016
,
Dec 16 2016
Thanks Vasilii! Any chance we can merge this back to 56? Seems pretty safe, since 56 is just at the beginning of beta and these are just metrics changes.
,
Dec 19 2016
We'd like to merge r439075 back. It just adds a histogram.
,
Dec 19 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00221931c858bb0a9af2294da8bba3d2c1e5b87e commit 00221931c858bb0a9af2294da8bba3d2c1e5b87e Author: Vasilii Sukhanov <vasilii@chromium.org> Date: Mon Dec 19 11:48:57 2016 Add PasswordManager.SignInPromoCountTil* histograms for the sign-in promo in the password bubble. The two histograms replace PasswordManager.SignInPromoCountTilClick. It used to record the same number for both buttons. BUG= 672163 Review-Url: https://codereview.chromium.org/2578923003 Cr-Commit-Position: refs/heads/master@{#439075} (cherry picked from commit 6fa168c33de7fa32366602594cc4ccd313874650) Review-Url: https://codereview.chromium.org/2586813003 . Cr-Commit-Position: refs/branch-heads/2924@{#545} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/00221931c858bb0a9af2294da8bba3d2c1e5b87e/chrome/browser/ui/passwords/manage_passwords_bubble_model.cc [modify] https://crrev.com/00221931c858bb0a9af2294da8bba3d2c1e5b87e/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc [modify] https://crrev.com/00221931c858bb0a9af2294da8bba3d2c1e5b87e/components/password_manager/core/browser/password_manager_metrics_util.cc [modify] https://crrev.com/00221931c858bb0a9af2294da8bba3d2c1e5b87e/components/password_manager/core/browser/password_manager_metrics_util.h [modify] https://crrev.com/00221931c858bb0a9af2294da8bba3d2c1e5b87e/tools/metrics/histograms/histograms.xml
,
Dec 19 2016
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by vasi...@chromium.org
, Dec 9 2016