New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 672155 link

Starred by 2 users
Status: Assigned
Owner:
█ sbirch@chromium.org
Last visit 21 days ago
Cc:
yus...@chromium.org
tedc...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

Supporting NEW_TASK for Custom Tabs

Project Member Reported by tedc...@chromium.org, Dec 7 2016 
With this change:
https://codereview.chromium.org/2556713003/

NEW_TASK will be better supported for Custom Tabs.  We should decide what exactly that means for external Custom Tab clients.

1.) Currently when a SeparateTaskCustomTabActivity is used (i.e. the activity type for NEW_TASK), we update the task description in Android recents to be based on the page title, favicon, theme color.  Should this apply for external clients?  Should we use the app icon from the original app?  The app name?  The color they provide?

2.) Do we need to do anything to limit the number of new tasks other apps can create?  Currently if a client sends a second VIEW intent (assuming the client did not use NEW_TASK), do we try to load the URL in the original CCT?  What is the behavior now?  Should we try to refocus the previous NEW_TASK created activity?  If we can't, do we now have two activities using the same session?

Maybe the only requirement is the sessions are different?  In general, this is the largest area for discussion and is more policy oriented.

Comment 1 by sbirch@chromium.org, Dec 12 2016 

Is there anyone setting NEW_TASK already? (IIRC that is the case for other external intents.) I would guess that it's not set at least if you're using the SL, but I think we'd have to more conservative if some significant number of clients were setting it and expecting the current behavior.

Ian, you mentioned this one in the context of browser actions but I'm not sure I understand the connection?

Comment 2 by yus...@chromium.org, Dec 13 2016

Cc: rolfe@chromium.org
1) adding rolfe@ to answer this one. My personal preference would be to treat these similar to Herb tabs, as the client has shown interest to not be associated with them.

2) Currently if the client creates a session and then sends a second intent while a CCT is already live for that session, we reload the new url in the same tab without creating any new tabs or activities. So I think it would be OK to keep this behavior.

Comment 3 by rolfe@chromium.org, Dec 14 2016 

Per No. 1 - I'm unsure of the agreement we made with the app. If a CCT client app calls a web page, do they expect it to open a CCT no matter what? I could see someone using CCT in the app and being surprised NEW TASK opens differently than other links called and appears differently in Recents. They might have made that choice based on how the platform works rather than how they wanted their app to be interacted with. But if we were to clearly document in which regard a CCT opens and retains the app styling, then NEW TASK presumably should be an Herb.

Comment 4 by rolfe@chromium.org, Mar 29 2017

Components: UI>Browser>Mobile>CustomTabs

Comment 5 Deleted

Comment 6 by rolfe@chromium.org, Apr 5 2017

Cc: -chowse@chromium.org
If you still need design support here, start with chowse@.
►

Sign in to add a comment