New issue
Advanced search Search tips

Issue 672150 link

Starred by 1 user
Status: Fixed
Owner:
sky@chromium.org
Closed: Aug 14
Cc:
sadrul@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Handle WindowTreeHostMus root window's visibility consistently

Project Member Reported by mfomitchev@chromium.org, Dec 7 2016 
1. Mus assumes that all windows, including root window are not visible by default: 
https://cs.chromium.org/chromium/src/ui/aura/mus/window_tree_host_mus.cc?sq=package:chromium&dr=CSs&rcl=1481055549&l=83
Here it associates the visibility of the root Mus window with the visibility of the compositor (I guess based on the semantics of WTH::Show())

2. WTH::InitHost calls show on its root Window. This presents a problem in the context of Mus: making the WTH's root window visible makes the corresponding Mus window visible, which, considering (1), is wrong, because WTH can be initialized by the client at any time as part of setup - it's not really semantically associated with the visibility of the corresponding Mus window. 

The most natural way to fix this would seem to be to call window()->Show() in WTH::Show instead of in WTH::InitHost. If that proves hard because of legacy Aura code, we can instead do it only for WTHMus.

Comment 1 by sky@chromium.org, Dec 13 2016

Cc: -sky@chromium.org mfomitchev@chromium.org
Owner: sky@chromium.org
Status: Started (was: Assigned)
I'm hitting this when trying to convert chrome to use aura, so I'm going to take this on.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/746d0103f209a2b2bf1765d3ac3ec365b99e32d5

commit 746d0103f209a2b2bf1765d3ac3ec365b99e32d5
Author: sky <sky@chromium.org>
Date: Wed Dec 14 00:36:56 2016

Makes WindowTreeHost::InitHost() not Show the window

Users of WindowTreeHost may want to show it at different times, and
should be able to do that.

BUG= 672150 
TEST=covered by tests
R=ben@chromium.org, sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2567293004
Cr-Commit-Position: refs/heads/master@{#438363}

[modify] https://crrev.com/746d0103f209a2b2bf1765d3ac3ec365b99e32d5/ash/display/mirror_window_controller.cc
[modify] https://crrev.com/746d0103f209a2b2bf1765d3ac3ec365b99e32d5/ash/display/window_tree_host_manager.cc
[modify] https://crrev.com/746d0103f209a2b2bf1765d3ac3ec365b99e32d5/ash/host/ash_window_tree_host_x11_unittest.cc
[modify] https://crrev.com/746d0103f209a2b2bf1765d3ac3ec365b99e32d5/blimp/engine/session/blimp_engine_session.cc
[modify] https://crrev.com/746d0103f209a2b2bf1765d3ac3ec365b99e32d5/chromecast/browser/cast_content_window.cc
[modify] https://crrev.com/746d0103f209a2b2bf1765d3ac3ec365b99e32d5/content/shell/browser/shell_platform_data_aura.cc
[modify] https://crrev.com/746d0103f209a2b2bf1765d3ac3ec365b99e32d5/extensions/shell/browser/shell_screen.cc
[modify] https://crrev.com/746d0103f209a2b2bf1765d3ac3ec365b99e32d5/headless/lib/browser/headless_browser_impl.cc
[modify] https://crrev.com/746d0103f209a2b2bf1765d3ac3ec365b99e32d5/headless/lib/browser/headless_screen.cc
[modify] https://crrev.com/746d0103f209a2b2bf1765d3ac3ec365b99e32d5/mash/simple_wm/simple_wm.cc
[modify] https://crrev.com/746d0103f209a2b2bf1765d3ac3ec365b99e32d5/services/ui/ws/window_manager_client_unittest.cc
[modify] https://crrev.com/746d0103f209a2b2bf1765d3ac3ec365b99e32d5/ui/aura/mus/window_tree_client_unittest.cc
[modify] https://crrev.com/746d0103f209a2b2bf1765d3ac3ec365b99e32d5/ui/aura/mus/window_tree_host_mus.cc
[modify] https://crrev.com/746d0103f209a2b2bf1765d3ac3ec365b99e32d5/ui/aura/mus/window_tree_host_mus.h
[modify] https://crrev.com/746d0103f209a2b2bf1765d3ac3ec365b99e32d5/ui/aura/test/test_screen.cc
[modify] https://crrev.com/746d0103f209a2b2bf1765d3ac3ec365b99e32d5/ui/aura/window_event_dispatcher_unittest.cc
[modify] https://crrev.com/746d0103f209a2b2bf1765d3ac3ec365b99e32d5/ui/aura/window_tree_host.cc
[modify] https://crrev.com/746d0103f209a2b2bf1765d3ac3ec365b99e32d5/ui/views/mus/native_widget_mus.cc
[modify] https://crrev.com/746d0103f209a2b2bf1765d3ac3ec365b99e32d5/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc

Comment 3 by mfomitchev@chromium.org, Nov 21 2017

Cc: -mfomitchev@chromium.org

Comment 4 by jamescook@chromium.org, Apr 24 2018

Components: Internals>Services>WindowService Internals>Aura
Labels: -Proj-Mustash-Aura Proj-Mustash
Migrating from Proj-Mustash-Aura to components Internals>Aura

Comment 5 by jamescook@chromium.org, Aug 14

Labels: -Proj-Mustash Proj-Mash-SingleProcess
sky, is this still relevant?

Comment 6 by sky@chromium.org, Aug 14

Status: Fixed (was: Started)
I believe this is fixed now.
►

Sign in to add a comment