New issue
Advanced search Search tips

Issue 672149 link

Starred by 1 user
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Removing box shadow

Project Member Reported by smcgruer@chromium.org, Dec 7 2016 
Chrome Version: 57.0.2945.0 (64-bit) (Debug build)
OS: Linux

What steps will reproduce the problem?
(1) Open the page http://jsbin.com/keridum/2/edit?html,css,js,output
(2) Wait 3 seconds for the box shadow to be removed

What is the expected result?

The box shadow should disappear, and nothing else.

What happens instead?

When the box shadow disappears, the orange rectangle also turns black (see screenshot attached).


This is a regression; it does not happen on M55 Linux.

Note: The jsbin is likely not a minimal reproduction, but it's quite small. Removing the scrollbars (but leaving will-change) gets rid of the bug, so I suspect something scroll layer related?

Comment 1 by smcgruer@chromium.org, Dec 7 2016

omvx8zrUqMR.png
138 KB View Download

Comment 2 by chrishtr@chromium.org, Dec 7 2016 

I can reproduce at ToT but not dev on Linux. Bisecting.

Comment 3 by chrishtr@chromium.org, Dec 7 2016

Labels: -Pri-3 ReleaseBlock-Stable M-57 Pri-1
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Untriaged)
Bisect result:

https://chromium.googlesource.com/chromium/src/+log/7d4e3493fadf1980263bdd7d2072f05fdf0fe215..a2907993ffbc7f8e21b2dce12c2ff5d541afca7e

My guess is this broke it:

https://chromium.googlesource.com/chromium/src/+/a2907993ffbc7f8e21b2dce12c2ff5d541afca7e

Comment 4 by wangxianzhu@chromium.org, Dec 7 2016

Labels: -Type-Bug Type-Bug-Regression
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31210a50c0fe3f11dc838209f06f7d84579dc8f0

commit 31210a50c0fe3f11dc838209f06f7d84579dc8f0
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Thu Dec 08 18:52:08 2016

Fix issue when background changes painting target layer

BUG= 672149 
TEST=paint/invalidation/compositing/stop-painting-onto-scrolling-contents.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2559863002
Cr-Commit-Position: refs/heads/master@{#437296}

[modify] https://crrev.com/31210a50c0fe3f11dc838209f06f7d84579dc8f0/third_party/WebKit/LayoutTests/compositing/squashing/squash-above-fixed-1-expected.txt
[modify] https://crrev.com/31210a50c0fe3f11dc838209f06f7d84579dc8f0/third_party/WebKit/LayoutTests/paint/invalidation/compositing/invalidate-when-leaving-squashed-layer-expected.txt
[modify] https://crrev.com/31210a50c0fe3f11dc838209f06f7d84579dc8f0/third_party/WebKit/LayoutTests/paint/invalidation/compositing/should-invoke-deferred-compositing-expected.txt
[add] https://crrev.com/31210a50c0fe3f11dc838209f06f7d84579dc8f0/third_party/WebKit/LayoutTests/paint/invalidation/compositing/stop-painting-onto-scrolling-contents-expected.html
[add] https://crrev.com/31210a50c0fe3f11dc838209f06f7d84579dc8f0/third_party/WebKit/LayoutTests/paint/invalidation/compositing/stop-painting-onto-scrolling-contents.html
[modify] https://crrev.com/31210a50c0fe3f11dc838209f06f7d84579dc8f0/third_party/WebKit/LayoutTests/paint/invalidation/destroy-composited-scrollbar-expected.txt
[modify] https://crrev.com/31210a50c0fe3f11dc838209f06f7d84579dc8f0/third_party/WebKit/LayoutTests/paint/invalidation/filter-invalidation-with-composited-container-change-expected.txt
[modify] https://crrev.com/31210a50c0fe3f11dc838209f06f7d84579dc8f0/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Comment 6 by kkaluri@chromium.org, Dec 9 2016

Labels: TE-Verified-57.0.2946.0 TE-Verified-M57
Verified the issue on ubuntu 14.04 using chrome version #57.0.2946.0 as per comment #0

Observed that when box shadow disappears orange color not changing to black.

Attaching screen cast for reference.

Hence, adding the verified labels.

Thanks...!!
Issue 672149.mp4
1.4 MB View Download

Comment 7 by wangxianzhu@chromium.org, Dec 9 2016

Labels: -M-57 M-56 Merge-Request-56

Comment 8 by dimu@chromium.org, Dec 9 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 9 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01e58a4f9325929922a0a847c71a5828caa86d3e

commit 01e58a4f9325929922a0a847c71a5828caa86d3e
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Fri Dec 09 19:48:28 2016

Fix issue when background changes painting target layer

BUG= 672149 
TEST=paint/invalidation/compositing/stop-painting-onto-scrolling-contents.html
NOTRY=true
NOPRESUBMIT=true
TBR=wangxianzhu@chromium.org

Review-Url: https://codereview.chromium.org/2559863002
Cr-Commit-Position: refs/heads/master@{#437296}
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2559183005 .
Cr-Commit-Position: refs/branch-heads/2924@{#438}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/01e58a4f9325929922a0a847c71a5828caa86d3e/third_party/WebKit/LayoutTests/compositing/squashing/squash-above-fixed-1-expected.txt
[modify] https://crrev.com/01e58a4f9325929922a0a847c71a5828caa86d3e/third_party/WebKit/LayoutTests/paint/invalidation/compositing/invalidate-when-leaving-squashed-layer-expected.txt
[modify] https://crrev.com/01e58a4f9325929922a0a847c71a5828caa86d3e/third_party/WebKit/LayoutTests/paint/invalidation/compositing/should-invoke-deferred-compositing-expected.txt
[add] https://crrev.com/01e58a4f9325929922a0a847c71a5828caa86d3e/third_party/WebKit/LayoutTests/paint/invalidation/compositing/stop-painting-onto-scrolling-contents-expected.html
[add] https://crrev.com/01e58a4f9325929922a0a847c71a5828caa86d3e/third_party/WebKit/LayoutTests/paint/invalidation/compositing/stop-painting-onto-scrolling-contents.html
[modify] https://crrev.com/01e58a4f9325929922a0a847c71a5828caa86d3e/third_party/WebKit/LayoutTests/paint/invalidation/destroy-composited-scrollbar-expected.txt
[modify] https://crrev.com/01e58a4f9325929922a0a847c71a5828caa86d3e/third_party/WebKit/LayoutTests/paint/invalidation/filter-invalidation-with-composited-container-change-expected.txt
[modify] https://crrev.com/01e58a4f9325929922a0a847c71a5828caa86d3e/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Comment 10 by wangxianzhu@chromium.org, Dec 9 2016

Status: Fixed (was: Assigned)

Comment 11 by kavvaru@chromium.org, Dec 14 2016

Labels: TE-Verified-56.0.2924.28 TE-Verified-M56
Tested the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.12.1 using chrome version 56.0.2924.28.Observed that box shadow disappeared and orange color not changed to blank.

Adding TE-Verified labels.

Thanks,
►

Sign in to add a comment