Default Selection on OOBE should be on Agree Button |
|||||||||
Issue descriptionChrome 56.0.2924.18/9000.18.0 Please specify Cr-* of the system to which this bug/feature applies (add the label below). Launch bug:- https://bugs.chromium.org/p/chromium/issues/detail?id=651144 What steps will reproduce the problem? (1)Enable --enable-arc-oobe-optin (2) Go through OOBE and login user (3)Check for default selection on Agree and Skip button What is the expected result? Selection should be on Agree button What happens instead? Selection is on Skip button
,
Dec 8 2016
Hi Hiro, Could you please confirm what we want to have as a focus. Currently focus is on Skip button and I feel that this is not the bast case. Please consider following cases. At the beginning we have only 'Skip' button enabled. We might have focus set by default (as currently) or not. Once ToS is loaded we enable 'Agree' button. Do we need to move focus to it automatically? WDYT
,
Dec 8 2016
While the content loads let's gray out the buttons. Once the content is there let's focus on Agree.
,
Dec 8 2016
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff1fb50a9ffa4b0461bc10db6bad8680ddce5f5b commit ff1fb50a9ffa4b0461bc10db6bad8680ddce5f5b Author: khmel <khmel@chromium.org> Date: Fri Dec 09 01:59:31 2016 arc: Change default button to 'Agree' for Arc OOBE OptIn page. There is new requirement for buttons in Arc OOBE OptIn page. Skip and Agree buttons must be grayed until ToS is loaded. Once ToS is loaded both are enabled and 'Agree' button has the focus. This also moves focus to 'Retry' button in case of ToS loading failure. TEST=Manually on device. BUG= 672145 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2565573002 Cr-Commit-Position: refs/heads/master@{#437427} [modify] https://crrev.com/ff1fb50a9ffa4b0461bc10db6bad8680ddce5f5b/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.js
,
Dec 13 2016
,
Dec 13 2016
,
Dec 13 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/be105c886ca713b4972aa3be59821b325882c3f8 commit be105c886ca713b4972aa3be59821b325882c3f8 Author: khmel <khmel@chromium.org> Date: Tue Dec 13 16:14:12 2016 [Merge-M56] arc: Change default button to 'Agree' for Arc OOBE OptIn page. There is new requirement for buttons in Arc OOBE OptIn page. Skip and Agree buttons must be grayed until ToS is loaded. Once ToS is loaded both are enabled and 'Agree' button has the focus. This also moves focus to 'Retry' button in case of ToS loading failure. TEST=Manually on device. BUG= 672145 TBR=xiyuan@chromium.org NOTRY=true NOPRESUBMIT=true CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2565573002 Cr-Commit-Position: refs/heads/master@{#437427} (cherry picked from commit ff1fb50a9ffa4b0461bc10db6bad8680ddce5f5b) Review-Url: https://codereview.chromium.org/2576513002 Cr-Commit-Position: refs/branch-heads/2924@{#473} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/be105c886ca713b4972aa3be59821b325882c3f8/chrome/browser/resources/chromeos/login/screen_arc_terms_of_service.js
,
Dec 13 2016
,
Dec 15 2016
Verified on 56.0.2924.28/9000.29.0 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by khmel@chromium.org
, Dec 7 2016