There is an "old" implementation in BaseScreen[1]. It would be nice to clean it up. 1: https://cs.chromium.org/chromium/src/chrome/browser/chromeos/login/screens/base_screen.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c64a96a44e5fcfdc8eb8b89cdd7e9d88e9dc8866 commit c64a96a44e5fcfdc8eb8b89cdd7e9d88e9dc8866 Author: jdufault <jdufault@chromium.org> Date: Wed Dec 07 18:42:49 2016 cros: Remove unused permanent screen concept from BaseScreen. BUG= 672142 Review-Url: https://codereview.chromium.org/2552883006 Cr-Commit-Position: refs/heads/master@{#437017} [modify] https://crrev.com/c64a96a44e5fcfdc8eb8b89cdd7e9d88e9dc8866/chrome/browser/chromeos/login/screens/base_screen.cc [modify] https://crrev.com/c64a96a44e5fcfdc8eb8b89cdd7e9d88e9dc8866/chrome/browser/chromeos/login/screens/base_screen.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad70479bba15d690c742174a93b8cad27b7bdd4f commit ad70479bba15d690c742174a93b8cad27b7bdd4f Author: jdufault <jdufault@chromium.org> Date: Wed Dec 07 19:16:32 2016 cros: Remove unused BaseScreen::PrepareToShow method BUG= 672142 Review-Url: https://codereview.chromium.org/2555783003 Cr-Commit-Position: refs/heads/master@{#437027} [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/enrollment/enrollment_screen.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/enrollment/enrollment_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/enrollment/enrollment_screen_actor.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/enrollment/mock_enrollment_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/app_launch_splash_screen_actor.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/arc_terms_of_service_screen.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/arc_terms_of_service_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/base_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/controller_pairing_screen.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/controller_pairing_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/device_disabled_screen.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/device_disabled_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/enable_debugging_screen.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/enable_debugging_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/enable_debugging_screen_actor.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/error_screen.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/error_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/eula_screen.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/eula_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/eula_view.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/hid_detection_screen.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/hid_detection_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/hid_detection_view.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/host_pairing_screen.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/host_pairing_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/kiosk_autolaunch_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/kiosk_enable_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/mock_enable_debugging_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/mock_error_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/mock_eula_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/mock_network_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/mock_update_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/mock_wrong_hwid_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/network_error_view.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/network_screen.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/network_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/network_view.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/reset_screen.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/reset_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/reset_view.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/terms_of_service_screen.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/terms_of_service_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/update_screen.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/update_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/update_view.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/user_image_screen.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/user_image_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/user_image_view.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/wrong_hwid_screen.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/wrong_hwid_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/screens/wrong_hwid_screen_actor.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/chromeos/login/ui/models/user_board_model.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/ui/webui/chromeos/login/enable_debugging_screen_handler.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/ui/webui/chromeos/login/enable_debugging_screen_handler.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/ui/webui/chromeos/login/error_screen_handler.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/ui/webui/chromeos/login/eula_screen_handler.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/ui/webui/chromeos/login/network_screen_handler.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/ui/webui/chromeos/login/reset_screen_handler.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/ui/webui/chromeos/login/update_screen_handler.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.h [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/ui/webui/chromeos/login/wrong_hwid_screen_handler.cc [modify] https://crrev.com/ad70479bba15d690c742174a93b8cad27b7bdd4f/chrome/browser/ui/webui/chromeos/login/wrong_hwid_screen_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/453b8869061af7fb18fc773dc4e585229bad6bb9 commit 453b8869061af7fb18fc773dc4e585229bad6bb9 Author: jdufault <jdufault@chromium.org> Date: Thu Jan 05 20:41:35 2017 cros: Refactor of BaseScreen::GetName to BaseScreen::screen_id. This removes the virtual method GetName in favor of just storing the name directly on the BaseScreen instance and returning it via a new method screen_id. Previously, all of the GetName overrides just returned a value directly. BUG= 672142 Review-Url: https://codereview.chromium.org/2549373005 Cr-Commit-Position: refs/heads/master@{#441742} [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.h [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/enrollment/enrollment_screen.cc [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/enrollment/enrollment_screen.h [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/arc_terms_of_service_screen.cc [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/arc_terms_of_service_screen.h [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/base_screen.cc [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/base_screen.h [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/controller_pairing_screen.cc [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/controller_pairing_screen.h [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/device_disabled_screen.cc [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/device_disabled_screen.h [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/enable_debugging_screen.cc [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/enable_debugging_screen.h [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/eula_model.cc [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/eula_model.h [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/hid_detection_model.cc [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/hid_detection_model.h [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/host_pairing_screen.cc [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/host_pairing_screen.h [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/kiosk_autolaunch_screen.cc [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/kiosk_autolaunch_screen.h [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/kiosk_enable_screen.cc [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/kiosk_enable_screen.h [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/mock_eula_screen.h [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/network_error_model.cc [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/network_error_model.h [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/network_model.cc [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/network_model.h [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/reset_model.cc [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/reset_model.h [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/terms_of_service_screen.cc [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/terms_of_service_screen.h [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/update_model.cc [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/update_model.h [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/update_screen_browsertest.cc [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/user_image_model.cc [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/user_image_model.h [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/wrong_hwid_screen.cc [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/screens/wrong_hwid_screen.h [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.h [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/ui/models/user_board_model.cc [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/ui/models/user_board_model.h [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/453b8869061af7fb18fc773dc4e585229bad6bb9/chrome/browser/chromeos/policy/device_local_account_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e47a74b21cb8b32e79eb8f41945afcc35d8a825 commit 9e47a74b21cb8b32e79eb8f41945afcc35d8a825 Author: jdufault <jdufault@chromium.org> Date: Mon Jan 09 20:46:56 2017 cros: Replace WizardController string constants with OobeScreen values. Constants which have changed: kArcTermsOfServiceScreenName from "arc_tos" to "arc-tos" kEnrollmentScreenName from "enroll" to "oauth-enrollment" kNetworkScreenName from "network" to "connect" kSupervisedUserCreationScreenName from "supervised-user-creation-flow" to "supervised-user-creation" kTermsOfServiceScreenName from "tos" to "terms-of-service" kUserImageScreenName from "image" to "user-image" BUG= 672142 Review-Url: https://codereview.chromium.org/2566443005 Cr-Commit-Position: refs/heads/master@{#442334} [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/enrollment/enrollment_screen.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/existing_user_controller.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/hid_detection_browsertest.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/kiosk_browsertest.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/login_browsertest.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/login_wizard.h [rename] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/oobe_screen.cc [rename] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/oobe_screen.h [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/reset_browsertest.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screen_manager.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screen_manager.h [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/arc_terms_of_service_screen.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/base_screen.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/base_screen.h [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/controller_pairing_screen.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/device_disabled_screen.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/enable_debugging_screen.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/error_screen.h [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/eula_model.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/hid_detection_model.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/hid_detection_screen_browsertest.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/host_pairing_screen.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/kiosk_autolaunch_screen.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/kiosk_enable_screen.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/network_error_model.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/network_error_model.h [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/network_error_view.h [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/network_model.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/network_screen.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/network_screen_browsertest.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/reset_model.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/terms_of_service_screen.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/update_model.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/update_screen.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/update_screen_browsertest.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/user_image_model.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/user_image_screen.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/screens/wrong_hwid_screen.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/session/chrome_session_manager.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/session/user_session_manager.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/session/user_session_manager.h [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/test/oobe_screen_waiter.h [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/test/wizard_in_process_browser_test.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/test/wizard_in_process_browser_test.h [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/ui/login_display_host.h [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/ui/login_display_host_impl.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/ui/login_display_host_impl.h [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/ui/mock_login_display_host.h [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/ui/models/user_board_model.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/wizard_controller.h [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/login/wizard_controller_browsertest.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/policy/device_local_account_browsertest.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/system/device_disabling_browsertest.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/chromeos/system/device_disabling_manager_default_delegate.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/ui/webui/chromeos/login/base_screen_handler.h [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/ui/webui/chromeos/login/controller_pairing_screen_handler.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/ui/webui/chromeos/login/device_disabled_screen_handler.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/ui/webui/chromeos/login/enable_debugging_screen_handler.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/ui/webui/chromeos/login/kiosk_autolaunch_screen_handler.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/ui/webui/chromeos/login/oobe_ui.h [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc [modify] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/ui/webui/chromeos/login/wrong_hwid_screen_handler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6eeb70e1252bdbed947ed41d027d377f8093dc9 commit e6eeb70e1252bdbed947ed41d027d377f8093dc9 Author: jdufault <jdufault@chromium.org> Date: Sat Jan 14 01:13:19 2017 cros: Fold EulaModel into EulaView. EulaModel has only one derived type, EulaView. BUG= 672142 Review-Url: https://codereview.chromium.org/2556253002 Cr-Commit-Position: refs/heads/master@{#443755} [modify] https://crrev.com/e6eeb70e1252bdbed947ed41d027d377f8093dc9/chrome/browser/chromeos/BUILD.gn [delete] https://crrev.com/38dbc8d042479ec398cde8eecfa29b1bd29a0761/chrome/browser/chromeos/login/screens/eula_model.cc [delete] https://crrev.com/38dbc8d042479ec398cde8eecfa29b1bd29a0761/chrome/browser/chromeos/login/screens/eula_model.h [modify] https://crrev.com/e6eeb70e1252bdbed947ed41d027d377f8093dc9/chrome/browser/chromeos/login/screens/eula_screen.cc [modify] https://crrev.com/e6eeb70e1252bdbed947ed41d027d377f8093dc9/chrome/browser/chromeos/login/screens/eula_screen.h [modify] https://crrev.com/e6eeb70e1252bdbed947ed41d027d377f8093dc9/chrome/browser/chromeos/login/screens/eula_view.h [modify] https://crrev.com/e6eeb70e1252bdbed947ed41d027d377f8093dc9/chrome/browser/chromeos/login/screens/mock_eula_screen.cc [modify] https://crrev.com/e6eeb70e1252bdbed947ed41d027d377f8093dc9/chrome/browser/chromeos/login/screens/mock_eula_screen.h [modify] https://crrev.com/e6eeb70e1252bdbed947ed41d027d377f8093dc9/chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc [modify] https://crrev.com/e6eeb70e1252bdbed947ed41d027d377f8093dc9/chrome/browser/ui/webui/chromeos/login/eula_screen_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cdbfd4cabc0df6eb1c945ca4ee594bb4d131c461 commit cdbfd4cabc0df6eb1c945ca4ee594bb4d131c461 Author: jdufault <jdufault@chromium.org> Date: Tue Jan 17 20:41:34 2017 cros: Remove BaseScreen::Initialize method. I'm not sure what the long term plan with this method was, but it looks like we can just move all of the associated work it did to the constructor to achieve the same effect. BUG= 672142 Review-Url: https://codereview.chromium.org/2633413002 Cr-Commit-Position: refs/heads/master@{#444130} [modify] https://crrev.com/cdbfd4cabc0df6eb1c945ca4ee594bb4d131c461/chrome/browser/chromeos/login/screens/base_screen.cc [modify] https://crrev.com/cdbfd4cabc0df6eb1c945ca4ee594bb4d131c461/chrome/browser/chromeos/login/screens/base_screen.h [modify] https://crrev.com/cdbfd4cabc0df6eb1c945ca4ee594bb4d131c461/chrome/browser/chromeos/login/screens/hid_detection_screen.cc [modify] https://crrev.com/cdbfd4cabc0df6eb1c945ca4ee594bb4d131c461/chrome/browser/chromeos/login/screens/hid_detection_screen.h [modify] https://crrev.com/cdbfd4cabc0df6eb1c945ca4ee594bb4d131c461/chrome/browser/chromeos/login/screens/network_screen.cc [modify] https://crrev.com/cdbfd4cabc0df6eb1c945ca4ee594bb4d131c461/chrome/browser/chromeos/login/screens/network_screen.h [modify] https://crrev.com/cdbfd4cabc0df6eb1c945ca4ee594bb4d131c461/chrome/browser/chromeos/login/screens/update_screen.cc [modify] https://crrev.com/cdbfd4cabc0df6eb1c945ca4ee594bb4d131c461/chrome/browser/chromeos/login/screens/update_screen.h [modify] https://crrev.com/cdbfd4cabc0df6eb1c945ca4ee594bb4d131c461/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/cdbfd4cabc0df6eb1c945ca4ee594bb4d131c461/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b07546314db5956f7f793d660bee51f8067ed14 commit 6b07546314db5956f7f793d660bee51f8067ed14 Author: jdufault <jdufault@chromium.org> Date: Fri Jan 20 21:27:32 2017 cros: Fold HIDDetectionModel into HIDDetectionScreen. HIDDetectionModel has only one derived type, HIDDetectionScreen. BUG= 672142 Review-Url: https://codereview.chromium.org/2638123002 Cr-Commit-Position: refs/heads/master@{#445170} [modify] https://crrev.com/6b07546314db5956f7f793d660bee51f8067ed14/chrome/browser/chromeos/BUILD.gn [delete] https://crrev.com/b43ccf2f38c946763398101d18775e1f5534bea7/chrome/browser/chromeos/login/screens/hid_detection_model.cc [delete] https://crrev.com/b43ccf2f38c946763398101d18775e1f5534bea7/chrome/browser/chromeos/login/screens/hid_detection_model.h [modify] https://crrev.com/6b07546314db5956f7f793d660bee51f8067ed14/chrome/browser/chromeos/login/screens/hid_detection_screen.cc [modify] https://crrev.com/6b07546314db5956f7f793d660bee51f8067ed14/chrome/browser/chromeos/login/screens/hid_detection_screen.h [modify] https://crrev.com/6b07546314db5956f7f793d660bee51f8067ed14/chrome/browser/chromeos/login/screens/hid_detection_screen_browsertest.cc [modify] https://crrev.com/6b07546314db5956f7f793d660bee51f8067ed14/chrome/browser/chromeos/login/screens/hid_detection_view.h [modify] https://crrev.com/6b07546314db5956f7f793d660bee51f8067ed14/chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.cc [modify] https://crrev.com/6b07546314db5956f7f793d660bee51f8067ed14/chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5d12651d5fd3040b3ce1357ca0fbc2fb9d535ba commit d5d12651d5fd3040b3ce1357ca0fbc2fb9d535ba Author: jdufault <jdufault@chromium.org> Date: Wed Jan 25 23:05:04 2017 cros: Fold NetworkErrorModel into NetworkErrorView. NetworkErrorModel had one derived type, NetworkErrorView. BUG= 672142 Review-Url: https://codereview.chromium.org/2642823011 Cr-Commit-Position: refs/heads/master@{#446153} [modify] https://crrev.com/d5d12651d5fd3040b3ce1357ca0fbc2fb9d535ba/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/d5d12651d5fd3040b3ce1357ca0fbc2fb9d535ba/chrome/browser/chromeos/login/screens/error_screen.cc [modify] https://crrev.com/d5d12651d5fd3040b3ce1357ca0fbc2fb9d535ba/chrome/browser/chromeos/login/screens/error_screen.h [modify] https://crrev.com/d5d12651d5fd3040b3ce1357ca0fbc2fb9d535ba/chrome/browser/chromeos/login/screens/mock_error_screen.cc [modify] https://crrev.com/d5d12651d5fd3040b3ce1357ca0fbc2fb9d535ba/chrome/browser/chromeos/login/screens/mock_error_screen.h [modify] https://crrev.com/d5d12651d5fd3040b3ce1357ca0fbc2fb9d535ba/chrome/browser/chromeos/login/screens/network_error.h [delete] https://crrev.com/4165f8b808fa119cc593dafb257de78bc266d02c/chrome/browser/chromeos/login/screens/network_error_model.cc [delete] https://crrev.com/4165f8b808fa119cc593dafb257de78bc266d02c/chrome/browser/chromeos/login/screens/network_error_model.h [modify] https://crrev.com/d5d12651d5fd3040b3ce1357ca0fbc2fb9d535ba/chrome/browser/chromeos/login/screens/network_error_view.h [modify] https://crrev.com/d5d12651d5fd3040b3ce1357ca0fbc2fb9d535ba/chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc [modify] https://crrev.com/d5d12651d5fd3040b3ce1357ca0fbc2fb9d535ba/chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.h [modify] https://crrev.com/d5d12651d5fd3040b3ce1357ca0fbc2fb9d535ba/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc [modify] https://crrev.com/d5d12651d5fd3040b3ce1357ca0fbc2fb9d535ba/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.h [modify] https://crrev.com/d5d12651d5fd3040b3ce1357ca0fbc2fb9d535ba/chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc [modify] https://crrev.com/d5d12651d5fd3040b3ce1357ca0fbc2fb9d535ba/chrome/browser/ui/webui/chromeos/login/error_screen_handler.h [modify] https://crrev.com/d5d12651d5fd3040b3ce1357ca0fbc2fb9d535ba/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc [modify] https://crrev.com/d5d12651d5fd3040b3ce1357ca0fbc2fb9d535ba/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc [modify] https://crrev.com/d5d12651d5fd3040b3ce1357ca0fbc2fb9d535ba/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afd6ce56d8bf38ed03a3c79809c0edb4429c3ced commit afd6ce56d8bf38ed03a3c79809c0edb4429c3ced Author: jdufault <jdufault@chromium.org> Date: Sat Jan 28 01:42:44 2017 cros: Fold NetworkModel into NetworkScreen BUG= 672142 Review-Url: https://codereview.chromium.org/2649873009 Cr-Commit-Position: refs/heads/master@{#446872} [modify] https://crrev.com/afd6ce56d8bf38ed03a3c79809c0edb4429c3ced/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/afd6ce56d8bf38ed03a3c79809c0edb4429c3ced/chrome/browser/chromeos/login/oobe_localization_browsertest.cc [modify] https://crrev.com/afd6ce56d8bf38ed03a3c79809c0edb4429c3ced/chrome/browser/chromeos/login/screens/mock_network_screen.cc [modify] https://crrev.com/afd6ce56d8bf38ed03a3c79809c0edb4429c3ced/chrome/browser/chromeos/login/screens/mock_network_screen.h [delete] https://crrev.com/d11a57aeb74b2f5fee0b8fb7b664a05e3257906c/chrome/browser/chromeos/login/screens/network_model.cc [delete] https://crrev.com/d11a57aeb74b2f5fee0b8fb7b664a05e3257906c/chrome/browser/chromeos/login/screens/network_model.h [modify] https://crrev.com/afd6ce56d8bf38ed03a3c79809c0edb4429c3ced/chrome/browser/chromeos/login/screens/network_screen.cc [modify] https://crrev.com/afd6ce56d8bf38ed03a3c79809c0edb4429c3ced/chrome/browser/chromeos/login/screens/network_screen.h [modify] https://crrev.com/afd6ce56d8bf38ed03a3c79809c0edb4429c3ced/chrome/browser/chromeos/login/screens/network_view.h [modify] https://crrev.com/afd6ce56d8bf38ed03a3c79809c0edb4429c3ced/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc [modify] https://crrev.com/afd6ce56d8bf38ed03a3c79809c0edb4429c3ced/chrome/browser/ui/webui/chromeos/login/network_screen_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c097a72d4f220aeac388197965a1a64aa04a20e6 commit c097a72d4f220aeac388197965a1a64aa04a20e6 Author: jdufault <jdufault@chromium.org> Date: Fri Feb 03 04:04:39 2017 cros: Fold ResetModel into ResetScreen BUG= 672142 Review-Url: https://codereview.chromium.org/2657953005 Cr-Commit-Position: refs/heads/master@{#447921} [modify] https://crrev.com/c097a72d4f220aeac388197965a1a64aa04a20e6/chrome/browser/chromeos/BUILD.gn [delete] https://crrev.com/51caab48c4d306f87689b182bb28f608aba91fa3/chrome/browser/chromeos/login/screens/reset_model.cc [delete] https://crrev.com/51caab48c4d306f87689b182bb28f608aba91fa3/chrome/browser/chromeos/login/screens/reset_model.h [modify] https://crrev.com/c097a72d4f220aeac388197965a1a64aa04a20e6/chrome/browser/chromeos/login/screens/reset_screen.cc [modify] https://crrev.com/c097a72d4f220aeac388197965a1a64aa04a20e6/chrome/browser/chromeos/login/screens/reset_screen.h [modify] https://crrev.com/c097a72d4f220aeac388197965a1a64aa04a20e6/chrome/browser/chromeos/login/screens/reset_view.h [modify] https://crrev.com/c097a72d4f220aeac388197965a1a64aa04a20e6/chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc [modify] https://crrev.com/c097a72d4f220aeac388197965a1a64aa04a20e6/chrome/browser/ui/webui/chromeos/login/reset_screen_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eed833f5e4ec040342c08755bad3f45c3a0b8ab6 commit eed833f5e4ec040342c08755bad3f45c3a0b8ab6 Author: jdufault <jdufault@chromium.org> Date: Mon Feb 06 23:56:20 2017 Fold UpdateModel into UpdateScreen. BUG= 672142 Review-Url: https://codereview.chromium.org/2673943002 Cr-Commit-Position: refs/heads/master@{#448447} [modify] https://crrev.com/eed833f5e4ec040342c08755bad3f45c3a0b8ab6/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/eed833f5e4ec040342c08755bad3f45c3a0b8ab6/chrome/browser/chromeos/login/screens/mock_update_screen.cc [modify] https://crrev.com/eed833f5e4ec040342c08755bad3f45c3a0b8ab6/chrome/browser/chromeos/login/screens/mock_update_screen.h [delete] https://crrev.com/35ab0f010dd7ca82e59c9d31114e033780e4b9e6/chrome/browser/chromeos/login/screens/update_model.cc [delete] https://crrev.com/35ab0f010dd7ca82e59c9d31114e033780e4b9e6/chrome/browser/chromeos/login/screens/update_model.h [modify] https://crrev.com/eed833f5e4ec040342c08755bad3f45c3a0b8ab6/chrome/browser/chromeos/login/screens/update_screen.cc [modify] https://crrev.com/eed833f5e4ec040342c08755bad3f45c3a0b8ab6/chrome/browser/chromeos/login/screens/update_screen.h [modify] https://crrev.com/eed833f5e4ec040342c08755bad3f45c3a0b8ab6/chrome/browser/chromeos/login/screens/update_view.h [modify] https://crrev.com/eed833f5e4ec040342c08755bad3f45c3a0b8ab6/chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc [modify] https://crrev.com/eed833f5e4ec040342c08755bad3f45c3a0b8ab6/chrome/browser/ui/webui/chromeos/login/update_screen_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac3199fb6ba8ca561b09abddce556acfa9c8c5cd commit ac3199fb6ba8ca561b09abddce556acfa9c8c5cd Author: jdufault <jdufault@chromium.org> Date: Tue Feb 07 00:39:47 2017 Revert of Fold UpdateModel into UpdateScreen. (patchset #3 id:40001 of https://codereview.chromium.org/2673943002/ ) Reason for revert: Broke compile FAILED: obj/chrome/browser/chromeos/chromeos/update_screen.o /b/c/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/browser/chromeos/chromeos/update_screen.o.d -DV8_DEPRECATION_WARNINGS -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DENABLE_WAYLAND_SERVER=1 -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -DENABLE_MEDIA_ROUTER=1 -DCR_CLANG_REVISION=289944-2 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DOS_CHROMEOS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DTOOLKIT_VIEWS=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DSK_IGNORE_DW_GRAY_FIX -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DV8_USE_EXTERNAL_STARTUP_DATA -DLEVELDB_PLATFORM_CHROMIUM=1 -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_LINUX -DCHROMEOS -DNO_MAIN_THREAD_WRAPPING -I../.. -Igen -I../../build/linux/ubuntu_precise_amd64-sysroot/usr/include/glib-2.0 -I../../build/linux/ubuntu_precise_amd64-sysroot/usr/lib/x86_64-linux-gnu/glib-2.0/include -I../../third_party/khronos -I../../gpu -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -Igen/ash/common/strings -Igen/ash/resources -Igen/chrome -Igen/chrome -Igen/chrome -Igen/chrome -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -Igen/ui/chromeos/resources -Igen/ui/chromeos/strings -Igen/ui/resources -Igen/ui/resources -Igen -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/boringssl/src/include -Igen/components/metrics/proto -I../../build/linux/ubuntu_precise_amd64-sysroot/usr/include/nss -I../../build/linux/ubuntu_precise_amd64-sysroot/usr/include/nspr -Igen/components/strings -Igen/components/strings -Igen/components/strings -Igen/components/strings -I../../third_party/libwebm/source -Igen -I../../third_party/WebKit -Igen/third_party/WebKit -I../../v8/include -Igen/v8/include -I../../third_party/re2/src -I../../third_party/mesa/src/include -Igen/extensions -Igen/extensions -Igen/extensions -Igen -Igen/extensions/strings -I../../build/linux/ubuntu_precise_amd64-sysroot/usr/include/dbus-1.0 -I../../build/linux/ubuntu_precise_amd64-sysroot/usr/lib/x86_64-linux-gnu/dbus-1.0/include -Igen -Igen/components -Igen/components -I../../third_party/cacheinvalidation/overrides -I../../third_party/cacheinvalidation/src -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include -I../../third_party/webrtc_overrides -I../../testing/gtest/include -I../../third_party -I../../third_party/webrtc_overrides -I../../third_party -I../../third_party/libusb/src/libusb -I../../third_party/zlib -Igen/ui/views/resources -Igen/ui/file_manager -I../../v8/include -Igen/v8/include -fno-strict-aliasing -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin -fcolor-diagnostics -fdebug-prefix-map=/b/c/b/Google_Chrome_ChromeOS/src=. -m64 -march=x86-64 -pthread -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -O2 -fno-ident -fdata-sections -ffunction-sections -g2 --sysroot=../../build/linux/ubuntu_precise_amd64-sysroot -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wexit-time-destructors -Wno-header-guard -fvisibility-inlines-hidden -std=gnu++11 -Wno-reserved-user-defined-literal -fno-rtti -fno-exceptions -c ../../chrome/browser/chromeos/login/screens/update_screen.cc -o obj/chrome/browser/chromeos/chromeos/update_screen.o ../../chrome/browser/chromeos/login/screens/update_screen.cc:38:22: error: unused variable 'kUserActionCancelUpdateShortcut' [-Werror,-Wunused-const-variable] constexpr const char kUserActionCancelUpdateShortcut[] = "cancel-update"; ^ ../../chrome/browser/chromeos/login/screens/update_screen.cc:46:22: error: unused variable 'kContextKeyCancelUpdateShortcutEnabled' [-Werror,-Wunused-const-variable] constexpr const char kContextKeyCancelUpdateShortcutEnabled[] = Original issue's description: > Fold UpdateModel into UpdateScreen. > > BUG= 672142 > > Review-Url: https://codereview.chromium.org/2673943002 > Cr-Commit-Position: refs/heads/master@{#448447} > Committed: https://chromium.googlesource.com/chromium/src/+/eed833f5e4ec040342c08755bad3f45c3a0b8ab6 TBR=achuith@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 672142 Review-Url: https://codereview.chromium.org/2684473002 Cr-Commit-Position: refs/heads/master@{#448467} [modify] https://crrev.com/ac3199fb6ba8ca561b09abddce556acfa9c8c5cd/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/ac3199fb6ba8ca561b09abddce556acfa9c8c5cd/chrome/browser/chromeos/login/screens/mock_update_screen.cc [modify] https://crrev.com/ac3199fb6ba8ca561b09abddce556acfa9c8c5cd/chrome/browser/chromeos/login/screens/mock_update_screen.h [add] https://crrev.com/ac3199fb6ba8ca561b09abddce556acfa9c8c5cd/chrome/browser/chromeos/login/screens/update_model.cc [add] https://crrev.com/ac3199fb6ba8ca561b09abddce556acfa9c8c5cd/chrome/browser/chromeos/login/screens/update_model.h [modify] https://crrev.com/ac3199fb6ba8ca561b09abddce556acfa9c8c5cd/chrome/browser/chromeos/login/screens/update_screen.cc [modify] https://crrev.com/ac3199fb6ba8ca561b09abddce556acfa9c8c5cd/chrome/browser/chromeos/login/screens/update_screen.h [modify] https://crrev.com/ac3199fb6ba8ca561b09abddce556acfa9c8c5cd/chrome/browser/chromeos/login/screens/update_view.h [modify] https://crrev.com/ac3199fb6ba8ca561b09abddce556acfa9c8c5cd/chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc [modify] https://crrev.com/ac3199fb6ba8ca561b09abddce556acfa9c8c5cd/chrome/browser/ui/webui/chromeos/login/update_screen_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7952a26a6078a70081aa24d4d62a0c478badc28 commit e7952a26a6078a70081aa24d4d62a0c478badc28 Author: jdufault <jdufault@chromium.org> Date: Tue Feb 07 00:44:47 2017 cros: Clear out LoginDisplayHostImpl::login_view_ before login_window_. login_window_ owns the login_view_ instance; closing login_window_ could invalidate the login_view_ pointer. BUG= 672142 Review-Url: https://codereview.chromium.org/2654003008 Cr-Commit-Position: refs/heads/master@{#448470} [modify] https://crrev.com/e7952a26a6078a70081aa24d4d62a0c478badc28/chrome/browser/chromeos/login/ui/login_display_host_impl.cc [modify] https://crrev.com/e7952a26a6078a70081aa24d4d62a0c478badc28/chrome/browser/chromeos/login/ui/login_display_host_impl.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b772e23dc0971200d2dcf38f6305091e4d01813 commit 3b772e23dc0971200d2dcf38f6305091e4d01813 Author: jdufault <jdufault@chromium.org> Date: Tue Feb 07 20:21:05 2017 Reland: Fold UpdateModel into UpdateScreen. Original CL: https://codereview.chromium.org/2673943002/ BUG= 672142 Review-Url: https://codereview.chromium.org/2681873002 Cr-Commit-Position: refs/heads/master@{#448718} [modify] https://crrev.com/3b772e23dc0971200d2dcf38f6305091e4d01813/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/3b772e23dc0971200d2dcf38f6305091e4d01813/chrome/browser/chromeos/login/screens/mock_update_screen.cc [modify] https://crrev.com/3b772e23dc0971200d2dcf38f6305091e4d01813/chrome/browser/chromeos/login/screens/mock_update_screen.h [delete] https://crrev.com/cb99bd68c436ef26d4b4d6abe88e2e2d5ab7da0a/chrome/browser/chromeos/login/screens/update_model.cc [delete] https://crrev.com/cb99bd68c436ef26d4b4d6abe88e2e2d5ab7da0a/chrome/browser/chromeos/login/screens/update_model.h [modify] https://crrev.com/3b772e23dc0971200d2dcf38f6305091e4d01813/chrome/browser/chromeos/login/screens/update_screen.cc [modify] https://crrev.com/3b772e23dc0971200d2dcf38f6305091e4d01813/chrome/browser/chromeos/login/screens/update_screen.h [modify] https://crrev.com/3b772e23dc0971200d2dcf38f6305091e4d01813/chrome/browser/chromeos/login/screens/update_view.h [modify] https://crrev.com/3b772e23dc0971200d2dcf38f6305091e4d01813/chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc [modify] https://crrev.com/3b772e23dc0971200d2dcf38f6305091e4d01813/chrome/browser/ui/webui/chromeos/login/update_screen_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76f6120183c45c90cb9e37ea12ec963d858e2dad commit 76f6120183c45c90cb9e37ea12ec963d858e2dad Author: jdufault <jdufault@chromium.org> Date: Wed Feb 08 03:28:56 2017 cros: Fold UserBoardModel into UserSelectionScreen. BUG= 672142 Review-Url: https://codereview.chromium.org/2676323003 Cr-Commit-Position: refs/heads/master@{#448893} [modify] https://crrev.com/76f6120183c45c90cb9e37ea12ec963d858e2dad/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/76f6120183c45c90cb9e37ea12ec963d858e2dad/chrome/browser/chromeos/login/screens/user_selection_screen.cc [modify] https://crrev.com/76f6120183c45c90cb9e37ea12ec963d858e2dad/chrome/browser/chromeos/login/screens/user_selection_screen.h [modify] https://crrev.com/76f6120183c45c90cb9e37ea12ec963d858e2dad/chrome/browser/chromeos/login/signin_screen_controller.cc [delete] https://crrev.com/5903317ed90e3203ce2ead7a9ddda5ef0429b0d2/chrome/browser/chromeos/login/ui/models/user_board_model.cc [delete] https://crrev.com/5903317ed90e3203ce2ead7a9ddda5ef0429b0d2/chrome/browser/chromeos/login/ui/models/user_board_model.h [modify] https://crrev.com/76f6120183c45c90cb9e37ea12ec963d858e2dad/chrome/browser/chromeos/login/ui/views/user_board_view.h [modify] https://crrev.com/76f6120183c45c90cb9e37ea12ec963d858e2dad/chrome/browser/ui/webui/chromeos/login/user_board_screen_handler.cc [modify] https://crrev.com/76f6120183c45c90cb9e37ea12ec963d858e2dad/chrome/browser/ui/webui/chromeos/login/user_board_screen_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75ab22d721451fbe895843e588ef66558ba03ddb commit 75ab22d721451fbe895843e588ef66558ba03ddb Author: jdufault <jdufault@chromium.org> Date: Fri Feb 10 22:13:03 2017 cros: Fold UserImageModel into UserImageScreen BUG= 672142 Review-Url: https://codereview.chromium.org/2684883002 Cr-Commit-Position: refs/heads/master@{#449754} [modify] https://crrev.com/75ab22d721451fbe895843e588ef66558ba03ddb/chrome/browser/chromeos/BUILD.gn [delete] https://crrev.com/c010a4d03a91256d1b514fae3d710acffe46db30/chrome/browser/chromeos/login/screens/user_image_model.cc [delete] https://crrev.com/c010a4d03a91256d1b514fae3d710acffe46db30/chrome/browser/chromeos/login/screens/user_image_model.h [modify] https://crrev.com/75ab22d721451fbe895843e588ef66558ba03ddb/chrome/browser/chromeos/login/screens/user_image_screen.cc [modify] https://crrev.com/75ab22d721451fbe895843e588ef66558ba03ddb/chrome/browser/chromeos/login/screens/user_image_screen.h [modify] https://crrev.com/75ab22d721451fbe895843e588ef66558ba03ddb/chrome/browser/chromeos/login/screens/user_image_view.h [modify] https://crrev.com/75ab22d721451fbe895843e588ef66558ba03ddb/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc [modify] https://crrev.com/75ab22d721451fbe895843e588ef66558ba03ddb/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4de768bdfc1172c324ef6e2f92c677edc29f300f commit 4de768bdfc1172c324ef6e2f92c677edc29f300f Author: jdufault <jdufault@chromium.org> Date: Wed Feb 15 05:58:29 2017 cros: Remove unused inline_login_handler_chromeos.h/cc files. BUG= 672142 Review-Url: https://codereview.chromium.org/2690113011 Cr-Commit-Position: refs/heads/master@{#450576} [delete] https://crrev.com/7239bff66dcb73541208ba0924470f5e74dad72a/chrome/browser/ui/webui/chromeos/login/inline_login_handler_chromeos.cc [delete] https://crrev.com/7239bff66dcb73541208ba0924470f5e74dad72a/chrome/browser/ui/webui/chromeos/login/inline_login_handler_chromeos.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294 commit 41140d63ffc66fc6b93b6a3012b5b92bfbfaa294 Author: jdufault <jdufault@chromium.org> Date: Wed Feb 22 19:05:21 2017 cros: Move call js prefix out of ctor. BUG= 672142 Review-Url: https://codereview.chromium.org/2701023003 Cr-Commit-Position: refs/heads/master@{#452152} [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/arc_kiosk_splash_screen_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.h [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/base_screen_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/base_screen_handler.h [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/controller_pairing_screen_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/controller_pairing_screen_handler.h [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/device_disabled_screen_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/device_disabled_screen_handler.h [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/enable_debugging_screen_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/enable_debugging_screen_handler.h [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.h [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/kiosk_autolaunch_screen_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/kiosk_autolaunch_screen_handler.h [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/kiosk_enable_screen_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/kiosk_enable_screen_handler.h [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.h [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.h [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/wrong_hwid_screen_handler.cc [modify] https://crrev.com/41140d63ffc66fc6b93b6a3012b5b92bfbfaa294/chrome/browser/ui/webui/chromeos/login/wrong_hwid_screen_handler.h
Thanks for doing this work!
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6dcdb5dbbb54ed996752076d7c544b06e01bed34 commit 6dcdb5dbbb54ed996752076d7c544b06e01bed34 Author: jdufault <jdufault@chromium.org> Date: Thu Feb 23 09:46:36 2017 cros: Remove AuthenticatedUserEmailRetriever. This code is unused. BUG= 672142 Review-Url: https://codereview.chromium.org/2712483002 Cr-Commit-Position: refs/heads/master@{#452444} [modify] https://crrev.com/6dcdb5dbbb54ed996752076d7c544b06e01bed34/chrome/browser/ui/BUILD.gn [delete] https://crrev.com/360b16ec95b18a11357e354b3b3db1080264f757/chrome/browser/ui/webui/chromeos/login/authenticated_user_email_retriever.cc [delete] https://crrev.com/360b16ec95b18a11357e354b3b3db1080264f757/chrome/browser/ui/webui/chromeos/login/authenticated_user_email_retriever.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eda3863d1963478c04b05d846f3ce34cac5283ee commit eda3863d1963478c04b05d846f3ce34cac5283ee Author: jdufault <jdufault@chromium.org> Date: Fri Feb 24 19:49:12 2017 cros: Unify oobe View/Actor naming to just View. BUG= 672142 Review-Url: https://codereview.chromium.org/2700303002 Cr-Commit-Position: refs/heads/master@{#452906} [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/BUILD.gn [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/arc/optin/arc_terms_of_service_oobe_negotiator.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/arc/optin/arc_terms_of_service_oobe_negotiator.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/app_launch_controller.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/app_launch_controller.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/arc_kiosk_controller.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/arc_kiosk_controller.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.h [rename] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen_view.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/enrollment/enrollment_screen.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/enrollment/enrollment_screen.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/enrollment/enrollment_screen_unittest.cc [rename] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/enrollment/enrollment_screen_view.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/enrollment/mock_auto_enrollment_check_screen.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/enrollment/mock_auto_enrollment_check_screen.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/enrollment/mock_enrollment_screen.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/enrollment/mock_enrollment_screen.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/kiosk_browsertest.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/lock/webui_screen_locker.cc [rename] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/app_launch_splash_screen_view.h [rename] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/arc_kiosk_splash_screen_view.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/arc_terms_of_service_screen.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/arc_terms_of_service_screen.h [delete] https://crrev.com/5113973bc4260b94300d81502935d5ebab57a1d0/chrome/browser/chromeos/login/screens/arc_terms_of_service_screen_actor_observer.h [rename] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/arc_terms_of_service_screen_view.h [add] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/arc_terms_of_service_screen_view_observer.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/controller_pairing_screen.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/controller_pairing_screen.h [rename] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/controller_pairing_screen_view.cc [rename] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/controller_pairing_screen_view.h [rename] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/core_oobe_view.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/device_disabled_screen.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/device_disabled_screen.h [rename] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/device_disabled_screen_view.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/enable_debugging_screen.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/enable_debugging_screen.h [rename] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/enable_debugging_screen_view.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/eula_screen.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/host_pairing_screen.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/host_pairing_screen.h [rename] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/host_pairing_screen_view.cc [rename] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/host_pairing_screen_view.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/kiosk_autolaunch_screen.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/kiosk_autolaunch_screen.h [rename] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/kiosk_autolaunch_screen_view.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/kiosk_enable_screen.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/kiosk_enable_screen.h [rename] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/kiosk_enable_screen_view.h [rename] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/mock_device_disabled_screen_view.cc [rename] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/mock_device_disabled_screen_view.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/mock_enable_debugging_screen.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/mock_enable_debugging_screen.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/mock_wrong_hwid_screen.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/mock_wrong_hwid_screen.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/network_screen_browsertest.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/reset_screen.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/terms_of_service_screen.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/terms_of_service_screen.h [rename] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/terms_of_service_screen_view.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/wrong_hwid_screen.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/wrong_hwid_screen.h [rename] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/screens/wrong_hwid_screen_view.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/signin_screen_controller.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/ui/login_display_host_impl.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/chromeos/login/wizard_controller_browsertest.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/arc_kiosk_splash_screen_handler.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/arc_terms_of_service_screen_handler.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/controller_pairing_screen_handler.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/controller_pairing_screen_handler.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/device_disabled_screen_handler.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/device_disabled_screen_handler.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/enable_debugging_screen_handler.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/enable_debugging_screen_handler.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/eula_screen_handler.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/kiosk_autolaunch_screen_handler.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/kiosk_autolaunch_screen_handler.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/kiosk_enable_screen_handler.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/kiosk_enable_screen_handler.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/network_dropdown.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/network_screen_handler.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/oobe_ui.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.h [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/wrong_hwid_screen_handler.cc [modify] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/chrome/browser/ui/webui/chromeos/login/wrong_hwid_screen_handler.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7ffcc0b765e31ec060f05994d29623c17e00d71 commit a7ffcc0b765e31ec060f05994d29623c17e00d71 Author: jdufault <jdufault@chromium.org> Date: Sat Feb 25 00:53:56 2017 cros: Remove usage of GaiaScreenHandler outside of webui/chromeos/login. BUG= 672142 Review-Url: https://codereview.chromium.org/2710673003 Cr-Commit-Position: refs/heads/master@{#453029} [modify] https://crrev.com/a7ffcc0b765e31ec060f05994d29623c17e00d71/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/a7ffcc0b765e31ec060f05994d29623c17e00d71/chrome/browser/chromeos/login/screens/gaia_screen.cc [modify] https://crrev.com/a7ffcc0b765e31ec060f05994d29623c17e00d71/chrome/browser/chromeos/login/screens/gaia_screen.h [add] https://crrev.com/a7ffcc0b765e31ec060f05994d29623c17e00d71/chrome/browser/chromeos/login/screens/gaia_view.h [modify] https://crrev.com/a7ffcc0b765e31ec060f05994d29623c17e00d71/chrome/browser/chromeos/login/signin_screen_controller.cc [modify] https://crrev.com/a7ffcc0b765e31ec060f05994d29623c17e00d71/chrome/browser/chromeos/login/ui/login_display_host_impl.cc [modify] https://crrev.com/a7ffcc0b765e31ec060f05994d29623c17e00d71/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc [modify] https://crrev.com/a7ffcc0b765e31ec060f05994d29623c17e00d71/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h [modify] https://crrev.com/a7ffcc0b765e31ec060f05994d29623c17e00d71/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc [modify] https://crrev.com/a7ffcc0b765e31ec060f05994d29623c17e00d71/chrome/browser/ui/webui/chromeos/login/oobe_ui.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9c1c3fb361133055cc5ad2aa0009b7118b909a11 commit 9c1c3fb361133055cc5ad2aa0009b7118b909a11 Author: jdufault <jdufault@chromium.org> Date: Mon Feb 27 22:28:37 2017 cros: Move BaseScreenDelegate::ExitCodes into separate file, ScreenExitCode. This CL also logs exit codes as strings instead of as ints. BUG= 672142 Review-Url: https://codereview.chromium.org/2705363002 Cr-Commit-Position: refs/heads/master@{#453360} [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/BUILD.gn [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/enrollment/enrollment_screen.cc [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/enrollment/enrollment_screen_unittest.cc [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/screens/arc_terms_of_service_screen.cc [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/screens/base_screen.cc [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/screens/base_screen.h [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/screens/base_screen_delegate.h [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/screens/controller_pairing_screen.cc [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/screens/enable_debugging_screen.cc [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/screens/eula_screen.cc [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/screens/hid_detection_screen.cc [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/screens/host_pairing_screen.cc [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/screens/kiosk_autolaunch_screen.cc [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/screens/kiosk_enable_screen.cc [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/screens/mock_base_screen_delegate.h [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/screens/network_screen.cc [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/screens/network_screen_browsertest.cc [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/screens/reset_screen.cc [add] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/screens/screen_exit_code.cc [add] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/screens/screen_exit_code.h [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/screens/terms_of_service_screen.cc [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/screens/update_screen.cc [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/screens/update_screen_browsertest.cc [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/screens/user_image_screen.cc [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/screens/wrong_hwid_screen.cc [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/wizard_controller.h [modify] https://crrev.com/9c1c3fb361133055cc5ad2aa0009b7118b909a11/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e853fed56dd2eee26d9ead959380c6e4d89a4c99 commit e853fed56dd2eee26d9ead959380c6e4d89a4c99 Author: jdufault <jdufault@chromium.org> Date: Mon Feb 27 23:09:18 2017 cros: Remove unused WizardController::Observer. Details about screen changes should be fully encapsulated within WizardController. BUG= 672142 Review-Url: https://codereview.chromium.org/2713553006 Cr-Commit-Position: refs/heads/master@{#453377} [modify] https://crrev.com/e853fed56dd2eee26d9ead959380c6e4d89a4c99/chrome/browser/chromeos/login/ui/login_display_host_impl.cc [modify] https://crrev.com/e853fed56dd2eee26d9ead959380c6e4d89a4c99/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/e853fed56dd2eee26d9ead959380c6e4d89a4c99/chrome/browser/chromeos/login/wizard_controller.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ceda53488f7cc8d72734247c6a5e11422c40ede commit 3ceda53488f7cc8d72734247c6a5e11422c40ede Author: jdufault <jdufault@chromium.org> Date: Sat Mar 11 00:24:12 2017 cros: Use ScreenManager as a component instead of deriving WizardController from it This makes it easier/cleaner to implement CoreOobeView::Delegate on ScreenManager in a follow-up CL. BUG= 672142 Review-Url: https://codereview.chromium.org/2739073002 Cr-Commit-Position: refs/heads/master@{#456228} [modify] https://crrev.com/3ceda53488f7cc8d72734247c6a5e11422c40ede/chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc [modify] https://crrev.com/3ceda53488f7cc8d72734247c6a5e11422c40ede/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc [modify] https://crrev.com/3ceda53488f7cc8d72734247c6a5e11422c40ede/chrome/browser/chromeos/login/oobe_localization_browsertest.cc [modify] https://crrev.com/3ceda53488f7cc8d72734247c6a5e11422c40ede/chrome/browser/chromeos/login/screen_manager.cc [modify] https://crrev.com/3ceda53488f7cc8d72734247c6a5e11422c40ede/chrome/browser/chromeos/login/screen_manager.h [modify] https://crrev.com/3ceda53488f7cc8d72734247c6a5e11422c40ede/chrome/browser/chromeos/login/screens/network_screen_browsertest.cc [modify] https://crrev.com/3ceda53488f7cc8d72734247c6a5e11422c40ede/chrome/browser/chromeos/login/screens/update_screen_browsertest.cc [modify] https://crrev.com/3ceda53488f7cc8d72734247c6a5e11422c40ede/chrome/browser/chromeos/login/supervised/supervised_user_creation_flow.cc [modify] https://crrev.com/3ceda53488f7cc8d72734247c6a5e11422c40ede/chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.cc [modify] https://crrev.com/3ceda53488f7cc8d72734247c6a5e11422c40ede/chrome/browser/chromeos/login/wizard_controller.cc [modify] https://crrev.com/3ceda53488f7cc8d72734247c6a5e11422c40ede/chrome/browser/chromeos/login/wizard_controller.h [modify] https://crrev.com/3ceda53488f7cc8d72734247c6a5e11422c40ede/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
Jacob, is there more to do here?
Let's move work to a new bug since this one is fairly old.
Comment 1 by bugdroid1@chromium.org
, Dec 7 2016