New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672138 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Crash in ImeController::CanCycleIme

Project Member Reported by ClusterFuzz, Dec 7 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5765974948315136

Fuzzer: meacer_chromebot_extensions
Job Type: linux_asan_chrome_chromeos
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x000000000000
Crash State:
  ImeController::CanCycleIme
  ash::AcceleratorController::AcceleratorPressed
  ui::AcceleratorManager::Process
  

Minimized Testcase (0.00 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96dc2WYUceJ4-BCGKIRhtmqI5NvjqSOd5dXx8WnCep5UpcoNY0kwNcGsfCu7NSXukYA4DN2XYjN8MHglblOsjuFW4gHQ1mKQdcroFZbqDypObjvHnzkbfqXW11UA56GxC8dDK_oxu31l8x2Z5TUL3BPD31FIQ?testcase_id=5765974948315136

Additional requirements: Requires Gestures

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: msrchandra@chromium.org
Labels: Test-Predator-Wrong-CLs
Owner: afakhry@chromium.org
Status: Assigned (was: Untriaged)
Unable to find the possible suspect using CL and find it.
Using Code Search for the file, "accelerator_controller.cc" assigning to the concern owner.

Suspecting Commit# 
https://chromium.googlesource.com/chromium/src/+/cd09f64d921e02333652d2fae387b8b406201cf8

@afakhry -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Cc: afakhry@chromium.org
Owner: shuchen@chromium.org
The CL in #1 is not related.

The crash happens here: https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/ime_controller_chromeos.cc?sq=package:chromium&type=cs&l=13

Not sure if the InputMethodManager or the InputMethodManager::State instances can be nulls.

Passing to the IME expert.
Labels: -OS-Linux OS-Chrome
Most likely the InputMethodManager::State instance is null.

The ActiveIMEState can only be null before InputMethodManager::SetState() is called.

Cc: shuchen@chromium.org
Owner: alemate@chromium.org
Most likely the InputMethodManager::State instance is null.

The ActiveIMEState can only be null before InputMethodManager::SetState() is called.
The early calls could be either ChromeBrowserMainPartsChromeos::PostProfileInit(), or UserSessionManager::InitializeUserSession().

+alemate@, do you think adding a null-check in ImeController::CanCycleIme is sufficient to fix this issue? Thanks.


Project Member

Comment 5 by ClusterFuzz, Jan 14 2017

ClusterFuzz has detected this issue as fixed in range 443393:443475.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5765974948315136

Fuzzer: meacer_chromebot_extensions
Job Type: linux_asan_chrome_chromeos
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x000000000000
Crash State:
  ImeController::CanCycleIme
  ash::AcceleratorController::AcceleratorPressed
  ui::AcceleratorManager::Process
  
Sanitizer: address (ASAN)

Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_chromeos&range=443393:443475

Minimized Testcase (0.00 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96dc2WYUceJ4-BCGKIRhtmqI5NvjqSOd5dXx8WnCep5UpcoNY0kwNcGsfCu7NSXukYA4DN2XYjN8MHglblOsjuFW4gHQ1mKQdcroFZbqDypObjvHnzkbfqXW11UA56GxC8dDK_oxu31l8x2Z5TUL3BPD31FIQ?testcase_id=5765974948315136

Additional requirements: Requires Gestures

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 6 by ClusterFuzz, Jan 14 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5765974948315136 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment