New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672116 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 671902
Owner:
Last visit 16 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

"AppMenuControllerTest.RecentTabsFavIcon" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Dec 7 2016

Issue description

"AppMenuControllerTest.RecentTabsFavIcon" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMgsSBUZsYWtlIidBcHBNZW51Q29udHJvbGxlclRlc3QuUmVjZW50VGFic0Zhdkljb24M.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by yosin@chromium.org, Dec 8 2016

Owner: mad@chromium.org
Status: Assigned (was: Untriaged)
mad@, could you take look?

[ RUN      ] AppMenuControllerTest.RecentTabsFavIcon
../../chrome/browser/ui/toolbar/recent_tabs_builder_test_helper.cc:227: Failure
Value of: delegate->GetAllForeignSessions(&sessions)
  Actual: false
Expected: true
../../chrome/browser/ui/cocoa/app_menu/app_menu_controller_unittest.mm:161: Failure
Value of: [recent_tabs_menu numberOfItems]
  Actual: 5
Expected: 6
[  FAILED  ] AppMenuControllerTest.RecentTabsFavIcon (247 ms)
[7432/7432] AppMenuControllerTest.RecentTabsFavIcon (247 ms)
Retrying 1 test (retry #2)
[81933:17411:1207/181930.784845:45504081727430:ERROR:kill_posix.cc(84)] Unable to terminate process group 82784: No such process
[ RUN      ] AppMenuControllerTest.RecentTabsFavIcon
../../chrome/browser/ui/toolbar/recent_tabs_builder_test_helper.cc:227: Failure
Value of: delegate->GetAllForeignSessions(&sessions)
  Actual: false
Expected: true
../../chrome/browser/ui/cocoa/app_menu/app_menu_controller_unittest.mm:161: Failure
Value of: [recent_tabs_menu numberOfItems]
  Actual: 5
Expected: 6
[  FAILED  ] AppMenuControllerTest.RecentTabsFavIcon (246 ms)
[7433/7433] AppMenuControllerTest.RecentTabsFavIcon (246 ms)
Retrying 1 test (retry #3)
[81933:15363:1207/181931.334586:45504631467424:ERROR:kill_posix.cc(84)] Unable to terminate process group 82785: No such process
[ RUN      ] AppMenuControllerTest.RecentTabsFavIcon
../../chrome/browser/ui/toolbar/recent_tabs_builder_test_helper.cc:227: Failure
Value of: delegate->GetAllForeignSessions(&sessions)
  Actual: false
Expected: true
../../chrome/browser/ui/cocoa/app_menu/app_menu_controller_unittest.mm:161: Failure
Value of: [recent_tabs_menu numberOfItems]
  Actual: 5
Expected: 6
[  FAILED  ] AppMenuControllerTest.RecentTabsFavIcon (253 ms)
[7434/7434] AppMenuControllerTest.RecentTabsFavIcon (253 ms)
1 test failed:
    AppMenuControllerTest.RecentTabsFavIcon (../../chrome/browser/ui/cocoa/app_menu/app_menu_controller_unittest.mm:141)
Tests took 74 seconds.

Comment 2 by treib@chromium.org, Dec 8 2016

Cc: zea@chromium.org
Labels: OS-Mac
This looks possibly related to  bug 671902 

Comment 3 by mad@chromium.org, Dec 8 2016

Mergedinto: 671902
Status: Duplicate (was: Assigned)
Yep, thanks zea@, I'll resolve as duplicate for now. Feel free to reopen if the fix to the other issue doesn't fix this test.

Sign in to add a comment