New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 672112 link

Starred by 1 user
Status: Fixed
Owner:
█ harkness@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

BudgetService.getBudget() resolves its promise with a sequence<>

Project Member Reported by peter@chromium.org, Dec 7 2016 
https://wicg.github.io/budget-api/#budget-service-interface

Our IDL file says it's a FrozenArray<>, but it actually should be a sequence<>. The implementation is fine, so there shouldn't be an observable difference.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/44433c83d095d50a6c46fa6a912156bfbfada092

commit 44433c83d095d50a6c46fa6a912156bfbfada092
Author: harkness <harkness@chromium.org>
Date: Tue Dec 13 11:35:49 2016

Updated the return of GetBudget to a sequence

The proposed spec for BudgetAPI defines the return value for getBudget
to be a Promise that resolves with a sequence<BudgetState> while the
current interface used a FrozenArray.

This patch updates the code to match the proposed spec. The implementation
works with either version, and this is covered by existing LayoutTests.

BUG= 672112 

Review-Url: https://codereview.chromium.org/2571573002
Cr-Commit-Position: refs/heads/master@{#438127}

[modify] https://crrev.com/44433c83d095d50a6c46fa6a912156bfbfada092/third_party/WebKit/Source/modules/budget/BudgetService.idl

Comment 2 by harkness@chromium.org, Dec 13 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment