New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 672111 link

Starred by 2 users
Status: Fixed
Owner:
█ harkness@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

The BudgetService interface needs to be exposed to both Window and Worker

Project Member Reported by peter@chromium.org, Dec 7 2016 
https://wicg.github.io/budget-api/#budget-service-interface

Today we expose it on the Window global (so you can feature detect in documents), but not on the Worker global. The specification uses the [Exposed] annotation for this.

Simple feature detection test:

  assert_true('BudgetService' in self);

Comment 1 by peter@chromium.org, Dec 7 2016 

This also goes for BudgetState:

https://wicg.github.io/budget-api/#budget-state-interface
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85999851912f7605181b68fd4c13ffc1ed9a86b0

commit 85999851912f7605181b68fd4c13ffc1ed9a86b0
Author: harkness <harkness@chromium.org>
Date: Tue Dec 13 19:05:48 2016

Expose the BudgetService interface to Workers.

The BudgetAPI proposed specification has the interface exposed in both document
and worker contexts. This patch adds worker exposure and makes the
document exposure explicit.

The patch adds testing for the new exposure, and also adds testing for all
interfaces in the budget implementation in service workers.

BUG= 672111 

Review-Url: https://codereview.chromium.org/2571453002
Cr-Commit-Position: refs/heads/master@{#438247}

[add] https://crrev.com/85999851912f7605181b68fd4c13ffc1ed9a86b0/third_party/WebKit/LayoutTests/http/tests/budget/interfaces-in-service-worker.html
[modify] https://crrev.com/85999851912f7605181b68fd4c13ffc1ed9a86b0/third_party/WebKit/LayoutTests/http/tests/budget/interfaces.html
[modify] https://crrev.com/85999851912f7605181b68fd4c13ffc1ed9a86b0/third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js
[modify] https://crrev.com/85999851912f7605181b68fd4c13ffc1ed9a86b0/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/85999851912f7605181b68fd4c13ffc1ed9a86b0/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/85999851912f7605181b68fd4c13ffc1ed9a86b0/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/85999851912f7605181b68fd4c13ffc1ed9a86b0/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/85999851912f7605181b68fd4c13ffc1ed9a86b0/third_party/WebKit/Source/modules/budget/BudgetService.idl
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d359e4eba14c07ef12c9567dfa1217f08632609c

commit d359e4eba14c07ef12c9567dfa1217f08632609c
Author: harkness <harkness@chromium.org>
Date: Wed Dec 14 13:07:38 2016

Expose BudgetState interface to Workers.

The proposed specification has the BudgetState interface exposed to
Workers. This brings the implementation in sync with that spec.

This also expands the interface tests to validate that the interface is
exposed.

BUG= 672111 

Review-Url: https://codereview.chromium.org/2578513002
Cr-Commit-Position: refs/heads/master@{#438497}

[modify] https://crrev.com/d359e4eba14c07ef12c9567dfa1217f08632609c/third_party/WebKit/LayoutTests/http/tests/budget/interfaces.html
[modify] https://crrev.com/d359e4eba14c07ef12c9567dfa1217f08632609c/third_party/WebKit/LayoutTests/http/tests/budget/resources/instrumentation-service-worker.js
[modify] https://crrev.com/d359e4eba14c07ef12c9567dfa1217f08632609c/third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/d359e4eba14c07ef12c9567dfa1217f08632609c/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/d359e4eba14c07ef12c9567dfa1217f08632609c/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/d359e4eba14c07ef12c9567dfa1217f08632609c/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/d359e4eba14c07ef12c9567dfa1217f08632609c/third_party/WebKit/Source/modules/budget/BudgetState.idl

Comment 4 by harkness@chromium.org, Dec 14 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment