New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672096 link

Starred by 0 users

Issue metadata

Status: Duplicate
Merged: issue 666472
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

custom headers don't work when upgrading from previous version

Reported by pdk...@gmail.com, Dec 7 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.18 Safari/537.36

Steps to reproduce the problem:
1. Use Chrome < 54.0.2833.0.
2. Change default columns in Network.
2. Upgrade to Chrome > 54.0.2833.0 on the same profile.

What is the expected behavior?
Custom headers can be added (or managed).

What went wrong?
Clicking the menu item causes an error.

"TypeError: Cannot read property 'toLowerCase' of undefined TypeError: Cannot read property 'toLowerCase' of undefined
    at columnData.forEach.columnData (chrome-devtools://devtools/bundled/network/network_module.js:568:5848)
    at Array.forEach (native)
    at Network.NetworkManageCustomHeadersView (chrome-devtools://devtools/bundled/network/network_module.js:568:5788)
    at Network.NetworkLogViewColumns._manageCustomHeaderDialog (chrome-devtools://devtools/bundled/network/network_module.js:547:25)
    at UI.ContextMenu._itemSelected (chrome-devtools://devtools/bundled/inspector.js:1642:20)
    at UI.ContextMenu._onItemSelected (chrome-devtools://devtools/bundled/inspector.js:1640:29)
    at Common.Object.dispatchEventToListeners (chrome-devtools://devtools/bundled/inspector.js:393:179)
    at innerDispatch (chrome-devtools://devtools/bundled/inspector.js:973:98)
    at InspectorFrontendAPIImpl._dispatch (chrome-devtools://devtools/bundled/inspector.js:973:1)
    at DevToolsAPIImpl._dispatchOnInspectorFrontendAPI (chrome-devtools://devtools/bundled/devtools_compatibility.js:57:36)", source: chrome-devtools://devtools/bundled/inspector.js (973)

Also notice that a bogus header has been added.

Did this work before? No 

Chrome version: 56.0.2924.18  Channel: dev
OS Version: 14.04
Flash Version:
 
Owner: allada@chromium.org
Status: Started (was: Unconfirmed)
Aaah, Yes this was from a rework of headers in network panel. Thanks for catching it before it went to stable!
Mergedinto: 666472
Status: Duplicate (was: Started)
After doing some research, it looks like it did land on stable, but the fix was here: https://codereview.chromium.org/2513733002. I have submitted it to be merged into beta.

If you wait a few days it should be fixed or if you need it now you can reset your devtools settings by going to devtools settings and click the button at the bottom to reload and reset.

Comment 3 by pdk...@gmail.com, Dec 7 2016

Restoring to defaults worked.

Sign in to add a comment