Public Session whitelisting - prompt the user for desktopCapture/tabCapture requests |
|||||||||||||||||||
Issue descriptionIn Public Sessions, extensions (and apps) are force-installed by admin policy so the user does not get a chance to review the permissions for these extensions. This is not acceptable from a security/privacy standpoint, so when an extension uses one of the capture APIs for the first time, we show the user a dialog where they can choose whether to allow the extension access to that API. ------------------------------------------------------------------- This bug is now for tracking only desktopCapture/tabCapture requests! pageCapture is tracked @ crbug.com/689478 (couldn't edit the bug title) -------------------------------------------------------------------
,
Dec 7 2016
Attaching a screenshot showcasing the new prompt for tabCapture requests.
,
Dec 12 2016
,
Dec 12 2016
Attaching screenshot for new prompt for pageCapture requests.
,
Dec 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f9314626715713912e784d10ada39770fa80c1f commit 1f9314626715713912e784d10ada39770fa80c1f Author: isandrk <isandrk@chromium.org> Date: Wed Dec 14 19:36:46 2016 Public Sessions - prompt the user for tabCapture requests In Public Sessions, extensions (and apps) are force-installed by admin policy so the user does not get a chance to review the permissions for these extensions. This is not acceptable from a security/privacy standpoint, so when an extension uses the TabCapture API for the first time, we show the user a dialog where they can choose whether to allow the extension access to the API. This CL will also whitelist desktopCapture manifest permission feature as it's already safe in its current form (user is prompted) together with tabCapture. BUG= 672093 Review-Url: https://codereview.chromium.org/2558843002 Cr-Commit-Position: refs/heads/master@{#438594} [modify] https://crrev.com/1f9314626715713912e784d10ada39770fa80c1f/chrome/browser/BUILD.gn [modify] https://crrev.com/1f9314626715713912e784d10ada39770fa80c1f/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc [modify] https://crrev.com/1f9314626715713912e784d10ada39770fa80c1f/chrome/browser/media/webrtc/media_capture_devices_dispatcher.cc [add] https://crrev.com/1f9314626715713912e784d10ada39770fa80c1f/chrome/browser/media/webrtc/public_session_tab_capture_access_handler.cc [add] https://crrev.com/1f9314626715713912e784d10ada39770fa80c1f/chrome/browser/media/webrtc/public_session_tab_capture_access_handler.h
,
Feb 1 2017
@Ivan, Is this ready to test on R57. If yes, could you please update the status to Fixed. @sduraisamy, Could we please request for a Privacy Review and an Accessibility Review for this.
,
Feb 1 2017
@Krishna: not yet, one more CL needs to land.
,
Feb 1 2017
,
Feb 1 2017
,
Feb 3 2017
Greg - here's a one off review.
,
Feb 7 2017
So I've split off a part of this bug to crbug.com/689478 (pageCapture). This bug is now for tracking only desktopCapture/tabCapture requests. I'd update the title of this bug as well, but I'm unsure how. @Krishna, ready for testing on R57.
,
Feb 7 2017
,
Feb 7 2017
,
Feb 7 2017
,
Feb 7 2017
,
Feb 7 2017
,
Feb 7 2017
,
Feb 17 2017
Tested this on R58(9287.0.0). verified that extensions that request for desktopCapture and tabCapture can be whitelisted in Public Sessions and that the corresponding prompts requesting USer permissions are being requested.
,
Feb 17 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 17 2017
This has been commited before the branching point for M57 therefore it's already in it. Removing Merge-Request flag. Thanks for reviewing Krishna!
,
Feb 24 2017
Sorry for the late response. I'm assuming that no new data is collected anywhere in this feature, except perhaps for recording the user's selection in this dialog? If not, this looks fine from a privacy standpoint.
,
Feb 24 2017
Greg: Correct, only the user selection is recorded.
,
May 22 2017
,
Aug 1 2017
,
Jan 22 2018
|
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by isandrk@chromium.org
, Dec 7 2016254 KB
254 KB View Download