New issue
Advanced search Search tips

Issue 672090 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 753184



Sign in to add a comment

Include isolated cache hit rate in Swarming Task UI

Project Member Reported by kjlubick@google.com, Dec 7 2016

Issue description

Old ui has:
Task inputs: Hot items	10.8 MB total; 360 items; (0 Bytes; 1 Byte; 2 Bytes; 14 Bytes; 23 Bytes; ...; 421.0 kB; 479.2 kB; 625.8 kB; 639.6 kB; 2.2 MB)
Task inputs: Cold items (i.e. downloaded)	149.8 MB total; 6 items; (421 Bytes; 580 Bytes; 27.1 MB; 29.1 MB; 43.3 MB; 50.3 MB)
Task results: Hot items	‑‑
Task results: Cold items (i.e. uploaded)	‑‑

New UI should at least have the total items.  
 
This is already included in the request, just zlib compressed and base64 encoded.  I think a better approach would be able to decode this client side, create the shortened version and have the number of items and size and send that instead of the compressed/encoded bit.

Comment 2 by kjlubick@google.com, Jul 25 2017

Components: Infra>Platform>Swarming>WebUI

Comment 3 by kjlubick@google.com, Jul 25 2017

Components: -Infra>Platform>Swarming

Comment 4 by mar...@chromium.org, Aug 10 2017

Cc: dpranke@chromium.org
Labels: -Type-Bug Type-Feature
Summary: Include isolated cache hit rate in Swarming Task UI (was: Include more results in performance stats on Swarming UI)
This code has to be translated into javascript, including zlib decompression (which can be done with pako):
https://chromium.googlesource.com/infra/luci/luci-py/+/master/client/utils/large.py#46

It'd be useful to diagnose overhead.

To get this data, the request must include &include_performance_stats=true

Showing totals for each items_cold / items_hot in both number of files and total sizes; then add the full list on hover or something but it's really the totals that are generally useful.
Cc: jbudorick@chromium.org bpastene@chromium.org
bpastene, jbudorick, fyi ...
Blocking: 753184

Comment 7 by kjlubick@google.com, Aug 10 2017

Labels: -Pri-3 Pri-2
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Aug 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/5561f051f72027fc96deb938c57515096c82472e

commit 5561f051f72027fc96deb938c57515096c82472e
Author: Kevin Lubick <kjlubick@google.com>
Date: Fri Aug 11 12:03:38 2017

Add cache summary to Swarming UI

Bug:672090
Change-Id: Ie416c8d77d8e36995e9dfb5859c9ba18eb9a96af
Reviewed-on: https://chromium-review.googlesource.com/611023
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Kevin Lubick <kjlubick@chromium.org>

[modify] https://crrev.com/5561f051f72027fc96deb938c57515096c82472e/appengine/swarming/ui/build/elements.html
[modify] https://crrev.com/5561f051f72027fc96deb938c57515096c82472e/appengine/swarming/ui/res/imp/taskpage/task-page.html

This is live in chrome-swarm and chromium-swarming
Status: Fixed (was: Started)

Sign in to add a comment