Include isolated cache hit rate in Swarming Task UI |
||||||||
Issue descriptionOld ui has: Task inputs: Hot items 10.8 MB total; 360 items; (0 Bytes; 1 Byte; 2 Bytes; 14 Bytes; 23 Bytes; ...; 421.0 kB; 479.2 kB; 625.8 kB; 639.6 kB; 2.2 MB) Task inputs: Cold items (i.e. downloaded) 149.8 MB total; 6 items; (421 Bytes; 580 Bytes; 27.1 MB; 29.1 MB; 43.3 MB; 50.3 MB) Task results: Hot items ‑‑ Task results: Cold items (i.e. uploaded) ‑‑ New UI should at least have the total items.
,
Jul 25 2017
,
Jul 25 2017
,
Aug 10 2017
This code has to be translated into javascript, including zlib decompression (which can be done with pako): https://chromium.googlesource.com/infra/luci/luci-py/+/master/client/utils/large.py#46 It'd be useful to diagnose overhead. To get this data, the request must include &include_performance_stats=true Showing totals for each items_cold / items_hot in both number of files and total sizes; then add the full list on hover or something but it's really the totals that are generally useful.
,
Aug 10 2017
bpastene, jbudorick, fyi ...
,
Aug 10 2017
,
Aug 10 2017
,
Aug 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/f9b80e13eb1b189c52eba5dc757d2cd98d52a9f7 commit f9b80e13eb1b189c52eba5dc757d2cd98d52a9f7 Author: Marc-Antoine Ruel <maruel@chromium.org> Date: Thu Aug 10 17:20:45 2017 swarming: add precalculated values for cache hit rate. This removes the need from decompressing the flate'd stream just to get the number of items and the sum. Edit test expectations to add more variance. R=kjlubick@chromium.org BUG= 672090 Change-Id: I120dffb7a0d2c536027f081fa43db1e67653c4af Reviewed-on: https://chromium-review.googlesource.com/610442 Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by: Kevin Lubick <kjlubick@chromium.org> [modify] https://crrev.com/f9b80e13eb1b189c52eba5dc757d2cd98d52a9f7/appengine/swarming/handlers_endpoints_test.py [modify] https://crrev.com/f9b80e13eb1b189c52eba5dc757d2cd98d52a9f7/appengine/swarming/local_smoke_test.py [modify] https://crrev.com/f9b80e13eb1b189c52eba5dc757d2cd98d52a9f7/appengine/swarming/server/task_result.py [modify] https://crrev.com/f9b80e13eb1b189c52eba5dc757d2cd98d52a9f7/appengine/swarming/server/task_result_test.py [modify] https://crrev.com/f9b80e13eb1b189c52eba5dc757d2cd98d52a9f7/appengine/swarming/swarming_rpcs.py [modify] https://crrev.com/f9b80e13eb1b189c52eba5dc757d2cd98d52a9f7/appengine/swarming/test_env_handlers.py
,
Aug 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/5561f051f72027fc96deb938c57515096c82472e commit 5561f051f72027fc96deb938c57515096c82472e Author: Kevin Lubick <kjlubick@google.com> Date: Fri Aug 11 12:03:38 2017 Add cache summary to Swarming UI Bug:672090 Change-Id: Ie416c8d77d8e36995e9dfb5859c9ba18eb9a96af Reviewed-on: https://chromium-review.googlesource.com/611023 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Kevin Lubick <kjlubick@chromium.org> [modify] https://crrev.com/5561f051f72027fc96deb938c57515096c82472e/appengine/swarming/ui/build/elements.html [modify] https://crrev.com/5561f051f72027fc96deb938c57515096c82472e/appengine/swarming/ui/res/imp/taskpage/task-page.html
,
Aug 11 2017
This is live in chrome-swarm and chromium-swarming
,
Aug 11 2017
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by kjlubick@google.com
, Dec 7 2016