New issue
Advanced search Search tips

Issue 672062 link

Starred by 1 user

Issue metadata

Status: Archived
Owner: ----
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

mus_ws_unittests don't run on linux_chromium_chromeos_ozone_rel_ng

Project Member Reported by kylec...@chromium.org, Dec 7 2016

Issue description

The mus_ws_unittests really need to run on Ozone Chrome OS, either with --ozone-platform=headless or --ozone-platform=x11.

It doesn't run on X11 Chrome OS trybot either but that configuration doesn't need to be supported. It only runs on Linux/Windows trybots.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf2516c642ad1906dd6d229b4753f72a6af389a7

commit cf2516c642ad1906dd6d229b4753f72a6af389a7
Author: kylechar <kylechar@chromium.org>
Date: Thu Dec 08 16:29:49 2016

Add mus_ws_unittests to Ozone CrOS trybot.

It looks like this test was never running on any CrOS trybots, only
Windows and Linux.

BUG= 672062 

Review-Url: https://codereview.chromium.org/2565453002
Cr-Commit-Position: refs/heads/master@{#437260}

[modify] https://crrev.com/cf2516c642ad1906dd6d229b4753f72a6af389a7/testing/buildbot/chromium.chromiumos.json

Status: Fixed (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/033d9e89ed5ce8b5ee20d7a5d56256c0038fd9f5

commit 033d9e89ed5ce8b5ee20d7a5d56256c0038fd9f5
Author: fsamuel <fsamuel@chromium.org>
Date: Fri Feb 10 03:30:29 2017

Retain references to surfaces from both active AND pending CompositorFrames

A Surface may hold both an active and a pending CompositorFrame at once.
Surfaces referenced by either CompositorFrame must be retained in order
to ensure correctness once the pending frame is activated. This CL
tracks references from both pending and active CompositorFrames within
a surface.

This CL also fixes a tear down issue in SurfaceDependencyTracker where Surfaces
could continue to call back into SurfaceDependencyTracker after it was
destroyed. SurfaceDependencyTracker stops observing Surfaces in its destructor.

BUG= 672062 
TBR=jam@chromium.org for mechanical renaming in content/
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2688043002
Cr-Commit-Position: refs/heads/master@{#449543}

[modify] https://crrev.com/033d9e89ed5ce8b5ee20d7a5d56256c0038fd9f5/cc/surfaces/compositor_frame_sink_support.cc
[modify] https://crrev.com/033d9e89ed5ce8b5ee20d7a5d56256c0038fd9f5/cc/surfaces/compositor_frame_sink_support.h
[modify] https://crrev.com/033d9e89ed5ce8b5ee20d7a5d56256c0038fd9f5/cc/surfaces/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/033d9e89ed5ce8b5ee20d7a5d56256c0038fd9f5/cc/surfaces/surface.cc
[modify] https://crrev.com/033d9e89ed5ce8b5ee20d7a5d56256c0038fd9f5/cc/surfaces/surface.h
[modify] https://crrev.com/033d9e89ed5ce8b5ee20d7a5d56256c0038fd9f5/cc/surfaces/surface_dependency_tracker.cc
[modify] https://crrev.com/033d9e89ed5ce8b5ee20d7a5d56256c0038fd9f5/cc/surfaces/surface_manager.cc
[modify] https://crrev.com/033d9e89ed5ce8b5ee20d7a5d56256c0038fd9f5/content/public/test/browser_test_utils.cc
[modify] https://crrev.com/033d9e89ed5ce8b5ee20d7a5d56256c0038fd9f5/content/test/content_browser_test_utils_internal.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d87c3aad9d1276390112859ec0f6a4b3ca89adc

commit 5d87c3aad9d1276390112859ec0f6a4b3ca89adc
Author: fsamuel <fsamuel@chromium.org>
Date: Fri Feb 10 22:44:01 2017

Surfaces: Receive resources only once

ResourceRefs tracks the number of refs for a resource received from a
parent so that it can send back the same refs when the resource is no
longer used by the display compositor. Prior to this CL, we were
calling ReceiveRefs when a CompositorFrame is marked as pending and
again when it was activated. This causes us to doubly returns refs to
the client.

This CL calls ReceiveFromChild only once on Surface::QueueFrame (when
the frame is first received), and does not update the refs when a frame
goes from pending to active. If a pending or active frame is overwritten
refs are still returned.

BUG= 672062 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2689563005
Cr-Commit-Position: refs/heads/master@{#449770}

[modify] https://crrev.com/5d87c3aad9d1276390112859ec0f6a4b3ca89adc/cc/resources/returned_resource.h
[modify] https://crrev.com/5d87c3aad9d1276390112859ec0f6a4b3ca89adc/cc/surfaces/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/5d87c3aad9d1276390112859ec0f6a4b3ca89adc/cc/surfaces/surface.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/adb877a00fb19240fd50186c21bcc2b790446805

commit adb877a00fb19240fd50186c21bcc2b790446805
Author: fsamuel <fsamuel@chromium.org>
Date: Sat Feb 11 17:20:10 2017

Surfaces: Allow parent to refer to child surfaces that don't exist yet.

With the introduction of direct client-to-client resize and surface
synchronization, the parent may submit a CompositorFrame referring to
a child that does not yet exist. This should be OK. There will be a
dangling reference for a little while but eventually it will either
resolve, or the parent is malicious and will be killed and its entire
subtree will be reclaimed.

If the child submits a CompositorFrame for the first time and there's
already a reference to it hanging off the parent then we should not
add a temporary reference hanging off the root.

This CL tests that both cases are handled.

BUG= 672062 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2685393003
Cr-Commit-Position: refs/heads/master@{#449870}

[modify] https://crrev.com/adb877a00fb19240fd50186c21bcc2b790446805/cc/surfaces/compositor_frame_sink_support_unittest.cc
[modify] https://crrev.com/adb877a00fb19240fd50186c21bcc2b790446805/cc/surfaces/surface_manager.cc
[modify] https://crrev.com/adb877a00fb19240fd50186c21bcc2b790446805/cc/surfaces/surface_manager.h
[modify] https://crrev.com/adb877a00fb19240fd50186c21bcc2b790446805/cc/surfaces/surface_manager_ref_unittest.cc

Comment 6 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 7 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 8 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 10 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)

Sign in to add a comment