Non android bots running media.android.* tests |
|||
Issue description
,
Dec 7 2016
,
Dec 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/712589ccc92e49a9c69b25bdf2c60f0d64950569 commit 712589ccc92e49a9c69b25bdf2c60f0d64950569 Author: rnephew <rnephew@chromium.org> Date: Wed Dec 07 20:51:34 2016 [Telemetry] Disable android media test on non android platforms. BUG= 672059 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Review-Url: https://codereview.chromium.org/2558893002 Cr-Commit-Position: refs/heads/master@{#437054} [modify] https://crrev.com/712589ccc92e49a9c69b25bdf2c60f0d64950569/tools/perf/benchmarks/media.py
,
Dec 20 2016
Filed a telemetry bug for the underlying decorator issues: https://github.com/catapult-project/catapult/issues/3102 |
|||
►
Sign in to add a comment |
|||
Comment 1 by rnep...@chromium.org
, Dec 7 2016@benchmark.Enabled('android') @benchmark.Disabled('l', 'android-webview') # WebView: crbug.com/419689 class MediaAndroid(perf_benchmark.PerfBenchmark): """Obtains media metrics for key user scenarios on Android.""" test = media.Media tag = 'android' page_set = page_sets.ToughVideoCasesPageSet # Exclude is_4k and 50 fps media files (garden* & crowd*). options = {'story_label_filter_exclude': 'is_4k,is_50fps'} @classmethod def ShouldDisable(cls, possible_browser): # crbug.com/448092 if cls.IsSvelte(possible_browser): return True # crbug.com/647372 if possible_browser.platform.GetDeviceTypeName() == 'Nexus 5X': return True return False @classmethod def Name(cls): return 'media.android.tough_video_cases' I think the problem is the interaction between @benchmark.Enable and @benchmark.Disable; but I may be wrong.