New issue
Advanced search Search tips

Issue 672055 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Incorrect handling of 'visibility' in <mask>s

Project Member Reported by f...@opera.com, Dec 7 2016

Issue description

We will prune containers with visibility != visible with considering their (potential) children.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51a75fa55ba71462963ddcf085995cf3eca66104

commit 51a75fa55ba71462963ddcf085995cf3eca66104
Author: fs <fs@opera.com>
Date: Wed Dec 07 17:45:36 2016

Don't check 'visibility' in LayoutSVGResourceMasker

Since 'visibility' does not work in the same way as 'display', it's not
possible to "prune" subtrees based on non-'visible' values of the
property. Remove the check from the two methods that use it, and leave
to lower levels to handle it.

BUG= 672055 

Review-Url: https://codereview.chromium.org/2558793002
Cr-Commit-Position: refs/heads/master@{#436996}

[add] https://crrev.com/51a75fa55ba71462963ddcf085995cf3eca66104/third_party/WebKit/LayoutTests/svg/masking/mask-with-visibility-hidden-group-expected.html
[add] https://crrev.com/51a75fa55ba71462963ddcf085995cf3eca66104/third_party/WebKit/LayoutTests/svg/masking/mask-with-visibility-hidden-group.html
[modify] https://crrev.com/51a75fa55ba71462963ddcf085995cf3eca66104/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceMasker.cpp

Comment 2 by f...@opera.com, Dec 7 2016

Status: Fixed (was: Assigned)

Sign in to add a comment