New issue
Advanced search Search tips

Issue 672038 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Many serviceworker layout tests are flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Dec 7 2016

Issue description

"http/tests/serviceworker/chromium/register-error-messages.html" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNySQsSBUZsYWtlIj5odHRwL3Rlc3RzL3NlcnZpY2V3b3JrZXIvY2hyb21pdW0vcmVnaXN0ZXItZXJyb3ItbWVzc2FnZXMuaHRtbAw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by treib@chromium.org, Dec 7 2016

Cc: horo@chromium.org
Owner: falken@chromium.org
Status: Assigned (was: Untriaged)
Over to folks who have been working on service worker things. Could you please take a look and/or help triage? Thanks!

Comment 2 by horo@chromium.org, Dec 8 2016

Components: Blink>ServiceWorker

Comment 3 by horo@chromium.org, Dec 8 2016

Cc: falken@chromium.org
 Issue 672013  has been merged into this issue.

Comment 4 by treib@chromium.org, Dec 8 2016

 Issue 672143  has been merged into this issue.

Comment 5 by treib@chromium.org, Dec 8 2016

 Issue 672270  has been merged into this issue.

Comment 6 by treib@chromium.org, Dec 8 2016

 Issue 672078  has been merged into this issue.

Comment 7 by treib@chromium.org, Dec 8 2016

Summary: Many serviceworker layout tests are flaky (was: "http/tests/serviceworker/chromium/register-error-messages.html" is flaky)
List of failing tests:
http/tests/serviceworker/chromium/register-error-messages.html
virtual/mojo-loading/http/tests/serviceworker/chromium/register-error-messages.html
http/tests/serviceworker/register-link-element.html
virtual/service-worker-navigation-preload/http/tests/serviceworker/chromium/register-error-messages.html
virtual/mojo-loading/http/tests/serviceworker/registration.html

Comment 8 by treib@chromium.org, Dec 8 2016

One related revert, which does not seem to have helped: https://codereview.chromium.org/2557433005/

Comment 9 by treib@chromium.org, Dec 8 2016

Labels: -Pri-1 -Sheriff-Chromium Pri-2
Huh, or maybe it has helped after all - none of the failures have occurred again after the original 3 instances. Accordingly, lowering prio and removing from the sheriff queue. (Please add it back in case the failures reappear!)
Owner: carlosk@chromium.org
Status: Fixed (was: Assigned)
Looks like this was fixed by https://chromium.googlesource.com/chromium/src/+/ab650bf37d14c76a794fe42f7cd0739dc01b752a
Cc: carlosk@chromium.org
Owner: mmenke@chromium.org
As all I did was a revert, changing ownership to mmenke@ who created the original change.

Sign in to add a comment