New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 672012 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocked on:
issue 668141

Blocking:
issue 666647



Sign in to add a comment

Move PhysicalWebPageSuggestionsProvider to new data source interface

Project Member Reported by vitaliii@chromium.org, Dec 7 2016

Issue description

Currently we are using ListValue interface, but we should use struct instead.
 
Status: Fixed (was: Assigned)
Cc: mattreynolds@chromium.org
Hi mattreynolds@,

I need to do a merge for issue 685245 (https://codereview.chromium.org/2669533002) into M57 (branch 2987) and this CL is needed for that one. Do you have any concerns with me merging it? So far it fits without any conflicts.
Labels: Merge-Request-57
No concerns, I added the MR flag.
Project Member

Comment 5 by sheriffbot@chromium.org, Feb 3 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 6 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b35ede154158d7ce3e9f25c11f6a96e85b2ea29

commit 5b35ede154158d7ce3e9f25c11f6a96e85b2ea29
Author: Vitalii Iarko <vitaliii@chromium.org>
Date: Mon Feb 06 12:10:33 2017

Merge of "Replace deprecated calls to GetMetadata in Zine provider."

This is a merge of https://codereview.chromium.org/2643453002 into M57
(branch 2987). This CL is needed in order to merge
https://codereview.chromium.org/2669533002 into the same branch.

Original description:
Use GetMetadataList instead of GetMetadata, which is now deprecated.

BUG= 672012 ,685245

Review-Url: https://codereview.chromium.org/2643453002
Cr-Commit-Position: refs/heads/master@{#445113}
(cherry picked from commit e11c34fb2c29ea47003a20391f0c7222b14b1e13)

Review-Url: https://codereview.chromium.org/2677983002 .
Cr-Commit-Position: refs/branch-heads/2987@{#319}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/5b35ede154158d7ce3e9f25c11f6a96e85b2ea29/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc
[modify] https://crrev.com/5b35ede154158d7ce3e9f25c11f6a96e85b2ea29/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h
[modify] https://crrev.com/5b35ede154158d7ce3e9f25c11f6a96e85b2ea29/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider_unittest.cc
[modify] https://crrev.com/5b35ede154158d7ce3e9f25c11f6a96e85b2ea29/components/physical_web/data_source/fake_physical_web_data_source.cc
[modify] https://crrev.com/5b35ede154158d7ce3e9f25c11f6a96e85b2ea29/components/physical_web/data_source/fake_physical_web_data_source.h

Sign in to add a comment