New issue
Advanced search Search tips

Issue 672003 link

Starred by 1 user
Status: Archived
Owner:
koten...@yandex-team.ru
Closed: Sep 17
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Wrong match ordinal on websites with endless scrolling

Project Member Reported by koten...@yandex-team.ru, Dec 7 2016 
Chrome Version: 57.0.2944.0
OS: OSX 10.12.1, Win 7, other desktop most likely

What steps will reproduce the problem?
(1) Navigate to a site with endless scrolling, for example http://mrzykmoriceau.tumblr.com/
(2) On the mentioned page, in-page search for "notes", 15 entries are found on my computer.
(3) Jump to the last match via the find in page box using enter or "next" button, the ordinal should be 15/15.
(4) The website should load the next page that contains more entries of the search pattern.
(5) Hit enter or "next" button again.

What is the expected result?
The ordinal should be 16/30

What happens instead?
The ordinal is wrong, 3/30 on my computer, but it depends on the configuration.

Comment 1 by koten...@yandex-team.ru, Dec 7 2016 

The actual problem does not require the endless scrolling, the following conditions should be met:
- there should be at least one entry of the search pattern before the js update;
- the text should be added with javascript after the search is started and it should contain the search pattern;
- there should be enough text that the added entry won't be found during the first scopeStringMatches() call.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9eaa9c7c71d2006397954a8b731b631db8576cf

commit e9eaa9c7c71d2006397954a8b731b631db8576cf
Author: kotenkov <kotenkov@yandex-team.ru>
Date: Fri Dec 09 08:50:34 2016

FindInPage: fix wrong match ordinal after javascript update.

BUG= 672003 
TEST=ParameterizedWebFrameTest.FindInPageJavaScriptUpdatesDOMProperOrdinal

Review-Url: https://codereview.chromium.org/2548253005
Cr-Commit-Position: refs/heads/master@{#437498}

[modify] https://crrev.com/e9eaa9c7c71d2006397954a8b731b631db8576cf/third_party/WebKit/Source/web/TextFinder.cpp
[modify] https://crrev.com/e9eaa9c7c71d2006397954a8b731b631db8576cf/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Comment 3 by markchang@chromium.org, Sep 17

Status: Archived (was: Started)
Archiving old bugs that have only received trivial updates for some time.

If you feel this issue should still be addressed, feel free to reopen it or to file a new issue. Thanks!
►

Sign in to add a comment