New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 671987 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Non-Regression : Unnecessary Highlight on Zip file name is seen while selecting Icon in Files App

Project Member Reported by mmanchala@chromium.org, Dec 7 2016

Issue description

Chrome Version: 56.0.2924.18/9000.19.0 dev-channel Jerry,Peppy,Candy and Daisy
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Download images
(2)Now go to Files App -> Select one Image and Zip it-> Now open the Zip File 
(3)Now long press on the Icon beside the opened Zip file name and observe Unnecessary Highlight on Zip file name   (Please refer Video)

Expected: Highlight should be seen only on Icon
Actual: Instead Unnecessary Highlight on Zip file name is seen

This is Non-Regression Issue seen from M-54

@mtomasz: Please confirm the issue.

 
Actual_Highlight.webm
616 KB View Download
Actual_Highlight.jpg
32.8 KB View Download
Labels: -m-56
Labels: from-mtomasz
Cc: mtomasz@chromium.org
Owner: fukino@chromium.org

Comment 4 by sashab@chromium.org, Feb 22 2018

Labels: CrOS-FilesApp-Zip
Owner: ----
Status: Unconfirmed (was: Assigned)

Comment 6 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-Zip CrOSFilesFeature-Zip

Comment 7 by dats@google.com, Mar 19 2018

Labels: -Pri-2 CrOSFilesFeature-ExternalMedia CrOSFilesCategory-UI Pri-3
Status: Untriaged (was: Unconfirmed)
This happens with any removable media.
Status: Available (was: Untriaged)
Postpone until launch of zip archiver to confirm.
Labels: Files-Fixit-2018
Owner: sa...@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 11 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13921a60bdc0e2f2fb7364cf03266f2108601a27

commit 13921a60bdc0e2f2fb7364cf03266f2108601a27
Author: Sam McNally <sammc@chromium.org>
Date: Tue Nov 20 09:16:18 2018

Stop propagation of up and down events from eject buttons.

The paper-ripple elements use up and down events to decide whether to
render a ripple. Allowing these events to propagate through the eject
button causes both the button and the directory tree item to ripple,
instead of just the eject button.

Bug:  671987 
Change-Id: I3fb9f6c1c1f1694810a497f967ec73378ba0e223
Reviewed-on: https://chromium-review.googlesource.com/c/1343871
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609636}
[modify] https://crrev.com/13921a60bdc0e2f2fb7364cf03266f2108601a27/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

Status: Fixed (was: Assigned)

Sign in to add a comment