New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 671979 link

Starred by 1 user
Status: Fixed
Owner:
jkrcal@chromium.org
Closed: Dec 2016
Cc:
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 645917



Sign in to add a comment

Missing support for getting types values of variation parameters

Project Member Reported by jkrcal@chromium.org, Dec 7 2016 
The common work-flow for code using variation parameters is adding local functions for parsing variation parameters.

There should be some central functions to do the job for main data types.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5dd68d3f4af51d51ceed869058b0d639ebe2797

commit d5dd68d3f4af51d51ceed869058b0d639ebe2797
Author: jkrcal <jkrcal@chromium.org>
Date: Fri Dec 09 07:44:21 2016

Add generic functions for getting typed variation parameter values

This CL introduces generic functions for parsing variation parameters
into int, double, and bool (internally, variation parameters are
represented by a string).

The CL replaces some functions emulating this functionality in
ntp_snippets by the new ones in variations. More clean-up in
ntp_snippets is needed, left for further CLs.

BUG= 671979 

Review-Url: https://codereview.chromium.org/2558743003
Cr-Commit-Position: refs/heads/master@{#437491}

[modify] https://crrev.com/d5dd68d3f4af51d51ceed869058b0d639ebe2797/chrome/browser/ntp_snippets/download_suggestions_provider.cc
[modify] https://crrev.com/d5dd68d3f4af51d51ceed869058b0d639ebe2797/components/ntp_snippets/bookmarks/bookmark_suggestions_provider.cc
[modify] https://crrev.com/d5dd68d3f4af51d51ceed869058b0d639ebe2797/components/ntp_snippets/features.cc
[modify] https://crrev.com/d5dd68d3f4af51d51ceed869058b0d639ebe2797/components/ntp_snippets/features.h
[modify] https://crrev.com/d5dd68d3f4af51d51ceed869058b0d639ebe2797/components/ntp_snippets/offline_pages/recent_tab_suggestions_provider.cc
[add] https://crrev.com/d5dd68d3f4af51d51ceed869058b0d639ebe2797/components/ntp_snippets/remote/remote_suggestions_hard_scheduler.h
[add] https://crrev.com/d5dd68d3f4af51d51ceed869058b0d639ebe2797/components/ntp_snippets/remote/remote_suggestions_scheduler.h
[modify] https://crrev.com/d5dd68d3f4af51d51ceed869058b0d639ebe2797/components/ntp_snippets/sessions/foreign_sessions_suggestions_provider.cc
[modify] https://crrev.com/d5dd68d3f4af51d51ceed869058b0d639ebe2797/components/ntp_snippets/user_classifier.cc
[modify] https://crrev.com/d5dd68d3f4af51d51ceed869058b0d639ebe2797/components/variations/variations_associated_data.cc
[modify] https://crrev.com/d5dd68d3f4af51d51ceed869058b0d639ebe2797/components/variations/variations_associated_data.h
[modify] https://crrev.com/d5dd68d3f4af51d51ceed869058b0d639ebe2797/components/variations/variations_associated_data_unittest.cc

Comment 2 by jkrcal@chromium.org, Dec 19 2016

Status: Fixed (was: Started)

Comment 3 by jkrcal@chromium.org, Dec 19 2016

Blocking: 645917
►

Sign in to add a comment