New issue
Advanced search Search tips

Issue 671966 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 3
Type: Bug



Sign in to add a comment

[Password Manager] Save prompt after failed login on donorschoose.org

Project Member Reported by kolos@chromium.org, Dec 7 2016 
What steps will reproduce the problem?
(1) Go to secure.donorschoose.org (make sure that it is not www.donorschoose.org)
(2) Go to the signin form.
(3) Enter wrong credentials.
(4) Press "Sign In"

What is the expected result?
Chrome must not offer to save the password. 

What happens instead?
Chrome offers to save the password.
Screenshot from 2016-12-07 10:08:38.png
64.4 KB View Download

Comment 1 by kolos@chromium.org, Dec 7 2016 

Preliminary investigation shows the following. To check if the login form is still exists (i.e. the login has failed or not), PasswordManager receives OnPasswordFormsRendered notifications from PasswordAutofillAgent. 

In this case, PasswordAutofillAgent sent several notifications to PasswordManager. One of them had empty list of forms which means successful login. Another notification had a form. The first one caused false save prompt.

PasswordManager must receive only one OnPasswordFormsRendered message or must make a decision about successful/failed login when all messages have been received.

Comment 2 by vabr@chromium.org, Dec 8 2016

Labels: Hotlist-Polish
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 11 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by kolos@chromium.org, Jan 9 2018

Status: Fixed (was: Untriaged)
Tested in M63. It doesn't prompt in case of wrong credentials.
►

Sign in to add a comment