New issue
Advanced search Search tips

Issue 671958 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature

Blocking:
issue 668951



Sign in to add a comment

Apply recent spec changes to WritableStream

Project Member Reported by ricea@chromium.org, Dec 7 2016

Issue description

https://github.com/whatwg/streams/pull/621 is needed to stop the pipe/close-propagation-backward.js test 'Closing must be propagated backward: starts closed; preventCancel = true, preventAbort = true' from crashing. Probably some others too.

https://github.com/whatwg/streams/commit/0745219ca7b7f02ef104145b78ebebd99c0fd12c is important to eliminate console errors and future test failures (also applies to ReadableStream).

https://github.com/whatwg/streams/pull/619 contains important semantic changes that should be included before shipping.

https://github.com/whatwg/streams/pull/626 will be an important bugfix once it is landed upstream.
 
Owner: domenic@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2d69d55423fa357963f4e5bbaf8b5ab44075a340

commit 2d69d55423fa357963f4e5bbaf8b5ab44075a340
Author: domenic <domenic@chromium.org>
Date: Fri Jan 06 17:59:15 2017

Update writable streams for the latest spec changes

This incorporates the spec and test changes at:

- https://github.com/whatwg/streams/commit/0745219ca7b7f02ef104145b78ebebd99c0fd12c
- https://github.com/whatwg/streams/commit/872188a984722861020ae773a5ee558892797c33
- https://github.com/whatwg/streams/commit/591a6eda9ea0b84881a370519d6aca53fab9e256
- https://github.com/whatwg/streams/commit/551489c68d1f9c582a3a7334fbb88a85500d5867
- https://github.com/whatwg/streams/commit/68aa48c5e463bdc15c43944cd561ce6fcec5441c
- https://github.com/whatwg/streams/commit/43c4b00d440b3c391a48fb761c3967c2e77d6cd1
- https://github.com/whatwg/streams/commit/22b3f03bf803868bf65d9b57f862cc7e3cc80188

BUG= 671958 

Review-Url: https://codereview.chromium.org/2596883002
Cr-Commit-Position: refs/heads/master@{#441974}

[modify] https://crrev.com/2d69d55423fa357963f4e5bbaf8b5ab44075a340/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/aborting.js
[modify] https://crrev.com/2d69d55423fa357963f4e5bbaf8b5ab44075a340/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/close.js
[modify] https://crrev.com/2d69d55423fa357963f4e5bbaf8b5ab44075a340/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/constructor.js
[modify] https://crrev.com/2d69d55423fa357963f4e5bbaf8b5ab44075a340/third_party/WebKit/LayoutTests/http/tests/streams/writable-streams/general.js
[modify] https://crrev.com/2d69d55423fa357963f4e5bbaf8b5ab44075a340/third_party/WebKit/Source/core/streams/WritableStream.js

Status: Fixed (was: Started)

Sign in to add a comment