Issue metadata
Sign in to add a comment
|
DOWNLOAD button from Download again infobar does not create a new offline copy of page under Downloads Home
Reported by
ahal...@ratchetqa.com,
Dec 7 2016
|
||||||||||||||||||||
Issue descriptionApplication Version: 57.0.2944.0 Android Build Number: 7.1/NDE63V Device: Google Pixel Steps to reproduce: 1. Launch Chrome and go to any website ex. m.facebook.com 2. Download the page offline > Re-download the page offline now 3. Tap on 'DOWNLOAD' button from download again infobar 4. Visit downloads home now > Observe downloads Observed behavior: DOWNLOAD button from Download again infobar doesn't create a new offline copy of page Expected behavior: Tapping on DOWNLOAD button from Download again infobar should create a new offline copy of page as seen on M57-57.0.2938.0 Frequency: <5/5>
,
Dec 7 2016
Please find logs and Video @ http://go/chrome-androidlogs1/6/671955
,
Dec 7 2016
,
Dec 7 2016
Make sure you only delete post save if namespace is "last_n". It seems that you might be deleting the previous "download" page.
,
Dec 8 2016
Bisect script pointed to https://chromium.googlesource.com/chromium/src/+/96de1925bdf5c051bb903581a427d7f9795c0032
,
Dec 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d768b7fc9d17d2df1f6d6d2d46758944e3bf09a commit 3d768b7fc9d17d2df1f6d6d2d46758944e3bf09a Author: carlosk <carlosk@chromium.org> Date: Tue Dec 13 22:30:02 2016 Fix snapshots from Downloads being deleted by last_n. Partially reverts the change that fixed good snapshots being deleted by failed ones in the context of last_n (https://codereview.chromium.org/2542833003/) because it created a new bug were pages offline-d through Downloas were being incorrectly erased ( https://crbug.com/671955 ). The reverted fix will be solved again later using a different approach. The reason to make this revert only partial is to keep the test improvements made which are still useful and valid. One test that had to be disabled because of the fix being removed. A new test was also added to confirm the incorrect snapshot deletion issue and avoid future occurrences. BUG= 655697 , 671955 Review-Url: https://codereview.chromium.org/2561163002 Cr-Commit-Position: refs/heads/master@{#438314} [modify] https://crrev.com/3d768b7fc9d17d2df1f6d6d2d46758944e3bf09a/chrome/browser/android/offline_pages/recent_tab_helper.cc [modify] https://crrev.com/3d768b7fc9d17d2df1f6d6d2d46758944e3bf09a/chrome/browser/android/offline_pages/recent_tab_helper.h [modify] https://crrev.com/3d768b7fc9d17d2df1f6d6d2d46758944e3bf09a/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc
,
Dec 13 2016
,
Jan 2 2017
This issue is fixed on latest M56-56.0.2924.47 and M57-57.0.2969.0
,
Jan 2 2017
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by ahal...@ratchetqa.com
, Dec 7 2016