Regression: In chrome://md-settings, dropdown arrow is seen zoomed in after closing Devtools.
Reported by
lpa...@etouch.net,
Dec 7 2016
|
||||
Issue descriptionChrome Version: 57.0.2944.0 (Official Build) d0df22be04ce0f84edfe6e6df9ae9b8af910d2ba-refs/heads/master@{#436483} (32/64-bit) OS: Mac (10.11.6, 10.12.1), Windows (7,8,10) What steps will reproduce the problem? 1) Launch chrome, open NTP, right click and select Inspect (to open Devtools). 2) Click on 'Toggle device' button and on left side select 'iPhone 6' in device dropdown. 3) Navigate to chrome://md-settings, on the same page and then close Devtools. 4) Observe the dropdown arrow for Font size and Page zoom. Dropdown arrow is seen zoomed in after closing Devtools. Dropdown arrow size should be seen proper after closing Devtools. This is a Regression issue broken in M-56, will soon update other info
,
Dec 7 2016
Using the per-revision bisect providing the bisect results, Good build: 55.0.2883.0 (Revision: 423768). Bad build: 55.0.2886.0 (Revision: 424099). You are probably looking for a change made after 423970 (known good), but no later than 423971 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/c60b24dc5fe1bd688177d5a6cd53bafd36a5c636..577dc9d546b6b77bb3ee2158e1aa4805d4f5adcd @dpapad -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Thank You.
,
Dec 7 2016
The real issue here is that CSS variables seem to not be working in device mode (see css_vars_missing.png). I don't know if this is MD Setting's problem, or something else yet.
,
Dec 7 2016
Noticing that this issue only happens if an ipad, iphone are chosen as the simulated device. It does not happen for "Nexus5x" for example. This leads me to believe that some feature detection code within Polymer might be causing this.
,
Dec 7 2016
After looking further into this bug, I don't think there is any action to be taken. The Polymer feature detection logic is at [1], which causes useNativeCSSProperties to be ignored for Iphone/Ipad. Also if useNativeCSSProperties is flipped to false at [2] then the styling is broken (even outside of device mode). This simply means that useNativeCSSProperties is not working properly when set to false, which ultimately is irrelevant for MD Settings, which will only ever run with that property set to true. [1] https://github.com/Polymer/polymer/blob/095d1b9f687eb5182e8f10b4b76e4465d107e078/src/lib/settings.html#L55 [2] https://cs.chromium.org/chromium/src/ui/webui/resources/js/polymer_config.js?q=useNativeCss&sq=package:chromium&l=9&dr=CSs |
||||
►
Sign in to add a comment |
||||
Comment 1 by lpa...@etouch.net
, Dec 7 20165.7 MB
5.7 MB Download
200 KB
200 KB View Download