Regression: 'Toggle device toolbar' or 'Select an element in the page to inspect it' icons are not clickable.
Reported by
jshan...@etouch.net,
Dec 7 2016
|
|||||
Issue descriptionChrome Version: 57.0.2944.0 (Official Build) bb1ac197d94d071514695c0f23854881db26f012-refs/heads/master@{#436816} OS: Windows Steps: 1. Launch Chrome and open devtool on NTP 2. Click on 'Toggle device toolbar' or 'Select an element in the page to inspect it' icon and observe Actual: 'Toggle device toolbar' or 'Select an element in the page to inspect it' icons are not clickable. Expected: 'Toggle device toolbar' or 'Select an element in the page to inspect it' icons should be clickable. This is a regression issue, broken in M-57 series, will soon update the bisect info. Good build: 57.0.2943.0 Bad build: 57.0.2944.0 Note: will soon update Linux and Mac OS behavior
,
Dec 7 2016
Using the per-revision bisect providing the bisect results, Good build: 57.0.2943.0 (Revision :436483) Bad build: 57.0.2944.0 (Revision :436816) You are probably looking for a change made after 436787 (known good), but no later than 436788 (first known bad). CHANGELOG URL: The script might not always return single CL as suspectas some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/5695589b87938486b24f0e1f6dfb761ab7915ed1..ded3e43b7d536317c1041725ff41dcb15177d8fc From the CL above, assigning the issue to the concern owner @dgozman - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Review-Url: https://codereview.chromium.org/2553043003 Thanks!
,
Dec 7 2016
Note: Above issue is also seen for other icons of devtools like 'clear all' of console section, 'record' button of Memory section,etc
,
Dec 7 2016
Issue 671981 has been merged into this issue.
,
Dec 7 2016
Adding Release Block label, please undo or reduce priority accordingly.
,
Dec 7 2016
Reverted offending patch in https://crrev.com/cd6bd661a2011522601c8aeef55775a823dd934a.
,
Dec 7 2016
dgozman@, thank you for the revert.
,
Dec 7 2016
dgozman@, could you please merge the above revert (c#6) to 2944 branch? I am planning to create a back-up build for M57 Dev from the same branch. PS: You do not need to follow any 'Merge-Request' process, since it is yet to be branched officially. Thank you!
,
Dec 7 2016
Posted a merge patch: https://codereview.chromium.org/2563483002/
,
Dec 8 2016
Issue 672123 has been merged into this issue.
,
Dec 8 2016
,
Dec 8 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jshan...@etouch.net
, Dec 7 2016