New issue
Advanced search Search tips
Starred by 2 users
Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux, Windows, Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment
Regression : Misalignment of 'Hide Navigator' and 'Hide Debugger' buttons is seen in devtools.
Reported by mni...@etouch.net, Dec 7 2016 Back to list
Version: 57.0.2943.0 d0df22be04ce0f84edfe6e6df9ae9b8af910d2ba-refs/heads/master@{#436483} (64-bit)
OS: Windows(7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6, 10.12.1)

What steps will reproduce the problem?
1. Launch chrome, navigate to NTP and open devtools 
2. Now go to 'Sources' section and drag the devtools window to LHS such that 'Hide Navigator' and 'Hide Debugger' buttons are seen
3. Now drag the column in devtools such as both buttons are placed close to each other,observe

Actual: Misalignment of 'Hide Navigator' and 'Hide Debugger' buttons is seen
Expected: 'Hide Navigator' and 'Hide Debugger' button should be seen properly in a straight line

This is regression issue, broken in ‘M 56’ and will soon update other info :
Good build:56.0.2913.0 
Bad build: 56.0.2914.0
 
Actual_screenshot.png
370 KB View Download
Expected_screenshot.png
386 KB View Download
Labels: hasbisect-per-revision
Owner: lushnikov@chromium.org
Status: Assigned
Using the per-revision bisect providing the bisect results,
Good build: 56.0.2913.0 (Revision: 430459).
Bad build: 56.0.2914.0 (Revision: 430837).

You are probably looking for a change made after 430713 (known good), but no later than 430714 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/2c944c9e76acc4e22a67bff89e33afd2342db0a1..cec7d0e095a1fb1304b6bda02129ac4cc117f134

@lushnikov -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank You.
Labels: ReleaseBlock-Stable
Adding release block label, please undo if not the case.
Comment 3 by m...@jakehendy.com, Dec 7 2016
I've a workaround for this, now I'm just working out the root cause. May I take this issue for my first bug?
Labels: -Pri-1 -ReleaseBlock-Stable Pri-3
#3: Please, go ahead!
Able to reproduce the issue on windows 7 using chrome version 57.0.2952.0.
Any update on this issue please 

Thanks,
Project Member Comment 7 by bugdroid1@chromium.org, Jan 23 2017
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4d2364eb32a5b242790324536efccd843cb81aa8

commit 4d2364eb32a5b242790324536efccd843cb81aa8
Author: me <me@jakehendy.com>
Date: Mon Jan 23 08:29:15 2017

DevTools: Correct Source Panel Show/Hide Toolbar buttons

Regression : Misalignment of 'Hide Navigator' and 'Hide Debugger' buttons is seen in devtools.

Flipped mask positions and removed—now unnecessary—rotation transforms around show/hide panel icon containers.

BUG= 671930 
R=lushnikov@chromium.org
TEST=Open Dev Tools, open Sources Pane, observe show/hide sidebar buttons
are correctly aligned.  crbug.com/671930 

Review-Url: https://codereview.chromium.org/2600493002
Cr-Commit-Position: refs/heads/master@{#445339}

[modify] https://crrev.com/4d2364eb32a5b242790324536efccd843cb81aa8/AUTHORS
[modify] https://crrev.com/4d2364eb32a5b242790324536efccd843cb81aa8/third_party/WebKit/Source/devtools/front_end/ui/Icon.js

Status: Fixed
Status: Assigned
The solution turned out to be not working. I'm reverting the CL: 
https://codereview.chromium.org/2655793003/

The reason - the icons turned out to be different.
- Before patch: http://imgur.com/a/eFCnz
- After patch: http://imgur.com/a/gJ24q

Jake, would you like to give this another shot?
Comment 10 by m...@jakehendy.com, Jan 25 2017
@lushnikov I knew there must have been a reason for the transforms in the first place!

If I could take another shot I shall. Thank you!
Project Member Comment 11 by bugdroid1@chromium.org, Jan 25 2017
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d52b38109b89d346334cc0bc582328d6131fe720

commit d52b38109b89d346334cc0bc582328d6131fe720
Author: lushnikov <lushnikov@chromium.org>
Date: Wed Jan 25 09:11:59 2017

Revert of DevTools: Correct Source Panel Show/Hide Toolbar buttons (patchset #1 id:1 of https://codereview.chromium.org/2600493002/ )

Reason for revert:
It turned out the icons are actually wrong. Compare:
- Without this patch (correct): http://imgur.com/a/eFCnz
- With this patch (incorrect): http://imgur.com/a/gJ24q

Original issue's description:
> DevTools: Correct Source Panel Show/Hide Toolbar buttons
>
> Regression : Misalignment of 'Hide Navigator' and 'Hide Debugger' buttons is seen in devtools.
>
> Flipped mask positions and removed—now unnecessary—rotation transforms around show/hide panel icon containers.
>
> BUG= 671930 
> R=lushnikov@chromium.org
> TEST=Open Dev Tools, open Sources Pane, observe show/hide sidebar buttons
> are correctly aligned.  crbug.com/671930 
>
> Review-Url: https://codereview.chromium.org/2600493002
> Cr-Commit-Position: refs/heads/master@{#445339}
> Committed: https://chromium.googlesource.com/chromium/src/+/4d2364eb32a5b242790324536efccd843cb81aa8

TBR=dgozman@chromium.org,pfeldman@chromium.org,me@jakehendy.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 671930 

Review-Url: https://codereview.chromium.org/2655793003
Cr-Commit-Position: refs/heads/master@{#445983}

[modify] https://crrev.com/d52b38109b89d346334cc0bc582328d6131fe720/AUTHORS
[modify] https://crrev.com/d52b38109b89d346334cc0bc582328d6131fe720/third_party/WebKit/Source/devtools/front_end/ui/Icon.js

Comment 12 by m...@jakehendy.com, Jan 28 2017
@lushnikov apologies for delay. I somehow managed to hose my dev environment and ended up reinstalling Windows.

I've submitted https://codereview.chromium.org/2658363003/ which has an image (http://imgur.com/a/FHN3q) proving the correctness of the icons as well.

Thanks!
Project Member Comment 13 by bugdroid1@chromium.org, Jan 30 2017
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/711b0a82a640608bf4e069b9398ec415e2b8b20a

commit 711b0a82a640608bf4e069b9398ec415e2b8b20a
Author: me <me@jakehendy.com>
Date: Mon Jan 30 14:21:43 2017

Dev Tools: Adjust Dev Tool Source panel show/hide sidebar icons

Instead of rotating icons for the right hand side, flip the icons along the x-axis.

BUG= 671930 
R=lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2658363003
Cr-Commit-Position: refs/heads/master@{#446978}

[modify] https://crrev.com/711b0a82a640608bf4e069b9398ec415e2b8b20a/AUTHORS
[modify] https://crrev.com/711b0a82a640608bf4e069b9398ec415e2b8b20a/third_party/WebKit/Source/devtools/front_end/ui/Icon.js

Status: Fixed
Sign in to add a comment