New issue
Advanced search Search tips

Issue 671928 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue 695003



Sign in to add a comment

Change the GamepadProvider::getSharedMemoryHandle() into getSharedBufferHandle()

Project Member Reported by ke...@intel.com, Dec 7 2016

Issue description

Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)

What steps will reproduce the problem?
The GamepadMessages are mojoified by CL: https://codereview.chromium.org/2522843002/
In this CL, in gamepad_provider.h we defined: base::SharedMemoryHandle GetSharedMemoryHandle(). as a TODO(), we should change it into mojo::ShareBufferHandle GetSharedBufferHandle() after the gamepad_hardware_buffer.h be moved into //device.

What is the expected result?
What we want to implement in following CL is: 
Gamepad_provider should only provides one get-sharedMemoryHandle interface as mojo::GetSharedBufferHandle(). GamepadService gets the mojo::SharedBufferHandle from GamepadProvider. GamepadService has two customers:
One is GamepadMonitor, GamepadService can return the mojo::SharedBufferHandle directly to GamepadMonitor, it is clean.
Another is PepperGamepadHost which is not mojoified and still needs base::SharedMemoryHandle. so GamepadService needs to do the convertion and returns a base::SharedBufferHanle to PepperGamepadHost.
After PepperGamepadHost will be mojoified(a long term goal). GamepadService can only provides one interface as mojo::GetSharedBufferHandle() too.

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 

Comment 1 by ajha@chromium.org, Dec 7 2016

Components: Blink>GamepadAPI
Labels: M-57
Tagging with current canary milestone.
Blockedon: 695003
Labels: -Type-Bug Type-Feature
Status: Available (was: Untriaged)
Thanks for the TODO. If I understand correctly, this work depends on the mojoificiation of PepperGamepadHost (bug 695003).
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 6 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: mattreynolds@chromium.org
Status: Available (was: Untriaged)

Sign in to add a comment