Chrome Version: (copy from chrome://version)
OS: (e.g. Win7, OSX 10.9.5, etc...)
What steps will reproduce the problem?
The GamepadMessages are mojoified by CL: https://codereview.chromium.org/2522843002/
In this CL, in gamepad_provider.h we defined: base::SharedMemoryHandle GetSharedMemoryHandle(). as a TODO(), we should change it into mojo::ShareBufferHandle GetSharedBufferHandle() after the gamepad_hardware_buffer.h be moved into //device.
What is the expected result?
What we want to implement in following CL is:
Gamepad_provider should only provides one get-sharedMemoryHandle interface as mojo::GetSharedBufferHandle(). GamepadService gets the mojo::SharedBufferHandle from GamepadProvider. GamepadService has two customers:
One is GamepadMonitor, GamepadService can return the mojo::SharedBufferHandle directly to GamepadMonitor, it is clean.
Another is PepperGamepadHost which is not mojoified and still needs base::SharedMemoryHandle. so GamepadService needs to do the convertion and returns a base::SharedBufferHanle to PepperGamepadHost.
After PepperGamepadHost will be mojoified(a long term goal). GamepadService can only provides one interface as mojo::GetSharedBufferHandle() too.
Please use labels and text to provide additional information.
For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
Comment 1 by ajha@chromium.org
, Dec 7 2016Labels: M-57