RecentTabsSubMenuModelTest.MaxWidth is flaky |
||||||||
Issue descriptionbrowser_side_navigation_unit_tests failing on chromium.linux/Linux Tests Type: build-failure Builders failed on: - Linux Tests: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests RecentTabsSubMenuModelTest.MaxWidth RecentTabsSubMenuModelTest.MaxWidth (run #1): [ RUN ] RecentTabsSubMenuModelTest.MaxWidth [1441:1441:1206/191131.020386:15643713747:ERROR:sessions_sync_manager.cc(232)] No windows present, see crbug.com/639009 Xlib: extension "RANDR" missing on display ":99". ../../chrome/browser/ui/toolbar/recent_tabs_builder_test_helper.cc:227: Failure Value of: delegate->GetAllForeignSessions(&sessions) Actual: false Expected: true ../../chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc:594: Failure Value of: model.GetItemCount() Actual: 5 Expected: 6 ../../chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc:597: Failure Expected: (-1) != (model.GetMaxWidthForItemAtIndex(4)), actual: -1 vs -1 [1441:1441:1206/191131.026896:15643720241:FATAL:simple_menu_model.cc(434)] Check failed: static_cast<size_t>(index) < items_.size() (5 vs. 5) #0 0x000003aefcbe base::debug::StackTrace::StackTrace() #1 0x000003b02acb logging::LogMessage::~LogMessage() #2 0x000003e8600e ui::SimpleMenuModel::ValidateItemIndex() #3 0x000003e86179 ui::SimpleMenuModel::GetCommandIdAt() #4 0x000004cf7217 RecentTabsSubMenuModel::GetMaxWidthForItemAtIndex() #5 0x000000edb42d RecentTabsSubMenuModelTest_MaxWidth_Test::TestBody() #6 0x0000032028ce testing::Test::Run() #7 0x0000032036b0 testing::TestInfo::Run() #8 0x000003203b47 testing::TestCase::Run() #9 0x00000320ae37 testing::internal::UnitTestImpl::RunAllTests() #10 0x00000320aa4a testing::UnitTest::Run() #11 0x000002f88691 base::TestSuite::Run() #12 0x000002f89e99 base::(anonymous namespace)::LaunchUnitTestsInternal() #13 0x000002f89d64 base::LaunchUnitTests() #14 0x000002f84a46 main #15 0x7f25dd1c17ed __libc_start_main #16 0x00000063f2e1 <unknown>
,
Dec 7 2016
Seems you last touched this test - could you take a look?
,
Dec 7 2016
Also failing on Mac unit tests now: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/10313/steps/unit_tests%20on%20Mac-10.10/logs/RecentTabsSubMenuModelTest.MaxWidth
,
Dec 7 2016
Aaand on Windows: https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%281%29/builds/60868
,
Dec 7 2016
CCing some folks who recently touched c/b/ui/toolbar. None of the changes look related, but maybe I'm missing something. Could you take a look and/or help triage?
,
Dec 7 2016
This test has been flaking all day; I'm disabling it.
,
Dec 7 2016
+zea It looks like this test case calls into sessions_sync_manager.cc. Nicolas, do you think this could have been caused by https://codereview.chromium.org/2499083004/ ?
,
Dec 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84ec64a958b9586d0ffcab1ce0ad19d4d08dd0f9 commit 84ec64a958b9586d0ffcab1ce0ad19d4d08dd0f9 Author: treib <treib@chromium.org> Date: Wed Dec 07 17:58:31 2016 Disable flaky RecentTabsSubMenuModelTest.MaxWidth BUG= 671902 TBR=msw Review-Url: https://codereview.chromium.org/2560883002 Cr-Commit-Position: refs/heads/master@{#437000} [modify] https://crrev.com/84ec64a958b9586d0ffcab1ce0ad19d4d08dd0f9/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc
,
Dec 7 2016
,
Dec 7 2016
I'll need to look at this properly when I'm back in the office tomorrow. Looks like a recent change has caused one of the menu items to be removed.
,
Dec 7 2016
A local bisect of this on mac unit_tests pointed at 159246f269b561bf931fa56a35b2704fab7dcc96 as introducing the failure.
,
Dec 7 2016
Reassigning to zea@
,
Dec 8 2016
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4224baa9e43677897f657a97b810a89245f6631 commit f4224baa9e43677897f657a97b810a89245f6631 Author: zea <zea@chromium.org> Date: Fri Dec 09 19:12:43 2016 [Sync] Fix flakiness from Sessions refactor Fixes a flaky issue introduced in the recent tabs submenu tests due to inspecting possibly unset timestamp values. Also fixes a pre-existing issue where sync ids for tabs were not being set, which the refactor brought to light. BUG= 671902 , 671902 TBR=msw Review-Url: https://codereview.chromium.org/2562853002 Cr-Commit-Position: refs/heads/master@{#437604} [modify] https://crrev.com/f4224baa9e43677897f657a97b810a89245f6631/chrome/browser/sync/sessions/sessions_sync_manager_unittest.cc [modify] https://crrev.com/f4224baa9e43677897f657a97b810a89245f6631/chrome/browser/ui/toolbar/recent_tabs_sub_menu_model_unittest.cc [modify] https://crrev.com/f4224baa9e43677897f657a97b810a89245f6631/components/sync_sessions/sessions_sync_manager.cc [modify] https://crrev.com/f4224baa9e43677897f657a97b810a89245f6631/components/sync_sessions/synced_session_tracker.cc
,
Dec 9 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by treib@chromium.org
, Dec 7 2016Owner: edwardjung@chromium.org