"SiteDetailsBrowserTest.IsolateExtensions" is flaky |
||||||||||
Issue description"SiteDetailsBrowserTest.IsolateExtensions" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMwsSBUZsYWtlIihTaXRlRGV0YWlsc0Jyb3dzZXJUZXN0Lklzb2xhdGVFeHRlbnNpb25zDA. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
Dec 8 2016
This test has been flaking on Windows since Nov 1. I'm disabling it.
,
Dec 8 2016
,
Dec 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/883e7b724370402ca8709a69ccec538e04f0bc2b commit 883e7b724370402ca8709a69ccec538e04f0bc2b Author: treib <treib@chromium.org> Date: Thu Dec 08 14:08:20 2016 Disable flaky SiteDetailsBrowserTest.IsolateExtensions on Windows TBR=nasko@chromium.org,nick@chromium.org BUG=671891 Review-Url: https://codereview.chromium.org/2564563002 Cr-Commit-Position: refs/heads/master@{#437239} [modify] https://crrev.com/883e7b724370402ca8709a69ccec538e04f0bc2b/chrome/browser/site_details_browsertest.cc
,
Dec 8 2016
,
Dec 8 2016
Detected 3 new flakes for test/step "SiteDetailsBrowserTest.IsolateExtensions". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMwsSBUZsYWtlIihTaXRlRGV0YWlsc0Jyb3dzZXJUZXN0Lklzb2xhdGVFeHRlbnNpb25zDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
,
Dec 8 2016
The extra flakes were from a revision before the test was disabled, so removing sheriff label again.
,
Dec 8 2016
Seems likely that the observed flakiness started because of https://chromium.googlesource.com/chromium/src/+/9729c2081fc2daeb1bb487fe329aaf8458fac898, which turned off isolate-extensions by default, which shifts the expectations for this test (these tests have expectations for both oopif and non-oopif, but don't explicitly run both modes). It's possible that the true cause of this is some other change that landed while --isolate-extensions was on by default.
,
Dec 8 2016
The assert that's failing is the value of GetRenderProcessCount() after a navigation of Tab 2: EXPECT_THAT(GetRenderProcessCount(), DependingOnPolicy(2, 3, 3)); The navigation is supposed to eliminate the process for extension #2 (both tabs are now in extension 3's process, and the other process is for extension 1's background page). It's likely that the NavigateToURL is simply not waiting long enough for the RPH to go away.
,
Dec 8 2016
I've confirmed the above theory by adding a slow unload handler to these tests, which makes the failure reliable. So this is really yet another instance of the problem that we were hoping to solve with NavMaker.
,
Dec 8 2016
Here's the patch to force flakiness: https://codereview.chromium.org/2562703005
,
Feb 23 2017
The test failed (TIME OUT) on Mac 10.9 bot recently: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.9_Tests%2F36817%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Fstdout Interestingly it caused segfault on first run: [ RUN ] SiteDetailsBrowserTest.IsolateExtensions [98791:771:0223/132756.553910:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98791:771:0223/132756.554251:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98791:771:0223/132756.667099:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98791:771:0223/132756.667166:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98791:771:0223/132756.670210:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98791:771:0223/132756.670296:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98785:771:0223/132757.043598:INFO:CONSOLE(1)] "Extension One running", source: chrome-extension://abaccfmchmkppelgidojfpkgkajidpdk/script.js (1) [98785:52507:0223/132757.158189:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico [98791:771:0223/132757.420191:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98791:771:0223/132757.420354:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98791:771:0223/132757.544267:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98791:771:0223/132757.544417:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98791:771:0223/132757.548429:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98791:771:0223/132757.548474:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98785:771:0223/132800.055526:WARNING:render_frame_host_impl.cc(2191)] OnDidStopLoading was called twice. [98791:771:0223/132800.134742:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98791:771:0223/132800.134801:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98791:771:0223/132800.136439:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98791:771:0223/132800.136489:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98791:771:0223/132800.138916:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98791:771:0223/132800.138964:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98785:771:0223/132800.173505:WARNING:render_frame_host_impl.cc(2191)] OnDidStopLoading was called twice. [98785:771:0223/132800.976772:WARNING:render_frame_host_impl.cc(2191)] OnDidStopLoading was called twice. [98791:771:0223/132801.048945:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98791:771:0223/132801.049014:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98791:771:0223/132801.050631:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98791:771:0223/132801.050686:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98791:771:0223/132801.053242:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98791:771:0223/132801.053301:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98785:771:0223/132801.060620:WARNING:render_frame_host_impl.cc(2191)] OnDidStopLoading was called twice. [98791:771:0223/132801.425460:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98791:771:0223/132801.425529:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98791:771:0223/132801.430898:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [98791:771:0223/132801.430950:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() BrowserTestBase received signal: Segmentation fault: 11. Backtrace: 0 browser_tests 0x000000010d4b0e1c base::debug::StackTrace::StackTrace(unsigned long) + 28 1 browser_tests 0x000000010dbde74a content::(anonymous namespace)::DumpStackTraceSignalHandler(int) + 202 2 libsystem_platform.dylib 0x00007fff935e95aa _sigtramp + 26 3 ??? 0x0000206000000000 0x0 + 35596688949248 4 CoreFoundation 0x00007fff97a2d9ac __invoking___ + 140 5 CoreFoundation 0x00007fff97a2d814 -[NSInvocation invoke] + 308 6 CoreFoundation 0x00007fff97ad0466 -[NSInvocation invokeWithTarget:] + 54 7 CoreFoundation 0x00007fff97aa0044 ___forwarding___ + 452 8 CoreFoundation 0x00007fff97a9fdf8 _CF_forwarding_prep_0 + 120 9 AppKit 0x00007fff902e190a -[NSApplication sendEvent:] + 2843 10 browser_tests 0x000000010d5d8cbc __34-[BrowserCrApplication sendEvent:]_block_invoke + 172 11 browser_tests 0x000000010d4cba8a base::mac::CallWithEHFrame(void () block_pointer) + 10 12 browser_tests 0x000000010d5d8a95 -[BrowserCrApplication sendEvent:] + 261 13 AppKit 0x00007fff901319f9 -[NSApplication run] + 646 14 browser_tests 0x000000010d4dbc6e base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 334 15 browser_tests 0x000000010d4db2bc base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 92 16 browser_tests 0x000000010d4d761e base::MessageLoop::RunHandler() + 94 17 browser_tests 0x000000010d4fb4c3 base::RunLoop::Run() + 115 18 browser_tests 0x000000010dc1caee content::MessageLoopRunner::Run() + 78 19 browser_tests 0x000000010d5769c7 ui_test_utils::NavigateToURLWithDispositionBlockUntilNavigationsComplete(Browser*, GURL const&, int, WindowOpenDisposition, int) + 1623 20 browser_tests 0x000000010b8fb144 SiteDetailsBrowserTest_IsolateExtensions_Test::RunTestOnMainThread() + 21332 21 browser_tests 0x000000010d5740f7 InProcessBrowserTest::RunTestOnMainThreadLoop() + 215 22 browser_tests 0x000000010dbde4a6 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 310 23 browser_tests 0x000000010d5dd2a2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4290 24 browser_tests 0x000000010d5dc0de ChromeBrowserMainParts::PreMainMessageLoopRun() + 62 25 browser_tests 0x000000010c3d6e73 content::BrowserMainLoop::PreMainMessageLoopRun() + 67 26 browser_tests 0x000000010c703936 content::StartupTaskRunner::RunAllTasksNow() + 38 27 browser_tests 0x000000010c3d5152 content::BrowserMainLoop::CreateStartupTasks() + 658 28 browser_tests 0x000000010c3d9de4 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 756 29 browser_tests 0x000000010c3d2b94 content::BrowserMain(content::MainFunctionParams const&) + 100 30 browser_tests 0x000000010d497c90 content::ContentMainRunnerImpl::Run() + 368 31 browser_tests 0x000000010d496ee6 content::ContentMain(content::ContentMainParams const&) + 54 32 browser_tests 0x000000010dbde192 content::BrowserTestBase::SetUp() + 1906 33 browser_tests 0x000000010d5733d7 InProcessBrowserTest::SetUp() + 391 34 browser_tests 0x000000010e2f7771 testing::Test::Run() + 97 35 browser_tests 0x000000010e2f8290 testing::TestInfo::Run() + 288 36 browser_tests 0x000000010e2f8827 testing::TestCase::Run() + 263 37 browser_tests 0x000000010e2fe837 testing::internal::UnitTestImpl::RunAllTests() + 871 38 browser_tests 0x000000010e2fe4a3 testing::UnitTest::Run() + 163 39 browser_tests 0x000000010d589185 base::TestSuite::Run() + 133 40 browser_tests 0x000000010d4a33ef ChromeTestSuiteRunner::RunTestSuite(int, char**) + 31 41 browser_tests 0x000000010dc191de content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) + 302 42 browser_tests 0x000000010d4a337a main + 90 43 libdyld.dylib 0x00007fff8c8e35fd start + 1 But then timed out on each retry, e.g.: [ RUN ] SiteDetailsBrowserTest.IsolateExtensions [926:771:0223/133140.424699:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [926:771:0223/133140.424836:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [926:771:0223/133140.560689:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [926:771:0223/133140.560785:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [926:771:0223/133140.563010:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [926:771:0223/133140.563080:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [923:771:0223/133141.151993:INFO:CONSOLE(1)] "Extension One running", source: chrome-extension://infabdelpjadclbeanlccpbbjekpabbm/script.js (1) [923:94211:0223/133141.260080:WARNING:embedded_test_server.cc(219)] Request not handled. Returning 404: /favicon.ico [926:771:0223/133141.691716:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [926:771:0223/133141.691780:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [926:771:0223/133141.830359:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [926:771:0223/133141.830422:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [926:771:0223/133141.832214:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() [926:771:0223/133141.832289:ERROR:gl_surface.cc(137)] Not implemented reached in virtual gl::GLSurfaceFormat gl::GLSurface::GetFormat() BrowserTestBase received signal: Terminated: 15. Backtrace: 0 browser_tests 0x000000010feabe1c base::debug::StackTrace::StackTrace(unsigned long) + 28 1 browser_tests 0x00000001105d974a content::(anonymous namespace)::DumpStackTraceSignalHandler(int) + 202 2 libsystem_platform.dylib 0x00007fff935e95aa _sigtramp + 26 3 ??? 0x00007fbdf50535a0 0x0 + 140453836305824 4 CoreFoundation 0x00007fff97a64f15 __CFRunLoopServiceMachPort + 181 5 CoreFoundation 0x00007fff97a64539 __CFRunLoopRun + 1161 6 CoreFoundation 0x00007fff97a63e75 CFRunLoopRunSpecific + 309 7 HIToolbox 0x00007fff95ef3a0d RunCurrentEventLoopInMode + 226 8 HIToolbox 0x00007fff95ef37b7 ReceiveNextEventCommon + 479 9 HIToolbox 0x00007fff95ef35bc _BlockUntilNextEventMatchingListInModeWithFilter + 65 10 AppKit 0x00007fff9013e24e _DPSNextEvent + 1434 11 AppKit 0x00007fff9013d89b -[NSApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 122 12 browser_tests 0x000000010ffd3390 __71-[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:]_block_invoke + 64 13 browser_tests 0x000000010fec6a8a base::mac::CallWithEHFrame(void () block_pointer) + 10 14 browser_tests 0x000000010ffd32c9 -[BrowserCrApplication nextEventMatchingMask:untilDate:inMode:dequeue:] + 169 15 AppKit 0x00007fff9013199c -[NSApplication run] + 553 16 browser_tests 0x000000010fed6c6e base::MessagePumpNSApplication::DoRun(base::MessagePump::Delegate*) + 334 17 browser_tests 0x000000010fed62bc base::MessagePumpCFRunLoopBase::Run(base::MessagePump::Delegate*) + 92 18 browser_tests 0x000000010fed261e base::MessageLoop::RunHandler() + 94 19 browser_tests 0x000000010fef64c3 base::RunLoop::Run() + 115 20 browser_tests 0x0000000110617aee content::MessageLoopRunner::Run() + 78 21 browser_tests 0x00000001105d9e11 content::NavigateIframeToURL(content::WebContents*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, GURL const&) + 177 22 browser_tests 0x000000010e2f2bc2 SiteDetailsBrowserTest_IsolateExtensions_Test::RunTestOnMainThread() + 7634 23 browser_tests 0x000000010ff6f0f7 InProcessBrowserTest::RunTestOnMainThreadLoop() + 215 24 browser_tests 0x00000001105d94a6 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() + 310 25 browser_tests 0x000000010ffd82a2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() + 4290 26 browser_tests 0x000000010ffd70de ChromeBrowserMainParts::PreMainMessageLoopRun() + 62 27 browser_tests 0x000000010edd1e73 content::BrowserMainLoop::PreMainMessageLoopRun() + 67 28 browser_tests 0x000000010f0fe936 content::StartupTaskRunner::RunAllTasksNow() + 38 29 browser_tests 0x000000010edd0152 content::BrowserMainLoop::CreateStartupTasks() + 658 30 browser_tests 0x000000010edd4de4 content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) + 756 31 browser_tests 0x000000010edcdb94 content::BrowserMain(content::MainFunctionParams const&) + 100 32 browser_tests 0x000000010fe92c90 content::ContentMainRunnerImpl::Run() + 368 33 browser_tests 0x000000010fe91ee6 content::ContentMain(content::ContentMainParams const&) + 54 34 browser_tests 0x00000001105d9192 content::BrowserTestBase::SetUp() + 1906 35 browser_tests 0x000000010ff6e3d7 InProcessBrowserTest::SetUp() + 391 36 browser_tests 0x0000000110cf2771 testing::Test::Run() + 97 37 browser_tests 0x0000000110cf3290 testing::TestInfo::Run() + 288 38 browser_tests 0x0000000110cf3827 testing::TestCase::Run() + 263 39 browser_tests 0x0000000110cf9837 testing::internal::UnitTestImpl::RunAllTests() + 871 40 browser_tests 0x0000000110cf94a3 testing::UnitTest::Run() + 163 41 browser_tests 0x000000010ff84185 base::TestSuite::Run() + 133 42 browser_tests 0x000000010fe9e3ef ChromeTestSuiteRunner::RunTestSuite(int, char**) + 31 43 browser_tests 0x00000001106141de content::LaunchTests(content::TestLauncherDelegate*, int, int, char**) + 302 44 browser_tests 0x000000010fe9e37a main + 90 45 libdyld.dylib 0x00007fff8c8e35fd start + 1 [600/600] SiteDetailsBrowserTest.IsolateExtensions (TIMED OUT)
,
Apr 3 2017
,
Apr 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/041854ff2d817f981b08b33fca1bf20168c49cb2 commit 041854ff2d817f981b08b33fca1bf20168c49cb2 Author: timloh <timloh@chromium.org> Date: Mon Apr 03 07:27:40 2017 Disable SiteDetailsBrowserTest.IsolateExtensions on Mac SiteDetailsBrowserTest.IsolateExtensions is timing out most of the time on Mac ASan 64 Tests (1), and also timed out a couple times on Mac10.9 Tests (dbg). https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29?numbuilds=200 TBR=nick@chromium.org BUG=671891 Review-Url: https://codereview.chromium.org/2790033002 Cr-Commit-Position: refs/heads/master@{#461381} [modify] https://crrev.com/041854ff2d817f981b08b33fca1bf20168c49cb2/chrome/browser/site_details_browsertest.cc
,
Aug 2
Started to become really flaky in mash_browser_tests recently with following errors: ../../chrome/browser/site_details_browsertest.cc:674: Failure Value of: GetRenderProcessCount() Expected: (under --site-per-process) 6 Actual: 7 Stack trace: #0 0x000001fe746c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x000001fe6e49 testing::internal::AssertHelper::operator=() #2 0x000000c453f9 SiteDetailsBrowserTest_IsolateExtensions_Test::RunTestOnMainThread() #3 0x00000413fa7b content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #4 0x000003d4e19a ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #5 0x000003d4d0e1 ChromeBrowserMainParts::PreMainMessageLoopRun() #6 0x000001c010c5 chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #7 0x00000295cd61 content::BrowserMainLoop::PreMainMessageLoopRun() #8 0x000002cc2867 content::StartupTaskRunner::RunAllTasksNow() #9 0x00000295b74d content::BrowserMainLoop::CreateStartupTasks() #10 0x00000295f1d3 content::BrowserMainRunnerImpl::Initialize() #11 0x000002959754 content::BrowserMain() #12 0x000003b9104c content::ContentMainRunnerImpl::Run() #13 0x0000057b2a30 service_manager::Main() #14 0x000003b8f4b4 content::ContentMain() #15 0x00000413f6b2 content::BrowserTestBase::SetUp() #16 0x000003cfd87e InProcessBrowserTest::SetUp() I've seen 4 failures, 3 failure-pass runs out of 9 runs (so only 2 runs were fully successful) after around: https://chromium.googlesource.com/chromium/src/+log/e7a247abf169ca5f2c2abca7787be0f8c19bc26c%5E..30322354006347ead2e0545b61476a56e671a085?pretty=fuller&n= Potentially the failure is mash-specific, but given that the test itself has been flaky I'm adding the note here to share wider context.
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8e837e57212ea2abd00e2cdf3a7882f16e6dd332 commit 8e837e57212ea2abd00e2cdf3a7882f16e6dd332 Author: Kinuko Yasuda <kinuko@chromium.org> Date: Thu Aug 02 04:22:58 2018 Suppress SiteDetailsBrowserTest.IsolateExtensions in mash_browser_tests TBR=jamescook,nick Bug: 671891 Change-Id: Ic0c49bfb7f012fa6f8bd3e5150f57274d439d073 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1159927 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#580060} [modify] https://crrev.com/8e837e57212ea2abd00e2cdf3a7882f16e6dd332/testing/buildbot/filters/mash.browser_tests.filter
,
Aug 2
Issue 870167 has been merged into this issue.
,
Aug 2
,
Aug 2
The test was also failing in non-mash browser_tests on Chrome OS, e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/11418 I wouldn't expect mash to do anything other than change timing a bit (there's an extra process for system UI stuff, but doesn't affect renderers). Maybe it just needs to be always-disabled, or always-disabled on Chrome OS?
,
Aug 2
Note: the GL renderer for browser tests has recently been changed from OSMesa to SwiftShader. This test is one of 3 tests that were made flaky by the change and that I'm investigating. Would anyone have insight on why changing the GL renderer would cause GetRenderProcessCount() to return a different number? And only sometimes? Also note that swiftShader is an asynchronous renderer (gl calls do not block Chomium's execution), and OSMesa was a synchronous renderer (calls were blocking Chromium's execution), so it is possible for SwiftShader to do rendering in the background while Chromium continues its execution. This could mean that checking for an exact number here is no longer possible, due to the nature of the renderer, and was more an artefact of using a blocking renderer to begin with.
,
Aug 2
That test is also flaky in viz_browser_tests (the same way it is flaky with browser_tests and mash_browser_tests) on linux-chromeos-rel, so it should probably be disabled there too.
,
Aug 2
Let's disable it on CrOS only for the time being, if it looks flaky only on that platform. In parallel, I will investigate whether this test can just be removed, as we have shipped IsolateExtensions a while ago.
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5da0d0d16f47b5f85fc74e95e377bb3597d7264e commit 5da0d0d16f47b5f85fc74e95e377bb3597d7264e Author: Alexis Hetu <sugoi@google.com> Date: Thu Aug 02 21:19:11 2018 Disabling flaky tests on ChromeOS As a result of replacing OSMesa with SwiftShader for running browser_tests recently, 4 tests have become flaky on ChromeOS: SiteDetailsBrowserTest.IsolateExtensions ArcVoiceInteractionArcHomeServiceTest.VoiceInteractionStructureMultipleSelectionTest ExtensionApiNewTabTest.Tabs PasswordManagerBrowserTestWithViewsFeature.PromptForFetchSubmitWithoutNavigation This cl temporarily disables these 4 tests on ChromeOs until we can find a proper fix for them. TBR=vasilii@chromium.org rdevlin.cronin@chromium.org hidehiko@chromium.org TBR_REASON="Making the linux-chromeos-rel bot less flaky" Bug: chromium:870372 chromium:870322 chromium:870319 chromium:671891 Change-Id: I55fdd44622f7fac13dafaa19699904178e37d1fb Reviewed-on: https://chromium-review.googlesource.com/1161202 Commit-Queue: Alexis Hétu <sugoi@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#580324} [modify] https://crrev.com/5da0d0d16f47b5f85fc74e95e377bb3597d7264e/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service_browsertest.cc [modify] https://crrev.com/5da0d0d16f47b5f85fc74e95e377bb3597d7264e/chrome/browser/extensions/extension_tabs_apitest.cc [modify] https://crrev.com/5da0d0d16f47b5f85fc74e95e377bb3597d7264e/chrome/browser/password_manager/password_manager_browsertest.cc [modify] https://crrev.com/5da0d0d16f47b5f85fc74e95e377bb3597d7264e/chrome/browser/site_details_browsertest.cc
,
Sep 26
,
Nov 5
,
Nov 5
See https://bugs.chromium.org/p/chromium/issues/detail?id=898628#c14 for how to make this test flake reliably. [ RUN ] SiteDetailsBrowserTest.IsolateExtensions [216043:216043:1105/144730.471687:WARNING:password_store_factory.cc(261)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. [216043:216193:1105/144731.108967:ERROR:object_proxy.cc(621)] Failed to call method: org.freedesktop.Notifications.GetCapabilities: object_path= /org/freedesktop/Notifications: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.Notifications was not provided by any .service files [216043:216043:1105/144731.169994:WARNING:gaia_auth_fetcher.cc(858)] Could not reach Google Accounts servers: errno -102 [216043:216043:1105/144731.444369:INFO:CONSOLE(1)] "Extension One running", source: chrome-extension://kbgoafgdfgppgcajmoikgdobonjoahik/script.js (1) [216043:216043:1105/144731.987236:WARNING:gaia_auth_fetcher.cc(858)] Could not reach Google Accounts servers: errno -102 [216043:216256:1105/144732.721547:WARNING:embedded_test_server.cc(239)] Request not handled. Returning 404: /favicon.ico [216043:216043:1105/144734.489032:WARNING:gaia_auth_fetcher.cc(858)] Could not reach Google Accounts servers: errno -102 ../../chrome/browser/site_details_browsertest.cc:674: Failure Value of: GetRenderProcessCount() Expected: (under --site-per-process) 6 Actual: 7 Stack trace: #0 0x0000027b3d9c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x0000027b3769 testing::internal::AssertHelper::operator=() #2 0x0000019ab57b SiteDetailsBrowserTest_IsolateExtensions_Test::RunTestOnMainThread() #3 0x000003653d02 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #4 0x0000030a2fe6 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #5 0x0000030a1c45 ChromeBrowserMainParts::PreMainMessageLoopRun() #6 0x7fe8bfe6756a content::BrowserMainLoop::PreMainMessageLoopRun() #7 0x7fe8c03ae035 content::StartupTaskRunner::RunAllTasksNow() #8 0x7fe8bfe660ae content::BrowserMainLoop::CreateStartupTasks() #9 0x7fe8bfe6a1ed content::BrowserMainRunnerImpl::Initialize() #10 0x7fe8bfe63972 content::BrowserMain() #11 0x7fe8c09ab678 content::ContentMainRunnerImpl::RunServiceManager() #12 0x7fe8c09ab519 content::ContentMainRunnerImpl::Run() #13 0x7fe8b39fc3e9 service_manager::Main() #14 0x7fe8c09a9881 content::ContentMain() #15 0x00000365385d content::BrowserTestBase::SetUp() #16 0x00000303da92 InProcessBrowserTest::SetUp() ../../chrome/browser/site_details_browsertest.cc:700: Failure Value of: GetRenderProcessCount() Expected: (under --site-per-process) 5 Actual: 7 Stack trace: #0 0x0000027b3d9c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x0000027b3769 testing::internal::AssertHelper::operator=() #2 0x0000019ac0c0 SiteDetailsBrowserTest_IsolateExtensions_Test::RunTestOnMainThread() #3 0x000003653d02 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #4 0x0000030a2fe6 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #5 0x0000030a1c45 ChromeBrowserMainParts::PreMainMessageLoopRun() #6 0x7fe8bfe6756a content::BrowserMainLoop::PreMainMessageLoopRun() #7 0x7fe8c03ae035 content::StartupTaskRunner::RunAllTasksNow() #8 0x7fe8bfe660ae content::BrowserMainLoop::CreateStartupTasks() #9 0x7fe8bfe6a1ed content::BrowserMainRunnerImpl::Initialize() #10 0x7fe8bfe63972 content::BrowserMain() #11 0x7fe8c09ab678 content::ContentMainRunnerImpl::RunServiceManager() #12 0x7fe8c09ab519 content::ContentMainRunnerImpl::Run() #13 0x7fe8b39fc3e9 service_manager::Main() #14 0x7fe8c09a9881 content::ContentMain() #15 0x00000365385d content::BrowserTestBase::SetUp() #16 0x00000303da92 InProcessBrowserTest::SetUp() ../../chrome/browser/site_details_browsertest.cc:725: Failure Value of: GetRenderProcessCount() Expected: (under --site-per-process) 5 Actual: 6 Stack trace: #0 0x0000027b3d9c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x0000027b3769 testing::internal::AssertHelper::operator=() #2 0x0000019acc21 SiteDetailsBrowserTest_IsolateExtensions_Test::RunTestOnMainThread() #3 0x000003653d02 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #4 0x0000030a2fe6 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #5 0x0000030a1c45 ChromeBrowserMainParts::PreMainMessageLoopRun() #6 0x7fe8bfe6756a content::BrowserMainLoop::PreMainMessageLoopRun() #7 0x7fe8c03ae035 content::StartupTaskRunner::RunAllTasksNow() #8 0x7fe8bfe660ae content::BrowserMainLoop::CreateStartupTasks() #9 0x7fe8bfe6a1ed content::BrowserMainRunnerImpl::Initialize() #10 0x7fe8bfe63972 content::BrowserMain() #11 0x7fe8c09ab678 content::ContentMainRunnerImpl::RunServiceManager() #12 0x7fe8c09ab519 content::ContentMainRunnerImpl::Run() #13 0x7fe8b39fc3e9 service_manager::Main() #14 0x7fe8c09a9881 content::ContentMain() #15 0x00000365385d content::BrowserTestBase::SetUp() #16 0x00000303da92 InProcessBrowserTest::SetUp() [216043:216043:1105/144736.152429:WARNING:render_frame_host_impl.cc(474)] InterfaceRequest was dropped, the document is no longer active: content.mojom.RendererAudioOutputStreamFactory [216043:216043:1105/144736.152539:WARNING:render_frame_host_impl.cc(474)] InterfaceRequest was dropped, the document is no longer active: resource_coordinator.mojom.FrameCoordinationUnit ../../chrome/browser/site_details_browsertest.cc:750: Failure Value of: GetRenderProcessCount() Expected: (under --site-per-process) 4 Actual: 6 Stack trace: #0 0x0000027b3d9c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x0000027b3769 testing::internal::AssertHelper::operator=() #2 0x0000019ad781 SiteDetailsBrowserTest_IsolateExtensions_Test::RunTestOnMainThread() #3 0x000003653d02 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #4 0x0000030a2fe6 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #5 0x0000030a1c45 ChromeBrowserMainParts::PreMainMessageLoopRun() #6 0x7fe8bfe6756a content::BrowserMainLoop::PreMainMessageLoopRun() #7 0x7fe8c03ae035 content::StartupTaskRunner::RunAllTasksNow() #8 0x7fe8bfe660ae content::BrowserMainLoop::CreateStartupTasks() #9 0x7fe8bfe6a1ed content::BrowserMainRunnerImpl::Initialize() #10 0x7fe8bfe63972 content::BrowserMain() #11 0x7fe8c09ab678 content::ContentMainRunnerImpl::RunServiceManager() #12 0x7fe8c09ab519 content::ContentMainRunnerImpl::Run() #13 0x7fe8b39fc3e9 service_manager::Main() #14 0x7fe8c09a9881 content::ContentMain() #15 0x00000365385d content::BrowserTestBase::SetUp() #16 0x00000303da92 InProcessBrowserTest::SetUp() [216043:216043:1105/144736.603195:WARNING:render_frame_host_impl.cc(474)] InterfaceRequest was dropped, the document is no longer active: content.mojom.RendererAudioOutputStreamFactory [216043:216043:1105/144736.603273:WARNING:render_frame_host_impl.cc(474)] InterfaceRequest was dropped, the document is no longer active: resource_coordinator.mojom.FrameCoordinationUnit ../../chrome/browser/site_details_browsertest.cc:767: Failure Value of: details->uma()->GetAllSamples( "SiteIsolation.CurrentRendererProcessCount") Expected: has 1 element that is a Bucket whose count is 1 and whose value is 5 Actual: { Bucket 4: 1 }, whose element #0 doesn't match Stack trace: #0 0x0000027b3d9c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x0000027b3769 testing::internal::AssertHelper::operator=() #2 0x0000019adbd5 SiteDetailsBrowserTest_IsolateExtensions_Test::RunTestOnMainThread() #3 0x000003653d02 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #4 0x0000030a2fe6 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #5 0x0000030a1c45 ChromeBrowserMainParts::PreMainMessageLoopRun() #6 0x7fe8bfe6756a content::BrowserMainLoop::PreMainMessageLoopRun() #7 0x7fe8c03ae035 content::StartupTaskRunner::RunAllTasksNow() #8 0x7fe8bfe660ae content::BrowserMainLoop::CreateStartupTasks() #9 0x7fe8bfe6a1ed content::BrowserMainRunnerImpl::Initialize() #10 0x7fe8bfe63972 content::BrowserMain() #11 0x7fe8c09ab678 content::ContentMainRunnerImpl::RunServiceManager() #12 0x7fe8c09ab519 content::ContentMainRunnerImpl::Run() #13 0x7fe8b39fc3e9 service_manager::Main() #14 0x7fe8c09a9881 content::ContentMain() #15 0x00000365385d content::BrowserTestBase::SetUp() #16 0x00000303da92 InProcessBrowserTest::SetUp() ../../chrome/browser/site_details_browsertest.cc:780: Failure Value of: GetRenderProcessCount() Expected: (under --site-per-process) 4 Actual: 5 Stack trace: #0 0x0000027b3d9c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x0000027b3769 testing::internal::AssertHelper::operator=() #2 0x0000019ae2ff SiteDetailsBrowserTest_IsolateExtensions_Test::RunTestOnMainThread() #3 0x000003653d02 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #4 0x0000030a2fe6 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #5 0x0000030a1c45 ChromeBrowserMainParts::PreMainMessageLoopRun() #6 0x7fe8bfe6756a content::BrowserMainLoop::PreMainMessageLoopRun() #7 0x7fe8c03ae035 content::StartupTaskRunner::RunAllTasksNow() #8 0x7fe8bfe660ae content::BrowserMainLoop::CreateStartupTasks() #9 0x7fe8bfe6a1ed content::BrowserMainRunnerImpl::Initialize() #10 0x7fe8bfe63972 content::BrowserMain() #11 0x7fe8c09ab678 content::ContentMainRunnerImpl::RunServiceManager() #12 0x7fe8c09ab519 content::ContentMainRunnerImpl::Run() #13 0x7fe8b39fc3e9 service_manager::Main() #14 0x7fe8c09a9881 content::ContentMain() #15 0x00000365385d content::BrowserTestBase::SetUp() #16 0x00000303da92 InProcessBrowserTest::SetUp() [216149:216149:1105/144737.902373:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1 [216149:216149:1105/144737.902423:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1 [216149:216149:1105/144737.902443:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1 [216149:216149:1105/144737.902459:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1 [216149:216149:1105/144737.902480:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1 [216149:216149:1105/144737.902496:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1 [216149:216149:1105/144737.902512:WARNING:ipc_message_attachment_set.cc(49)] MessageAttachmentSet destroyed with unconsumed attachments: 0/1 [216043:216043:1105/144737.908701:WARNING:render_frame_host_impl.cc(474)] InterfaceRequest was dropped, the document is no longer active: content.mojom.RendererAudioOutputStreamFactory [216043:216043:1105/144737.908779:WARNING:render_frame_host_impl.cc(474)] InterfaceRequest was dropped, the document is no longer active: resource_coordinator.mojom.FrameCoordinationUnit ../../chrome/browser/site_details_browsertest.cc:820: Failure Value of: details->uma()->GetAllSamples( "SiteIsolation.CurrentRendererProcessCount") Expected: has 1 element that is a Bucket whose count is 1 and whose value is 4 Actual: { Bucket 3: 1 }, whose element #0 doesn't match Stack trace: #0 0x0000027b3d9c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x0000027b3769 testing::internal::AssertHelper::operator=() #2 0x0000019af203 SiteDetailsBrowserTest_IsolateExtensions_Test::RunTestOnMainThread() #3 0x000003653d02 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #4 0x0000030a2fe6 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #5 0x0000030a1c45 ChromeBrowserMainParts::PreMainMessageLoopRun() #6 0x7fe8bfe6756a content::BrowserMainLoop::PreMainMessageLoopRun() #7 0x7fe8c03ae035 content::StartupTaskRunner::RunAllTasksNow() #8 0x7fe8bfe660ae content::BrowserMainLoop::CreateStartupTasks() #9 0x7fe8bfe6a1ed content::BrowserMainRunnerImpl::Initialize() #10 0x7fe8bfe63972 content::BrowserMain() #11 0x7fe8c09ab678 content::ContentMainRunnerImpl::RunServiceManager() #12 0x7fe8c09ab519 content::ContentMainRunnerImpl::Run() #13 0x7fe8b39fc3e9 service_manager::Main() #14 0x7fe8c09a9881 content::ContentMain() #15 0x00000365385d content::BrowserTestBase::SetUp() #16 0x00000303da92 InProcessBrowserTest::SetUp() ../../chrome/browser/site_details_browsertest.cc:833: Failure Value of: GetRenderProcessCount() Expected: (under --site-per-process) 3 Actual: 4 Stack trace: #0 0x0000027b3d9c testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop() #1 0x0000027b3769 testing::internal::AssertHelper::operator=() #2 0x0000019af937 SiteDetailsBrowserTest_IsolateExtensions_Test::RunTestOnMainThread() #3 0x000003653d02 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #4 0x0000030a2fe6 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #5 0x0000030a1c45 ChromeBrowserMainParts::PreMainMessageLoopRun() #6 0x7fe8bfe6756a content::BrowserMainLoop::PreMainMessageLoopRun() #7 0x7fe8c03ae035 content::StartupTaskRunner::RunAllTasksNow() #8 0x7fe8bfe660ae content::BrowserMainLoop::CreateStartupTasks() #9 0x7fe8bfe6a1ed content::BrowserMainRunnerImpl::Initialize() #10 0x7fe8bfe63972 content::BrowserMain() #11 0x7fe8c09ab678 content::ContentMainRunnerImpl::RunServiceManager() #12 0x7fe8c09ab519 content::ContentMainRunnerImpl::Run() #13 0x7fe8b39fc3e9 service_manager::Main() #14 0x7fe8c09a9881 content::ContentMain() #15 0x00000365385d content::BrowserTestBase::SetUp() #16 0x00000303da92 InProcessBrowserTest::SetUp() [216043:216127:1105/144739.170902:WARNING:discardable_shared_memory_manager.cc(409)] Some MojoDiscardableSharedMemoryManagerImpls are still alive. They will be leaked. [216043:216043:1105/144739.174031:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. [216043:216043:1105/144739.174073:WARNING:pref_notifier_impl.cc(23)] Pref observer found at shutdown. [216043:216447:1105/144739.184832:WARNING:internal_linux.cc(64)] Failed to read /proc/216149/stat [ FAILED ] SiteDetailsBrowserTest.IsolateExtensions, where TypeParam = and GetParam() = (10372 ms)
,
Nov 5
From the CL to disable.
danakj -------------
I tried sticking a RenderFrameHostDeletedObserver around the:
content::NavigateIframeToURL(
tab1, "child-0", extension1->GetResourceURL("/blank_iframe.html"));
for the |tab1| RenderFrameHost, but that was not the right solution, it needs to wait for the IFrame's RenderFrameHost, which I am not sure how to get easily. The test code does
std::string script = base::StringPrintf(
"setTimeout(\""
"var iframes = document.getElementById('%s');iframes.src='%s';"
"\",0)",
iframe_id.c_str(), url.spec().c_str());
Which doesn't help me.. I don't see anything on RenderFrameHost to help unless I know the frames |id| (as an integer not the string used above).
creis -------------
That does seem like a tricky thing to get at the moment, unfortunately. I feel like we might want to add a test utility that approximates getElementById but I don't see a great way to do it. lfg@ suggests using frame names instead of IDs, since names are replicated to the browser process on the FTN. Not sure how feasible that is for 161 calls to NavigateIframeToURL, though.
This CL LGTM to deal with the flakiness in the short term, but the best plan for re-enabling it may be revising at least this test to use named frames so that we can listen for the right RenderFrameHost to be deleted.
(Or maybe there's a way to have a more general RenderFrameHostDeletedObserver that listens for any RFH in a WebContents to be deleted, but that may be flaky on its own if other frames disappear unexpectedly.)
,
Nov 5
,
Nov 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d018b463569b50996e15ccc51fe5c9095e78a65 commit 0d018b463569b50996e15ccc51fe5c9095e78a65 Author: danakj <danakj@chromium.org> Date: Mon Nov 05 21:08:18 2018 Disable flaky SiteDetailsBrowserTest.IsolateExtensions test. R=creis@chromium.org, nasko@chromium.org Change-Id: I8dbff259878a72e89efe802a1a4d83b78b394dd9 Bug: 671891 Reviewed-on: https://chromium-review.googlesource.com/c/1318408 Reviewed-by: Charlie Reis <creis@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#605464} [modify] https://crrev.com/0d018b463569b50996e15ccc51fe5c9095e78a65/chrome/browser/site_details_browsertest.cc |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by yosin@chromium.org
, Dec 7 2016Owner: nasko@chromium.org
Status: Assigned (was: Untriaged)
nasko@, could you take look since you touch SiteDetailsBrowserTest.IsolateExtensions? Please help to identify root cause of this flakyness. l: { Bucket 2: 1 }, whose element #0 doesn't match e:\c\win\src\chromerowser\site_details_browsertest.cc(904): error: Value of: GetRenderProcessCount() Expected: (with oopifs disabled) 2 Actual: 3 [ FAILED ] SiteDetailsBrowserTest.IsolateExtensions, where TypeParam = and GetParam() = (5792 ms)