New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 671867 link

Starred by 2 users
Status: Fixed
Owner:
█ lushnikov@chromium.org
Last visit 29 days ago
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Modified styles in custom element shadow root should reflect across all instances of that custom element

Project Member Reported by tjsavage@chromium.org, Dec 7 2016 
Each instance of a particular custom element with an associated shadow root must currently copy a stylesheet into its shadow root. The same stylesheet is usually copied across all instances of the element.

Modifications made to properties in this stylesheet in DevTools should ideally reflect across all of the instances of thee custom elements that share this stylesheet, rather than just the single custom element being modified.

Comment 1 by paulir...@chromium.org, Dec 14 2016

Components: -Platform>DevTools Platform>DevTools>Authoring
Labels: -Pri-3 Pri-2
Owner: lushnikov@chromium.org
Status: Assigned (was: Untriaged)
Yeah this is really painful. I face it in DevTools and every web component app.
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/051c8e924b31fc3939604392284bfe2ff8e15361

commit 051c8e924b31fc3939604392284bfe2ff8e15361
Author: lushnikov <lushnikov@chromium.org>
Date: Mon Mar 27 21:23:03 2017

DevTools: add bindings tests to fixate shadowDOM behavior.

This patch adds two tests to fixate our handling of ShadowDOM
in bindings and navigator.
- shadowdom-bindings.html - illustrates shadowDOM handling by
  varioius bindings
- shadowdom-navigator.html - illustrates navigator behavior

The shadowdom-bindings.html shows the root cause of the problem
which we have in  crbug.com/671867 .

BUG= 671867 ,670180
R=dgozman

Review-Url: https://codereview.chromium.org/2777633002
Cr-Commit-Position: refs/heads/master@{#459883}

[modify] https://crrev.com/051c8e924b31fc3939604392284bfe2ff8e15361/third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-test.js
[add] https://crrev.com/051c8e924b31fc3939604392284bfe2ff8e15361/third_party/WebKit/LayoutTests/http/tests/inspector/bindings/shadowdom-bindings-expected.txt
[add] https://crrev.com/051c8e924b31fc3939604392284bfe2ff8e15361/third_party/WebKit/LayoutTests/http/tests/inspector/bindings/shadowdom-bindings.html
[add] https://crrev.com/051c8e924b31fc3939604392284bfe2ff8e15361/third_party/WebKit/LayoutTests/http/tests/inspector/bindings/shadowdom-navigator-expected.txt
[add] https://crrev.com/051c8e924b31fc3939604392284bfe2ff8e15361/third_party/WebKit/LayoutTests/http/tests/inspector/bindings/shadowdom-navigator.html
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5b8d597dda99a31ae014519984d51c994f3f55d

commit c5b8d597dda99a31ae014519984d51c994f3f55d
Author: lushnikov <lushnikov@chromium.org>
Date: Tue Jun 13 21:57:29 2017

DevTools: make StyleSourceMapping in charge of managing UISourceCodes

This patch:
- move style-related UISourceCode management from NetworkProject into
  StylesSourceMapping
- create only a single UISourceCode per target for css header

As a result, all the headers are synced perfectly across shadow roots
and frames.

BUG= 671867 ,670180
R=dgozman

Review-Url: https://codereview.chromium.org/2893523002
Cr-Commit-Position: refs/heads/master@{#479168}

[modify] https://crrev.com/c5b8d597dda99a31ae014519984d51c994f3f55d/third_party/WebKit/LayoutTests/http/tests/inspector/bindings/bindings-multiple-frames-expected.txt
[modify] https://crrev.com/c5b8d597dda99a31ae014519984d51c994f3f55d/third_party/WebKit/LayoutTests/http/tests/inspector/bindings/shadowdom-bindings-expected.txt
[modify] https://crrev.com/c5b8d597dda99a31ae014519984d51c994f3f55d/third_party/WebKit/LayoutTests/http/tests/inspector/bindings/shadowdom-navigator-expected.txt
[modify] https://crrev.com/c5b8d597dda99a31ae014519984d51c994f3f55d/third_party/WebKit/LayoutTests/http/tests/inspector/bindings/sourcemap-bindings-multiple-frames-expected.txt
[modify] https://crrev.com/c5b8d597dda99a31ae014519984d51c994f3f55d/third_party/WebKit/LayoutTests/http/tests/inspector/bindings/suspendtarget-bindings-expected.txt
[modify] https://crrev.com/c5b8d597dda99a31ae014519984d51c994f3f55d/third_party/WebKit/LayoutTests/http/tests/inspector/persistence/persistence-do-not-overwrite-css.html
[modify] https://crrev.com/c5b8d597dda99a31ae014519984d51c994f3f55d/third_party/WebKit/LayoutTests/inspector/elements/styles-1/edit-resource-referred-by-multiple-styletags-expected.txt
[modify] https://crrev.com/c5b8d597dda99a31ae014519984d51c994f3f55d/third_party/WebKit/LayoutTests/inspector/elements/styles-1/edit-resource-referred-by-multiple-styletags.html
[add] https://crrev.com/c5b8d597dda99a31ae014519984d51c994f3f55d/third_party/WebKit/LayoutTests/inspector/elements/styles-1/resources/frame.html
[modify] https://crrev.com/c5b8d597dda99a31ae014519984d51c994f3f55d/third_party/WebKit/LayoutTests/inspector/elements/styles-4/styles-history.html
[modify] https://crrev.com/c5b8d597dda99a31ae014519984d51c994f3f55d/third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js
[modify] https://crrev.com/c5b8d597dda99a31ae014519984d51c994f3f55d/third_party/WebKit/Source/devtools/front_end/bindings/ResourceUtils.js
[modify] https://crrev.com/c5b8d597dda99a31ae014519984d51c994f3f55d/third_party/WebKit/Source/devtools/front_end/bindings/StylesSourceMapping.js

Comment 4 by lushnikov@chromium.org, Jun 14 2017

Status: Fixed (was: Assigned)

Comment 5 by kayce@google.com, Jul 6 2017

Labels: DevTools-Release-Notes-61 DevTools-Release-Notes-Change
►

Sign in to add a comment