New issue
Advanced search Search tips

Issue 671864 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix PaintLayerTest CompositedBoundsAbsPosGrandchild for SPv2.

Project Member Reported by chrishtr@chromium.org, Dec 7 2016

Issue description

see above.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/013d385f0e25567c5f91eb440e5d5c092e1bb0e1

commit 013d385f0e25567c5f91eb440e5d5c092e1bb0e1
Author: chrishtr <chrishtr@chromium.org>
Date: Sat Jan 14 00:49:21 2017

Fix paint offset and clips in SPv2.

Previously we neglected to adjust for the paint offset of a LayoutObject within
its transform space. Furthermore, we had some corner-case bugs in clipping.

The former is tested by the newly added test as well as
PaintLayerTest.CompositedBoundsAbsPosGrandchild. The latter is tested by
three of the existing PaintLayerClipper tests.

BUG= 671864 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2621243002
Cr-Commit-Position: refs/heads/master@{#443743}

[modify] https://crrev.com/013d385f0e25567c5f91eb440e5d5c092e1bb0e1/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/013d385f0e25567c5f91eb440e5d5c092e1bb0e1/third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp
[modify] https://crrev.com/013d385f0e25567c5f91eb440e5d5c092e1bb0e1/third_party/WebKit/Source/core/paint/PaintLayerClipper.h
[modify] https://crrev.com/013d385f0e25567c5f91eb440e5d5c092e1bb0e1/third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp
[modify] https://crrev.com/013d385f0e25567c5f91eb440e5d5c092e1bb0e1/third_party/WebKit/Source/core/paint/PaintLayerTest.cpp
[modify] https://crrev.com/013d385f0e25567c5f91eb440e5d5c092e1bb0e1/third_party/WebKit/Source/platform/graphics/paint/GeometryMapper.h

Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e

commit e79d590e48fe32e1691b05d0fac27ebdd1f7c79e
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Thu Jan 19 00:40:54 2017

Auto-rebaseline for r444532

https://chromium.googlesource.com/chromium/src/+/b54db9226dbbd

BUG= 671864 
TBR=chrishtr@chromium.org

Review-Url: https://codereview.chromium.org/2641913004 .
Cr-Commit-Position: refs/heads/master@{#444569}

[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/linux/fast/forms/number/number-appearance-spinbutton-layer-expected.txt
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/linux/fast/forms/placeholder-position-expected.png
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/linux/fast/forms/placeholder-position-expected.txt
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/linux/fast/forms/select-popup/popup-menu-appearance-transform-expected.png
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/linux/fast/multicol/multicol-with-child-renderLayer-for-input-expected.txt
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/placeholder-position-expected.png
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/placeholder-position-expected.txt
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/forms/text/input-appearance-preventDefault-expected.txt
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/multicol/multicol-with-child-renderLayer-for-input-expected.txt
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/number/number-appearance-spinbutton-layer-expected.txt
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/placeholder-position-expected.png
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/placeholder-position-expected.txt
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/forms/text/input-appearance-preventDefault-expected.txt
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/multicol/multicol-with-child-renderLayer-for-input-expected.txt
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.txt
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/mac/fast/forms/placeholder-position-expected.png
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/mac/fast/forms/placeholder-position-expected.txt
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/mac/fast/forms/text/input-appearance-preventDefault-expected.txt
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/mac/fast/multicol/multicol-with-child-renderLayer-for-input-expected.txt
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/win/fast/forms/number/number-appearance-spinbutton-layer-expected.txt
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/win/fast/forms/placeholder-position-expected.png
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/win/fast/forms/placeholder-position-expected.txt
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/win/fast/forms/select-popup/popup-menu-appearance-transform-expected.png
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/win/fast/forms/text/input-appearance-preventDefault-expected.txt
[modify] https://crrev.com/e79d590e48fe32e1691b05d0fac27ebdd1f7c79e/third_party/WebKit/LayoutTests/platform/win/fast/multicol/multicol-with-child-renderLayer-for-input-expected.txt

Sign in to add a comment