Pre-cq commitbot posts broken links to CLs
Reported by
jrbarnette@chromium.org,
Dec 7 2016
|
|||||||||
Issue description
Look at this CL (for reference):
https://chromium-review.googlesource.com/#/c/416323/
Commit Bot posted 3 comments to the CL regarding Pre-CQ test
runs. Those comments contain broken links of the form
https://luci-milo.appspot.com/buildbot/https://uberchromegw.corp.google.com/...
Here's sample text from the first comment:
====
The Pre-Commit Queue has picked up your change. You can follow along at
(strago-pre-cq) : https://luci-milo.appspot.com/buildbot/https://uberchromegw.corp.google.com/i/chromiumos.tryserver/pre_cq/9579
(smaug-pre-cq) : https://luci-milo.appspot.com/buildbot/https://uberchromegw.corp.google.com/i/chromiumos.tryserver/pre_cq/9582
(oak-pre-cq) : https://luci-milo.appspot.com/buildbot/https://uberchromegw.corp.google.com/i/chromiumos.tryserver/pre_cq/9580
(glados-pre-cq) : https://luci-milo.appspot.com/buildbot/https://uberchromegw.corp.google.com/i/chromiumos.tryserver/pre_cq/9581 .
Commit queue documentation: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium-os/commit-queue-overview
===
,
Dec 7 2016
The bad CLs are a product of this CL:
https://chromium-review.googlesource.com/#/c/413003/
,
Dec 7 2016
,
Dec 7 2016
,
Dec 7 2016
,
Dec 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/0d89522c6f7140f105b3d6dc5c16c364993facf8 commit 0d89522c6f7140f105b3d6dc5c16c364993facf8 Author: Don Garrett <dgarrett@google.com> Date: Wed Dec 07 01:21:56 2016 PreCQLuancherStage: Correctly link to milo for PreCQ builds. We were using the dashboard URL, not the waterfall name when constructing URLs for PreCQ tryjobs, which was no longer correct. BUG= chromium:671861 TEST=None. Sadly, there are no unittests. Change-Id: I48be754f25b7de35f7a8d90663dd634e56e9c021 Reviewed-on: https://chromium-review.googlesource.com/417406 Tested-by: Don Garrett <dgarrett@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org> Commit-Queue: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/0d89522c6f7140f105b3d6dc5c16c364993facf8/cbuildbot/stages/sync_stages.py
,
Dec 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/35a384ffea50b8b36bca0bf90e207f54b970128d commit 35a384ffea50b8b36bca0bf90e207f54b970128d Author: Don Garrett <dgarrett@google.com> Date: Wed Dec 07 01:38:13 2016 report_stages: Fix milo links in build slaves. We were using DASHBOARD urls instead of waterfall names when constructing a dashboard URL, which is no longer correct. BUG= chromium:671861 TEST=None Change-Id: Ib3a2d34741646253d11fe94d94b804f111dccba5 Reviewed-on: https://chromium-review.googlesource.com/417108 Tested-by: Don Garrett <dgarrett@chromium.org> Tested-by: Prathmesh Prabhu <pprabhu@chromium.org> Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org> Commit-Queue: Prathmesh Prabhu <pprabhu@chromium.org> Commit-Queue: Don Garrett <dgarrett@chromium.org> Trybot-Ready: Prathmesh Prabhu <pprabhu@chromium.org> [modify] https://crrev.com/35a384ffea50b8b36bca0bf90e207f54b970128d/cbuildbot/stages/report_stages.py
,
Dec 7 2016
The PreCQ links are now fixed. Waiting to see about the build slave report links.
,
Dec 8 2016
They also seem to be working.
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by jrbarnette@chromium.org
, Dec 7 2016You can hand-edit the URLs to this form: https://luci-milo.appspot.com/buildbot/chromiumos.tryserver/pre_cq/9579 That URL works (though it may give a 403 error for many users).