New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 671859 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Dec 2016
Cc:
█ smut@chromium.org
rmis...@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Can't edit issue description in Gerrit

Project Member Reported by kbr@chromium.org, Dec 7 2016 
In https://chromium-review.googlesource.com/417186/ :

1) Using 'git commit --amend' to update the issue description locally combined with 'git cl upload' does not edit the issue description.

2) Clicking 'edit description' yields the following in the console:

gerrit_ui-0.js:3696 Tue Dec 06 16:47:51 GMT-800 2016 Class$840
SEVERE: (TypeError) : Cannot read property 'alert' of null
Class$S215: (TypeError) : Cannot read property 'alert' of null
	at Unknown.gP(gerrit_ui-0.js)
	at Unknown.iP(gerrit_ui-0.js)
	at Unknown.VHb(gerrit_ui-0.js)
	at Unknown.YHb(gerrit_ui-0.js)
	at Unknown.Bbc(gerrit_ui-0.js)
	at Unknown.Vbc(gerrit_ui-0.js)
	at Unknown.eval(gerrit_ui-0.js)
	at Unknown.I1b(gerrit_ui-0.js)
	at Unknown.L1b(gerrit_ui-0.js)
	at Unknown.eval(gerrit_ui-0.js)

The combination of these two issues make it impossible to edit an issue's description.

Comment 1 by kbr@chromium.org, Dec 7 2016

Cc: smut@chromium.org
Labels: -Pri-1 Pri-2
Sana pointed out that:

1) I (likely) didn't copy/paste the Change-Id into my local issue description, so I re-uploaded to a different issue. Not sure if this behavior is different from (for example) ANGLE's gerrit instance, but this should be more automatic. (The Change-Id should be added automatically into the log.)

2) There's an insane workflow involving "Edit" -> "Commit Message" -> edit it -> "Save" -> "Close" -> "Done editing" which does actually work for this purpose. This needs to be improved.

Comment 2 by kbr@chromium.org, Dec 7 2016 

One more note: I did in fact neglect to copy/paste the Change-Id from the already-uploaded issue when doing "git cl upload" again. However, the update I pushed via "git cl upload" claimed that it went to https://chromium-review.googlesource.com/417186/ , when in fact it went into the bit bucket.

Comment 3 by s...@google.com, Dec 7 2016 

Actually I just realized the edit workflow is streamlined on PolyGerrit.

https://chromium-review.googlesource.com/?polygerrit=1#/c/417186/

There is an "Edit" link right below the description which lets you edit it in place instead of having to click 239082343 buttons like on the old UI.

Comment 4 by s...@google.com, Dec 7 2016 

I use "git push origin HEAD:refs/for/master" after doing git commit --amend. The Change-Id will be used to detect that it's a new patchset for an existing issue.

But I agree that "git cl upload" should just be doing all this for you.

Comment 5 by kbr@chromium.org, Dec 7 2016

Summary: Can't edit issue description in Gerrit (was: Can't edit issue description in PolyGerrit)
Sorry, I misunderstood whether I was looking at Gerrit or PolyGerrit. I was using vanilla Gerrit. Corrected this issue's summary.

Comment 6 by andyb...@chromium.org, Dec 12 2016

Status: Fixed (was: Untriaged)
The issue of editing a description has been fixed in Gerrit. Now it just needs to be rolled out.
►

Sign in to add a comment