New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 671848 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Schedule tryjob requests via buildbucket

Project Member Reported by dgarr...@chromium.org, Dec 7 2016

Issue description

It we want to view tryjob results via milo, we need to schedule those jobs via buildbucket.

That can be done today using a command line of the form:

  cbuildbot --remote --use-buildbucket lumpy-paladin

This does NOT stop us from needing to sync tryjobs (https://chrome-internal.googlesource.com/chromeos/tryjobs
), since the manifest to build still needs to be submitted there (for now).

Making buildbucket the default DOES require us to keep buildbucket permissions in sync with the trybot submission permissions.
 

Comment 1 by autumn@chromium.org, Dec 13 2016

Cc: nxia@chromium.org dgarr...@chromium.org
don, are you or ningning the best owner for this? 
Owner: dgarr...@chromium.org
Both of us are reasonable choices. I want to use it to force myself to learn buildbucket permissions in detail.
Labels: -current-issue
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/cf7c1f92eacdafec8c566b6177711bb3b62950a7

commit cf7c1f92eacdafec8c566b6177711bb3b62950a7
Author: Don Garrett <dgarrett@google.com>
Date: Fri Mar 31 02:33:10 2017

cbuildbot: Use buildbucket for remote tryjobs by default.

Remove --use-buildbucket option, and replace it with
--do-not-use-buildbucket option.

We want to use bucketbucket to schedule all tryjobs by default. We
haven't been able to find out for certain if there is anyone who needs
buildbucket permissions for this that doesn't already have them,
so.... let's find out!

There will be a PSA sent out before this lands asking for feedback
from anyone required to use --do-not-use-buildbucket to run a tryjob.

BUG= chromium:671848 
TEST=run_tests

Change-Id: Ia3006d892d12fa87c79d5defe17129b0b2639e1d
Reviewed-on: https://chromium-review.googlesource.com/462518
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/cf7c1f92eacdafec8c566b6177711bb3b62950a7/scripts/cbuildbot.py

Project Member

Comment 5 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/43d2d6876cef5a59f29c9c5d5fd5016716b29021

commit 43d2d6876cef5a59f29c9c5d5fd5016716b29021
Author: Ningning Xia <nxia@chromium.org>
Date: Fri Mar 31 02:50:26 2017

Revert "cbuildbot: Use buildbucket for remote tryjobs by default."

This reverts commit cf7c1f92eacdafec8c566b6177711bb3b62950a7.

Reason for revert: <INSERT REASONING HERE>

Original change's description:
> cbuildbot: Use buildbucket for remote tryjobs by default.
> 
> Remove --use-buildbucket option, and replace it with
> --do-not-use-buildbucket option.
> 
> We want to use bucketbucket to schedule all tryjobs by default. We
> haven't been able to find out for certain if there is anyone who needs
> buildbucket permissions for this that doesn't already have them,
> so.... let's find out!
> 
> There will be a PSA sent out before this lands asking for feedback
> from anyone required to use --do-not-use-buildbucket to run a tryjob.
> 
> BUG= chromium:671848 
> TEST=run_tests
> 
> Change-Id: Ia3006d892d12fa87c79d5defe17129b0b2639e1d
> Reviewed-on: https://chromium-review.googlesource.com/462518
> Commit-Ready: Don Garrett <dgarrett@chromium.org>
> Tested-by: Don Garrett <dgarrett@chromium.org>
> Reviewed-by: Ningning Xia <nxia@chromium.org>
> 

TBR=dgarrett@chromium.org,nxia@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:671848 

Change-Id: I271e898225706b83ac030288897fae0f3baca9ee
Reviewed-on: https://chromium-review.googlesource.com/464309
Reviewed-by: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/43d2d6876cef5a59f29c9c5d5fd5016716b29021/scripts/cbuildbot.py

What broke?

Comment 7 by nxia@chromium.org, Mar 31 2017

It broke the pre-cq-launcher. I forgot the pre-cq-launcher was using --use-buildbucket option when I reviewed the CL. my fault.

https://luci-logdog.appspot.com/v/?s=chromeos%2Fbb%2Fchromeos%2Fpre-cq-launcher%2F8901%2F%2B%2Frecipes%2Fsteps%2FPreCQLauncher%2F0%2Fstdout


RunCommandError: return code: 2; command: cbuildbot --remote --timeout 14400 daisy_spring-no-vmtest-pre-cq x86-alex-no-vmtest-pre-cq rambi-no-vmtest-pre-cq whirlwind-no-vmtest-pre-cq lumpy-no-vmtest-pre-cq samus-no-vmtest-pre-cq caroline-pre-cq -g 464167 --use-buildbucket
Usage: cbuildbot [options] buildbot_config [buildbot_config ...]

cbuildbot: error: no such option: --use-buildbucket
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/fee287427456fba157a9d56fec9acb60898e4e8e

commit fee287427456fba157a9d56fec9acb60898e4e8e
Author: Don Garrett <dgarrett@google.com>
Date: Tue Apr 04 02:09:26 2017

cbuildbot: Use buildbucket for remote tryjobs by default.

Remove --use-buildbucket option, and replace it with
--do-not-use-buildbucket option.

We want to use bucketbucket to schedule all tryjobs by default. We
haven't been able to find out for certain if there is anyone who needs
buildbucket permissions for this that doesn't already have them,
so.... let's find out!

A PSA has been sent out asking for feedback from anyone required to
use --do-not-use-buildbucket to run a tryjob.

This CL was submitted as CL:462518, and reverted as CL:464309.

BUG= chromium:671848 
TEST=run_tests

Change-Id: I92f9137aa7cd4807a2b9006f357bf2189c2c0767
Reviewed-on: https://chromium-review.googlesource.com/465488
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/fee287427456fba157a9d56fec9acb60898e4e8e/scripts/cbuildbot.py
[modify] https://crrev.com/fee287427456fba157a9d56fec9acb60898e4e8e/cbuildbot/stages/sync_stages.py

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/db7cb5e5c24ed2847d61a25d1fbc516620ac3a32

commit db7cb5e5c24ed2847d61a25d1fbc516620ac3a32
Author: Chun-ta Lin <itspeter@chromium.org>
Date: Tue Apr 04 05:01:30 2017

Revert "cbuildbot: Use buildbucket for remote tryjobs by default."

This reverts commit fee287427456fba157a9d56fec9acb60898e4e8e.

Reason for revert: Break pre-cq-launcher #8925

Original change's description:
> cbuildbot: Use buildbucket for remote tryjobs by default.
> 
> Remove --use-buildbucket option, and replace it with
> --do-not-use-buildbucket option.
> 
> We want to use bucketbucket to schedule all tryjobs by default. We
> haven't been able to find out for certain if there is anyone who needs
> buildbucket permissions for this that doesn't already have them,
> so.... let's find out!
> 
> A PSA has been sent out asking for feedback from anyone required to
> use --do-not-use-buildbucket to run a tryjob.
> 
> This CL was submitted as CL:462518, and reverted as CL:464309.
> 
> BUG= chromium:671848 
> TEST=run_tests
> 
> Change-Id: I92f9137aa7cd4807a2b9006f357bf2189c2c0767
> Reviewed-on: https://chromium-review.googlesource.com/465488
> Commit-Ready: Don Garrett <dgarrett@chromium.org>
> Tested-by: Don Garrett <dgarrett@chromium.org>
> Reviewed-by: Ningning Xia <nxia@chromium.org>
> 

TBR=dgarrett@chromium.org,nxia@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= chromium:671848 

Change-Id: Ib690af4dc6efabdf4c2445657f3e0c31a9f9ff79
Reviewed-on: https://chromium-review.googlesource.com/467026
Reviewed-by: Chun-ta Lin <itspeter@chromium.org>
Commit-Queue: Chun-ta Lin <itspeter@chromium.org>
Tested-by: Chun-ta Lin <itspeter@chromium.org>
Trybot-Ready: Chun-ta Lin <itspeter@chromium.org>

[modify] https://crrev.com/db7cb5e5c24ed2847d61a25d1fbc516620ac3a32/scripts/cbuildbot.py
[modify] https://crrev.com/db7cb5e5c24ed2847d61a25d1fbc516620ac3a32/cbuildbot/stages/sync_stages.py

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/6b0cf682fb338ae216657c1f97682f4a52c7489f

commit 6b0cf682fb338ae216657c1f97682f4a52c7489f
Author: Don Garrett <dgarrett@google.com>
Date: Wed Apr 05 01:12:54 2017

cbuildbot: Use buildbucket for remote tryjobs by default.

Remove --use-buildbucket option, and replace it with
--do-not-use-buildbucket option.

We want to use bucketbucket to schedule all tryjobs by default. We
haven't been able to find out for certain if there is anyone who needs
buildbucket permissions for this that doesn't already have them,
so.... let's find out!

A PSA has been sent out asking for feedback from anyone required to
use --do-not-use-buildbucket to run a tryjob.

This CL was submitted as CL:462518, and reverted as CL:464309. It was
also landed in CL:461333, and incorrectly reverted in
CL:467026. Taking advantage of that last revert to issue a deprecation
warning for the --use-buildbucket command line option.

BUG= chromium:671848 
TEST=run_tests

Change-Id: Ief2333f09566c482cf93515fc00217b50d5d59a6
Reviewed-on: https://chromium-review.googlesource.com/468106
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Chun-ta Lin <itspeter@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/6b0cf682fb338ae216657c1f97682f4a52c7489f/scripts/cbuildbot.py
[modify] https://crrev.com/6b0cf682fb338ae216657c1f97682f4a52c7489f/cbuildbot/stages/sync_stages.py

Status: Fixed (was: Untriaged)

Comment 12 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 14 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment