New issue
Advanced search Search tips

Issue 671838 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Implement Internals::mainThreadScrollingReasons for SPv2

Project Member Reported by chrishtr@chromium.org, Dec 6 2016

Issue description

See above. An example of a layout test that needs it is
compositing/layer-creation/iframe-background-attachment-fixed.html.
 

Comment 1 by pdr@chromium.org, Dec 6 2016

Cc: -pdr@chromium.org
Owner: pdr@chromium.org
Status: Assigned (was: Available)
I think we may be hitting this in https://codereview.chromium.org/2531603003.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bf0adfb29b2f4c92c658a31d5562cded817746b

commit 9bf0adfb29b2f4c92c658a31d5562cded817746b
Author: pdr <pdr@chromium.org>
Date: Sat Jan 14 00:50:32 2017

Implement Internals::mainThreadScrollingReasons for SPV2

This patch returns FrameView's main thread scrolling reasons
as a string which is used by Internals::mainThreadScrollingReasons.

TEST=compositing/layer-creation/iframe-background-attachment-fixed.html with
--additional-driver-flag=--enable-slimming-paint-v2

BUG= 671838 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2634493006
Cr-Commit-Position: refs/heads/master@{#443744}

[modify] https://crrev.com/9bf0adfb29b2f4c92c658a31d5562cded817746b/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/9bf0adfb29b2f4c92c658a31d5562cded817746b/third_party/WebKit/Source/core/frame/FrameView.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bf0adfb29b2f4c92c658a31d5562cded817746b

commit 9bf0adfb29b2f4c92c658a31d5562cded817746b
Author: pdr <pdr@chromium.org>
Date: Sat Jan 14 00:50:32 2017

Implement Internals::mainThreadScrollingReasons for SPV2

This patch returns FrameView's main thread scrolling reasons
as a string which is used by Internals::mainThreadScrollingReasons.

TEST=compositing/layer-creation/iframe-background-attachment-fixed.html with
--additional-driver-flag=--enable-slimming-paint-v2

BUG= 671838 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2634493006
Cr-Commit-Position: refs/heads/master@{#443744}

[modify] https://crrev.com/9bf0adfb29b2f4c92c658a31d5562cded817746b/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/9bf0adfb29b2f4c92c658a31d5562cded817746b/third_party/WebKit/Source/core/frame/FrameView.cpp

Comment 4 by pdr@chromium.org, Jan 14 2017

Status: Fixed (was: Assigned)

Sign in to add a comment