New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 671837 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Find-in-page auto-scroll misses location and currently-viewed highlight of first non-sticky result.

Project Member Reported by wkorman@chromium.org, Dec 6 2016

Issue description

Repro steps below. Not sure who best owner for this might be, let me know thoughts.

1. Visit http://www.bpgroupusa.com/OurLocations.html

2. Select 'Find...' or Ctrl-F and type 'concept'

3. Note there are three results. Watch the yellow "document markers" in the scroll bar. The results in the page are:

  a. A small "BP CONCEPT" in the top of page nav bar which at least behaves as position: sticky (but is probably implemented in JS)
  b. Pasadena 'concept store'
  c. Cupertino 'concept store'

If you click the down-arrow in the Find popup repeatedly, you'll see strange behavior in that the scrollbar auto-scrolls to only (b) and (c), but when you are first auto-scrolled to (b) it highlights (a) in the nav bar, and when you click or type return to view next, it auto-scrolls to (c) and highlights (b), and then if you click again it stays on (c) and finally highlights (c).

So, at no point are you viewing (b) with (b) highlighted. And some of the time, likely due to flaky JS/CSS interactions, you'll be at (b) location but (a) isn't actually visible because nav bar is hidden due to attempting to detect scroll state, so you're looking at (b) but it's highlighted as a match but not the 'currently being viewed' match (highlighting as a match on Linux is orange highlight with black text; 'currently being viewed' match is yellow highlight with black text).

I can provide screenshots if the above is too unclear. Try it and see, easier than writing a description.

It is ambiguous what "location" one must be at in the page when viewing a sticky-nav-bar type of element. If the element is currently visible then staying where one is currently seems fine as long as the text being sought is highlighted.

In any case, the current behavior definitely seems weird. If the text is present three places in the document we should auto-scroll to three locations. Perhaps due to the hide/show of the element there are at times only two places where text is present in the document. But there are alwa

This could be working-as-intended but filing to solicit opinions.
 
Components: Blink>Scroll
Hmm, I'm unable to reproduce "at no point are you viewing (b) with (b) highlighted".  On Linux stable and ToT I see the orange highlight and scroll position both in sync with the "n of 3" text for (b) and (c).

I do see that we are unable to scroll to (a), and that the visibility of the header depends on the direction of the most recent change to the scroll position.  But that's a side effect of the JS on the page.
Status: WontFix (was: Assigned)

Sign in to add a comment