New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 671832 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocking:
issue 672616



Sign in to add a comment

[sync] Add autofill sync metadata to the web db

Project Member Reported by pnoland@chromium.org, Dec 6 2016

Issue description

Add tables for sync metadata to the web db and add methods to AutofillTable to read/write/delete this data. 
 
Components: Services>Sync
Labels: Sync-V2
Blocking: 672616
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/285a1dabd3a38350900c07648b91a74aeacb2089

commit 285a1dabd3a38350900c07648b91a74aeacb2089
Author: pnoland <pnoland@chromium.org>
Date: Sat Dec 10 02:05:13 2016

[sync] Add autofill sync metadata to the web db

Two types of sync metadata, once stored in the sync directory, are now being
migrated to the web database. These two types are the per-entry EntityMetadata
and the ModelTypeState, which is globalstate for the autofill model type. This
change adds a migration to add the tables and functions on AutofillTable to
read/write/delete it, with associated tests.

BUG= 671832 

R=shess@chromium.org,mathp@chromium.org,pavely@chromium.org

Review-Url: https://codereview.chromium.org/2550293002
Cr-Commit-Position: refs/heads/master@{#437722}

[modify] https://crrev.com/285a1dabd3a38350900c07648b91a74aeacb2089/components/autofill/core/browser/webdata/autofill_table.cc
[modify] https://crrev.com/285a1dabd3a38350900c07648b91a74aeacb2089/components/autofill/core/browser/webdata/autofill_table.h
[modify] https://crrev.com/285a1dabd3a38350900c07648b91a74aeacb2089/components/autofill/core/browser/webdata/autofill_table_unittest.cc
[add] https://crrev.com/285a1dabd3a38350900c07648b91a74aeacb2089/components/test/data/web_database/version_69.sql
[modify] https://crrev.com/285a1dabd3a38350900c07648b91a74aeacb2089/components/webdata/common/BUILD.gn
[modify] https://crrev.com/285a1dabd3a38350900c07648b91a74aeacb2089/components/webdata/common/web_database.cc
[modify] https://crrev.com/285a1dabd3a38350900c07648b91a74aeacb2089/components/webdata/common/web_database_migration_unittest.cc

Status: Fixed (was: Started)
This is all done isn't it? Marking it fixed.

Sign in to add a comment