New issue
Advanced search Search tips

Issue 671828 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Harmony - LayoutDelegate should specify control label text alignment

Project Member Reported by shrike@chromium.org, Dec 6 2016

Issue description

Control labels in Harmony are left-aligned, whereas they were right-aligned pre-Harmony. The LayoutDelegate should return an alignment parameter of type Alignment from views::GridLayout.

 
Status: Started (was: Assigned)
https://codereview.chromium.org/2556563005
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4aff4df5f338661a2b9c5449ebfe0c33d4311d75

commit 4aff4df5f338661a2b9c5449ebfe0c33d4311d75
Author: ellyjones <ellyjones@chromium.org>
Date: Thu Dec 08 19:18:27 2016

views: add harmony control label alignment

Harmony specifies leading alignment for these; the old UI style
used trailing alignment mostly, but was inconsistent. This change:

1) Adds HarmonyLayoutDelegate::GetControlLabelGridAlignment();
2) Changes CookieInfoView (used in the collected cookies dialog) to
   use GetControlLabelGridAlignment;
3) Changes the bookmark bubble from leading to trailing alignment

BUG= 671828 

Review-Url: https://codereview.chromium.org/2556563005
Cr-Commit-Position: refs/heads/master@{#437303}

[modify] https://crrev.com/4aff4df5f338661a2b9c5449ebfe0c33d4311d75/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc
[modify] https://crrev.com/4aff4df5f338661a2b9c5449ebfe0c33d4311d75/chrome/browser/ui/views/cookie_info_view.cc
[modify] https://crrev.com/4aff4df5f338661a2b9c5449ebfe0c33d4311d75/chrome/browser/ui/views/harmony/harmony_layout_delegate.cc
[modify] https://crrev.com/4aff4df5f338661a2b9c5449ebfe0c33d4311d75/chrome/browser/ui/views/harmony/harmony_layout_delegate.h
[modify] https://crrev.com/4aff4df5f338661a2b9c5449ebfe0c33d4311d75/chrome/browser/ui/views/harmony/layout_delegate.cc
[modify] https://crrev.com/4aff4df5f338661a2b9c5449ebfe0c33d4311d75/ui/views/layout/layout_constants.h

Is this bug Fixed (and further work to use the framework added here is part of the individual "convert dialog XXX" bugs)?

Comment 4 by shrike@chromium.org, Jan 25 2017

ellyjones@ is on leave but I believe this issue is fixed.
Status: Fixed (was: Started)
Yep, this is fixed. Individual dialogs still do need to make use of it but the machinery is there.

Sign in to add a comment