Harmony - LayoutDelegate should specify control label text alignment |
||
Issue descriptionControl labels in Harmony are left-aligned, whereas they were right-aligned pre-Harmony. The LayoutDelegate should return an alignment parameter of type Alignment from views::GridLayout.
,
Dec 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4aff4df5f338661a2b9c5449ebfe0c33d4311d75 commit 4aff4df5f338661a2b9c5449ebfe0c33d4311d75 Author: ellyjones <ellyjones@chromium.org> Date: Thu Dec 08 19:18:27 2016 views: add harmony control label alignment Harmony specifies leading alignment for these; the old UI style used trailing alignment mostly, but was inconsistent. This change: 1) Adds HarmonyLayoutDelegate::GetControlLabelGridAlignment(); 2) Changes CookieInfoView (used in the collected cookies dialog) to use GetControlLabelGridAlignment; 3) Changes the bookmark bubble from leading to trailing alignment BUG= 671828 Review-Url: https://codereview.chromium.org/2556563005 Cr-Commit-Position: refs/heads/master@{#437303} [modify] https://crrev.com/4aff4df5f338661a2b9c5449ebfe0c33d4311d75/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc [modify] https://crrev.com/4aff4df5f338661a2b9c5449ebfe0c33d4311d75/chrome/browser/ui/views/cookie_info_view.cc [modify] https://crrev.com/4aff4df5f338661a2b9c5449ebfe0c33d4311d75/chrome/browser/ui/views/harmony/harmony_layout_delegate.cc [modify] https://crrev.com/4aff4df5f338661a2b9c5449ebfe0c33d4311d75/chrome/browser/ui/views/harmony/harmony_layout_delegate.h [modify] https://crrev.com/4aff4df5f338661a2b9c5449ebfe0c33d4311d75/chrome/browser/ui/views/harmony/layout_delegate.cc [modify] https://crrev.com/4aff4df5f338661a2b9c5449ebfe0c33d4311d75/ui/views/layout/layout_constants.h
,
Jan 25 2017
Is this bug Fixed (and further work to use the framework added here is part of the individual "convert dialog XXX" bugs)?
,
Jan 25 2017
ellyjones@ is on leave but I believe this issue is fixed.
,
Jan 26 2017
Yep, this is fixed. Individual dialogs still do need to make use of it but the machinery is there. |
||
►
Sign in to add a comment |
||
Comment 1 by ellyjo...@chromium.org
, Dec 7 2016