New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 671821 link

Starred by 2 users
Status: Duplicate
Merged: issue 438323
Owner:
vmp...@chromium.org
Closed: Feb 2017
Cc:
█ aleksand...@intel.com
vmp...@chromium.org
ericrk@chromium.org
cblume@chromium.org
enne@chromium.org
khushals...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Feature



Sign in to add a comment

Decode sub-rects for images embedded in SkImageShader

Project Member Reported by ericrk@chromium.org, Dec 6 2016 
Currently, the ImageHijackCanvas introspects and replaces images in simple SkImageShaders. These images may be clipped based on the area being painted by the SkImageShader and the matrix applied to the image.

We currently always decode the full image. Instead we should determine the actual image region we need and decode a subrect.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/086f1d82d4911d3f5e67aa8eb56c2515af23cc7d

commit 086f1d82d4911d3f5e67aa8eb56c2515af23cc7d
Author: ericrk <ericrk@chromium.org>
Date: Wed Dec 07 02:28:11 2016

Add bug to TODO for handling SkImageShader subrects

R=vmpstr
BUG= 671821 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2561463002
Cr-Commit-Position: refs/heads/master@{#436841}

[modify] https://crrev.com/086f1d82d4911d3f5e67aa8eb56c2515af23cc7d/cc/playback/discardable_image_map.cc

Comment 2 by vmp...@chromium.org, Dec 8 2016

Cc: aleksand...@intel.com
Owner: vmp...@chromium.org
Status: Assigned (was: Available)
Assigning to myself for tracking.

+aleksandar.stojiljkovic since this might be related to  issue 438323 , in the sense that we might utilize the decoder to do some of the work which we currently do in the compositor.

Comment 3 by aleksand...@intel.com, Dec 8 2016 

Independently, came to a similar conclusion here:
https://bugs.chromium.org/p/chromium/issues/detail?id=438323#c64
In addition to scale decoding for JPEG (there might also be a possibility for tile decoding for JPEGs), there is another full size image copy we can save on for scaled (and here for tile/subrect decoding).
https://bugs.chromium.org/p/chromium/issues/detail?id=438323#c64

Comment 4 by vmp...@chromium.org, Feb 3 2017

Mergedinto: 438323
Status: Duplicate (was: Assigned)
I'm going to dupe this into r438323 since there isn't any meaningful new information here.
►

Sign in to add a comment