This link appears ok:

https://codereview.chromium.org/2544793003/patch/50001/5764577597849600

but this one shows the problem:

https://codereview.chromium.org/2544793003/diff/50001/third_party/hunspell/src/parsers/testparser.cxx

(and the test build fails) so it appears to be there, but in a borked state.

ping? This is holding up the CL. thx

When I remove the ISO8825 chars it works, however obviously I can't submit a modified license.

krb@ to be very honest, it's unlikely we'll come up with fixes for you in reasonable time even if we spent the whole day on it.

Thus, if you want to land your change before holidays, consider uploading it to Gerrit:

  1. copy your patch to a new branch (very important)
  2. git cl upload --bypass-hooks --gerrit
  3. git cl web => copy-paste URL and send to your reviewers
  You can't **yet** try OR land Gerrit issues easily. So:
  4. git cl try -b <try-bot-manual> -b <more trybot>
    (for trybot names, see https://chromium.googlesource.com/chromium/src/+/master/infra/config/cq.cfg)
  5. manually land && watch waterfall for tree breakages:
     git cl issue 0 && git cl land --rietveld

Spoke with Kevin over IM. He’s going to convert the files to UTF-8.

Kevin, once your upload is complete, feel free to follow up on this bug.