Important sites - underreporting metrics & blacklist not always triggering |
|||||
Issue descriptionThe metrics and blacklist calculations should be always recorded when the user is shown the dialog. Currently we only record when the user deselects items in the dialog - so we don't record any sites if the user ignored the dialog entirely. This limited metric reporting AND adding ignored sites to the blacklist.
,
Dec 14 2016
Asking for 56 merge. This is a metrics-only change. It would help us out a lot if we can get this in the beta asap.
,
Dec 14 2016
oops, not metrics-only, it will make the blacklist operate correctly as well, which is a feature bug.
,
Dec 14 2016
Your change meets the bar and is auto-approved for M56 (branch: 2924)
,
Dec 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dad55b7ef4196472de177ee0baeb4a6df654fcbf commit dad55b7ef4196472de177ee0baeb4a6df654fcbf Author: Daniel Murphy <dmurph@chromium.org> Date: Wed Dec 14 16:44:24 2016 [ImportantSites] Fixed important sites metrics & blacklisting The important sites metrics & blacklist triggering wasn't notified when the user totally ignored the dialog and didn't deselect anything. R=twellington@chromium.org BUG= 671815 Review-Url: https://codereview.chromium.org/2553053003 Cr-Commit-Position: refs/heads/master@{#437080} (cherry picked from commit 8cdeb8f50132914ed7a2817e982ed2e067e95ba9) Review URL: https://codereview.chromium.org/2577613003 . Cr-Commit-Position: refs/branch-heads/2924@{#489} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/dad55b7ef4196472de177ee0baeb4a6df654fcbf/chrome/browser/android/preferences/pref_service_bridge.cc
,
Jan 5 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by bugdroid1@chromium.org
, Dec 7 2016